pk
/
slstatus
mirror of https://github.com/pikami/slstatus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
slstatus/components/load_avg.c

20 lines
375 B
C
Raw Normal View History

Added LICENSE statements to all source files
2017-09-17 16:45:03 +01:00
/* See LICENSE file for copyright and license details. */
Get rid of err.h as it is not portable Replace warn() and warnx() with fprintf() and add <stdio.h> where necessary.
2018-03-28 17:26:56 +01:00
#include <stdio.h>
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 15:18:17 +01:00
#include <stdlib.h>
Move components into dedicated subdirectory This brings us a lot more tidiness.
2017-09-24 14:33:01 +01:00
#include "../util.h"
components/*.c: include slstatus.h this gives the compiler a chance to check weather the prototype and definiton matches or not, which would catch issues like 3c47701.
2022-10-26 21:14:53 +01:00
#include "../slstatus.h"
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 15:18:17 +01:00
const char *
do not rely on obsolete feature function prototype with unspecified argument is obsolete since c99. additionally some of these function which don't take any argument were being called with a `const char *` arg, which is UB. fix both these issues by declararing ALL the components to accept a `const char *`, and name the arg "unused" if it's meant to be ignored.
2022-10-26 21:16:05 +01:00
load_avg(const char *unused)
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 15:18:17 +01:00
{
double avgs[3];
if (getloadavg(avgs, 3) < 0) {
Add warn() and die() Given slstatus is a tool that runs in the background, most likely run from .xinitrc, it's important to prepend the name of the tool to error messages so it becomes clear where the error is coming from. To make this much more consistent, this commit adds warn() and die() utility functions consistent with other suckless projects and adapts all calls to fprintf(stderr, *) to the warn() and die() functions, greatly increasing the readability of the code.
2018-05-18 09:59:05 +01:00
warn("getloadavg: Failed to obtain load average");
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 15:18:17 +01:00
return NULL;
}
Remove fmt from load_avgs for consistency In a later commit something like that will be enabled for every component
2018-05-21 13:14:45 +01:00
return bprintf("%.2f %.2f %.2f", avgs[0], avgs[1], avgs[2]);
Split into multiple files For multiple reasons the program is now split: - Make future porting to OpenBSD easier - Assign header includes to individiual functions - Make future program extensions easier - Recompile only changed parts
2017-09-17 15:18:17 +01:00
}