24 Commits

Author SHA1 Message Date
ZHANG Yuntian
339d6c4d89 rtl8723ds: Update comments with UTF-8 encoding
When packaging the source as a Debian DKMS package, lintian will warn
national-encoding due to Big5 encoded characters in comments.

Update to English comments from other files when available, and
reencode Chinese in UTF-8.

Signed-off-by: ZHANG Yuntian <yt@radxa.com>
2023-05-05 14:35:35 +08:00
Larry Finger
1a8f8b1557 rtl8723ds: Clean up some Coverity and Smatch warnings
The includes turning CONGIG_MP_INCLUDED off.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2023-02-03 19:28:56 -06:00
Giulio Benetti
aaf31f36eb rtl8723ds: get_ra() exists only on PowerPC
In PowerPc Linux only get_ra() exists[0] and conflicts with local get_ra()
that has a completely different purpose. So let's rename local get_ra()
to wifi_get_ra() to make it different from Linux's get_ra().

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/include/asm/disassemble.h?h=v6.1-rc7#n49

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
2022-12-01 15:24:08 +01:00
John Keeping
255c827ec1 rtl8723ds: fix sta_info alignment
Allocation function return memory that is properly aligned for most data
types, there is no need to manually align the buffer later.

On 64-bit systems this is particularly wrong as struct sta_info should
be 8-byte aligned so this calculation is guaranteed to misalign the
structure.  If the architecture requires aligned access, this leads to
an alignment fault and panic.

Signed-off-by: John Keeping <john@metanate.com>
2022-11-29 18:39:10 +00:00
Heinrich Schuchardt
5ce43b6183 rtl8723ds: fix rtw_mfree_stainfo()
Building with GCC 12.2 results in:

/var/lib/dkms/licheerv-rtl8723ds/1.0/build/core/rtw_sta_mgt.c:
In function ‘rtw_mfree_stainfo’:
/var/lib/dkms/licheerv-rtl8723ds/1.0/build/core/rtw_sta_mgt.c:338:25:
warning: the comparison will always evaluate as ‘true’ for
the address of ‘lock’ will never be NULL [-Waddress]
  338 |         if (&psta->lock != NULL)
      |

Remove the superfluous check.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
2022-10-20 14:28:31 +02:00
John-Eric Kamps
b80b52a36e rtl8723ds: Fix build with kernel 5.15
Signed-off-by: John-Eric Kamps <johnny86@gmx.de>
2022-01-17 23:28:21 +01:00
Larry Finger
9837ccab16 rtl8723ds: Fix some smatch warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2021-03-18 16:42:51 -05:00
Larry Finger
c54996f3a7 rtl8723ds: Fix builds for kernel 5.8+
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2020-09-17 11:19:09 -05:00
Larry Finger
4ae3c679a9 rtl8723ds: Fix "ielen" not initialized
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2020-04-11 11:35:18 -05:00
John-Eric Kamps
17db5978f6 rtl8723ds: Fix fallthrough annotation
Signed-off-by: John-Eric Kamps <john-eric.kamps@honeywell.com>
2020-04-11 08:51:45 +02:00
Larry Finger
3030a734d7 rtl8723ds: Update source for recent API changes
The source will now compile on kernels up to 4.20.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2018-11-29 11:43:26 -06:00
Larry Finger
5949fdf1cc rtl8723ds: Fix more Sparse errors
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-27 15:25:56 -05:00
Larry Finger
ef471acce1 rtl8723ds: Fix Sparse errors/warnings in core/rtw_security.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-27 14:53:08 -05:00
Larry Finger
d532a1ebc5 rtl8723ds: Fix another context imbalance and some big-endian errors
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-25 14:11:25 -05:00
Larry Finger
781d065f23 rtl8723ds: Fix another different lock contexts for basic block error
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-25 14:01:50 -05:00
Larry Finger
c69a20ba17 rtl8723ds: Fix a couple of errors in overlapping locks
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-25 13:56:39 -05:00
Larry Finger
1621248cc1 rtl8723ds: Make fixes for more Sparse errors
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-25 11:34:05 -05:00
Larry Finger
3c1cb50012 rtl8723ds: Remove PLATFORM_LINUX symbol - it is the only one supported
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-16 23:55:54 -05:00
Larry Finger
58d8344823 rtl8723ds: Remove code for FREEBSD, OS_XP and OS_CE
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-16 21:52:02 -05:00
Larry Finger
c3c991544f rtl8723ds: Remove WINDOWS code
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-16 20:43:56 -05:00
Larry Finger
27368d0b9c rtl8723ds: Fix some checkpatch warnings and change default log level
The default debug level is reduced from 4 to 2.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-16 16:38:46 -05:00
Larry Finger
452f4494cd rtl8723ds: Fix some Sparse warnings
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-14 16:19:56 -05:00
Larry Finger
eb9c1aa49f rtl8723ds: Fix builds for kernel 4.14
Signed-off-by: Alexander Kaplan <alex@nextthing.co>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-10-14 09:31:11 -05:00
Larry Finger
e87533e664 rtl8723ds: Initial commit of files
This repository contains the Realtek driver V5.1.1.5_20523.20161209_BTCOEX20161208-1212.

At inclusion, the only changes from the Realtek version were to fix any compile
warnings or errors. With these changes, the driver builds on kernels through
4.11.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
2017-04-25 10:13:42 -05:00