random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2024-11-29 08:56:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more unit tests. Add lcov coverage report to display in vscode

Browse Source
This commit is contained in:
Laurent Nguyen 2024-05-07 11:34:17 +02:00
parent 57afc3886b
commit 0222a06ba3
3 changed files with 141 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jest.config.js
View File

@ -31,7 +31,7 @@ module.exports = {
coveragePathIgnorePatterns: ["/node_modules/"], coveragePathIgnorePatterns: ["/node_modules/"],
// A list of reporter names that Jest uses when writing coverage reports // A list of reporter names that Jest uses when writing coverage reports
coverageReporters: ["json", "text", "cobertura"], coverageReporters: ["json", "text", "cobertura", "lcov"],
// An object that configures minimum threshold enforcement for coverage results // An object that configures minimum threshold enforcement for coverage results
coverageThreshold: { coverageThreshold: {

22
src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
View File

@ -97,7 +97,8 @@ let renderObjectForEditor = (
space: string | number, space: string | number,
): string => JSON.stringify(value, replacer, space); ): string => JSON.stringify(value, replacer, space);
const getSaveNewDocumentButtonState = (editorState: ViewModels.DocumentExplorerState) => ({ // Export to expose to unit tests
export const getSaveNewDocumentButtonState = (editorState: ViewModels.DocumentExplorerState) => ({
enabled: (() => { enabled: (() => {
switch (editorState) { switch (editorState) {
case ViewModels.DocumentExplorerState.newDocumentValid: case ViewModels.DocumentExplorerState.newDocumentValid:
@ -118,7 +119,8 @@ const getSaveNewDocumentButtonState = (editorState: ViewModels.DocumentExplorerS
})(), })(),
}); });
const getDiscardNewDocumentChangesButtonState = (editorState: ViewModels.DocumentExplorerState) => ({ // Export to expose to unit tests
export const getDiscardNewDocumentChangesButtonState = (editorState: ViewModels.DocumentExplorerState) => ({
enabled: (() => { enabled: (() => {
switch (editorState) { switch (editorState) {
case ViewModels.DocumentExplorerState.newDocumentValid: case ViewModels.DocumentExplorerState.newDocumentValid:
@ -140,7 +142,8 @@ const getDiscardNewDocumentChangesButtonState = (editorState: ViewModels.Documen
})(), })(),
}); });
const getSaveExistingDocumentButtonState = (editorState: ViewModels.DocumentExplorerState) => ({ // Export to expose to unit tests
export const getSaveExistingDocumentButtonState = (editorState: ViewModels.DocumentExplorerState) => ({
enabled: (() => { enabled: (() => {
switch (editorState) { switch (editorState) {
case ViewModels.DocumentExplorerState.exisitingDocumentDirtyValid: case ViewModels.DocumentExplorerState.exisitingDocumentDirtyValid:
@ -162,7 +165,8 @@ const getSaveExistingDocumentButtonState = (editorState: ViewModels.DocumentExpl
})(), })(),
}); });
const getDiscardExistingDocumentChangesButtonState = (editorState: ViewModels.DocumentExplorerState) => ({ // Export to expose to unit tests
export const getDiscardExistingDocumentChangesButtonState = (editorState: ViewModels.DocumentExplorerState) => ({
enabled: (() => { enabled: (() => {
switch (editorState) { switch (editorState) {
case ViewModels.DocumentExplorerState.exisitingDocumentDirtyInvalid: case ViewModels.DocumentExplorerState.exisitingDocumentDirtyInvalid:
@ -185,7 +189,8 @@ const getDiscardExistingDocumentChangesButtonState = (editorState: ViewModels.Do
})(), })(),
}); });
const getDeleteExistingDocumentButtonState = ( // Export to expose to unit tests
export const getDeleteExistingDocumentButtonState = (
editorState: ViewModels.DocumentExplorerState, editorState: ViewModels.DocumentExplorerState,
selectedRows: Set<TableRowId>, selectedRows: Set<TableRowId>,
) => ({ ) => ({
@ -213,7 +218,9 @@ const getDeleteExistingDocumentButtonState = (
}); });
type UiKeyboardEvent = (e: KeyboardEvent | React.SyntheticEvent<Element, Event>) => void; type UiKeyboardEvent = (e: KeyboardEvent | React.SyntheticEvent<Element, Event>) => void;
type ButtonsDependencies = {
// Export to expose to unit tests
export type ButtonsDependencies = {
_collection: ViewModels.CollectionBase; _collection: ViewModels.CollectionBase;
selectedRows: Set<TableRowId>; selectedRows: Set<TableRowId>;
editorState: ViewModels.DocumentExplorerState; editorState: ViewModels.DocumentExplorerState;
@ -245,7 +252,8 @@ const createUploadButton = (container: Explorer): CommandButtonComponentProps =>
}; };
}; };
const getTabsButtons = ({ // Export to expose in unit tests
export const getTabsButtons = ({
_collection, _collection,
selectedRows, selectedRows,
editorState, editorState,

126
src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.test.tsx
View File

@ -1,4 +1,14 @@
import { TableRowId } from "@fluentui/react-components"; import { TableRowId } from "@fluentui/react-components";
import { DocumentExplorerState } from "Contracts/ViewModels";
import {
ButtonsDependencies,
getDeleteExistingDocumentButtonState,
getDiscardExistingDocumentChangesButtonState,
getDiscardNewDocumentChangesButtonState,
getSaveExistingDocumentButtonState,
getSaveNewDocumentButtonState,
getTabsButtons,
} from "Explorer/Tabs/DocumentsTabV2/DocumentsTabV2";
import { ReactWrapper, mount } from "enzyme"; import { ReactWrapper, mount } from "enzyme";
import React from "react"; import React from "react";
import { DocumentsTableComponent, IDocumentsTableComponentProps } from "./DocumentsTableComponent"; import { DocumentsTableComponent, IDocumentsTableComponentProps } from "./DocumentsTableComponent";
@ -30,8 +40,122 @@ describe("DocumentsTableComponent", () => {
}, },
}); });
let wrapper: ReactWrapper; describe("when getting command bar button state", () => {
describe("should set Save New Document state", () => {
const testCases = new Set<{ state: DocumentExplorerState; enabled: boolean; visible: boolean }>();
testCases.add({ state: DocumentExplorerState.noDocumentSelected, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentValid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.newDocumentInvalid, enabled: false, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentNoEdits, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyValid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyInvalid, enabled: false, visible: false });
testCases.forEach((testCase) => {
const state = getSaveNewDocumentButtonState(testCase.state);
it(`enable for ${testCase.state}`, () => {
expect(state.enabled).toBe(testCase.enabled);
});
it(`visible for ${testCase.state}`, () => {
expect(state.visible).toBe(testCase.visible);
});
});
});
describe("should set Discard New Document state", () => {
const testCases = new Set<{ state: DocumentExplorerState; enabled: boolean; visible: boolean }>();
testCases.add({ state: DocumentExplorerState.noDocumentSelected, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentValid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.newDocumentInvalid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentNoEdits, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyValid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyInvalid, enabled: false, visible: false });
testCases.forEach((testCase) => {
const state = getDiscardNewDocumentChangesButtonState(testCase.state);
it(`enable for ${testCase.state}`, () => {
expect(state.enabled).toBe(testCase.enabled);
});
it(`visible for ${testCase.state}`, () => {
expect(state.visible).toBe(testCase.visible);
});
});
});
describe("should set Save Existing Document state", () => {
const testCases = new Set<{ state: DocumentExplorerState; enabled: boolean; visible: boolean }>();
testCases.add({ state: DocumentExplorerState.noDocumentSelected, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentValid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentInvalid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentNoEdits, enabled: false, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyValid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyInvalid, enabled: false, visible: true });
testCases.forEach((testCase) => {
const state = getSaveExistingDocumentButtonState(testCase.state);
it(`enable for ${testCase.state}`, () => {
expect(state.enabled).toBe(testCase.enabled);
});
it(`visible for ${testCase.state}`, () => {
expect(state.visible).toBe(testCase.visible);
});
});
});
describe("should set Discard Existing Document state", () => {
const testCases = new Set<{ state: DocumentExplorerState; enabled: boolean; visible: boolean }>();
testCases.add({ state: DocumentExplorerState.noDocumentSelected, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentValid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentInvalid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentNoEdits, enabled: false, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyValid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyInvalid, enabled: true, visible: true });
testCases.forEach((testCase) => {
const state = getDiscardExistingDocumentChangesButtonState(testCase.state);
it(`enable for ${testCase.state}`, () => {
expect(state.enabled).toBe(testCase.enabled);
});
it(`visible for ${testCase.state}`, () => {
expect(state.visible).toBe(testCase.visible);
});
});
});
describe("should set Delete Existing Document state", () => {
const testCases = new Set<{ state: DocumentExplorerState; enabled: boolean; visible: boolean }>();
testCases.add({ state: DocumentExplorerState.noDocumentSelected, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentValid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.newDocumentInvalid, enabled: false, visible: false });
testCases.add({ state: DocumentExplorerState.exisitingDocumentNoEdits, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyValid, enabled: true, visible: true });
testCases.add({ state: DocumentExplorerState.exisitingDocumentDirtyInvalid, enabled: true, visible: true });
testCases.forEach((testCase) => {
const state = getDeleteExistingDocumentButtonState(testCase.state, new Set<TableRowId>());
it(`enable for ${testCase.state} (no selected rows)`, () => {
expect(state.enabled).toBe(testCase.enabled);
});
it(`visible for ${testCase.state} (no selected rows)`, () => {
expect(state.visible).toBe(false);
});
// state = getDeleteExistingDocumentButtonState(testCase.state, new Set<TableRowId>([2, 1]));
// it(`enable for ${testCase.state} (2 selected rows)`, () => {
// expect(state.enabled).toBe(testCase.enabled);
// });
// it(`visible for ${testCase.state} (2 selected rows)`, () => {
// expect(state.visible).toBe(testCase.visible);
// });
});
});
});
describe("Do not get tabs button for Fabric readonly", () => {
const buttons = getTabsButtons({} as ButtonsDependencies);
});
describe("when rendered", () => { describe("when rendered", () => {
let wrapper: ReactWrapper;
beforeEach(() => { beforeEach(() => {
const props: IDocumentsTableComponentProps = createMockProps(); const props: IDocumentsTableComponentProps = createMockProps();
wrapper = mount(<DocumentsTableComponent {...props} />); wrapper = mount(<DocumentsTableComponent {...props} />);