From 0b7cbfbf233f10596e2f5c5e2c78effa0928f226 Mon Sep 17 00:00:00 2001 From: Sung-Hyun Kang Date: Tue, 13 Aug 2024 13:06:01 -0500 Subject: [PATCH] move nps survey open dialog call to after explorer initialization --- src/Common/MessageHandler.ts | 1 + src/Explorer/Explorer.tsx | 1 - src/hooks/useKnockoutExplorer.ts | 5 +---- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Common/MessageHandler.ts b/src/Common/MessageHandler.ts index 2a986f835..a96369c55 100644 --- a/src/Common/MessageHandler.ts +++ b/src/Common/MessageHandler.ts @@ -70,6 +70,7 @@ export function sendMessage(data: any): void { } export function sendReadyMessage(): void { + console.log("SENDING READY MESSAGE"); _sendMessage({ signature: "pcIframe", kind: "ready", diff --git a/src/Explorer/Explorer.tsx b/src/Explorer/Explorer.tsx index 2af452dcd..39c12c2bb 100644 --- a/src/Explorer/Explorer.tsx +++ b/src/Explorer/Explorer.tsx @@ -187,7 +187,6 @@ export default class Explorer { } this.refreshExplorer(); - this.openNPSSurveyDialog(); } public async initiateAndRefreshNotebookList(): Promise { diff --git a/src/hooks/useKnockoutExplorer.ts b/src/hooks/useKnockoutExplorer.ts index 87edf3365..ed7b762bc 100644 --- a/src/hooks/useKnockoutExplorer.ts +++ b/src/hooks/useKnockoutExplorer.ts @@ -83,6 +83,7 @@ export function useKnockoutExplorer(platform: Platform): Explorer { useEffect(() => { if (explorer) { applyExplorerBindings(explorer); + explorer.openNPSSurveyDialog(); } }, [explorer]); @@ -588,10 +589,6 @@ async function configurePortal(): Promise { explorer = new Explorer(); resolve(explorer); - // if (userContext.apiType === "Postgres" || userContext.apiType === "SQL" || userContext.apiType === "Mongo") { - // setTimeout(() => explorer.openNPSSurveyDialog(), 3000); - // } - if (openAction) { handleOpenAction(openAction, useDatabases.getState().databases, explorer); }