diff --git a/.github/workflows/cleanup.yml b/.github/workflows/cleanup.yml index b2d3471af..b045f3bd3 100644 --- a/.github/workflows/cleanup.yml +++ b/.github/workflows/cleanup.yml @@ -21,11 +21,9 @@ jobs: runs-on: ubuntu-latest env: AZURE_SUBSCRIPTION_ID: ${{ secrets.E2ETESTS_SUBSCRIPTION_ID }} + E2ETESTS_RESOURCEGROUP_NAME : ${{ secrets.E2ETESTS_RESOURCEGROUP_NAME }} steps: - uses: actions/checkout@v4 - env: - E2ETESTS_RESOURCEGROUP_NAME : ${{ secrets.E2ETESTS_RESOURCEGROUP_NAME }} - - name: "Az CLI login" uses: azure/login@v2 with: diff --git a/package-lock.json b/package-lock.json index b395c7b51..8a9556528 100644 --- a/package-lock.json +++ b/package-lock.json @@ -93,7 +93,7 @@ "react-youtube": "9.0.1", "reflect-metadata": "0.1.13", "rx-jupyter": "5.5.12", - "shell-quote": "1.8.4", + "shell-quote": "1.10.0", "styled-components": "5.0.1", "swr": "0.4.0", "terser-webpack-plugin": "5.3.9", @@ -24639,9 +24639,9 @@ } }, "node_modules/shell-quote": { - "version": "1.8.4", - "resolved": "https://registry.npmjs.org/shell-quote/-/shell-quote-1.8.4.tgz", - "integrity": "sha512-VsC6n6vz1ihYYyZZwX7YZSF5l5x36ca17OC+a69h94YqB7X6XLwf+5MOgynYir2SLFUbl8gIYvBo8K8RoNQ6bQ==", + "version": "1.10.0", + "resolved": "https://registry.npmjs.org/shell-quote/-/shell-quote-1.10.0.tgz", + "integrity": "sha512-w1aiOKwKuRgtwAReIIj89puqg+I7GvX4IbLrvmhXbzQsj1+Zwi4VO3+fa6ZF91TWSjIxoEkKnMeHcLEODK5ZXA==", "license": "MIT", "engines": { "node": ">= 0.4" diff --git a/package.json b/package.json index a178123f8..b428174b1 100644 --- a/package.json +++ b/package.json @@ -88,7 +88,7 @@ "react-youtube": "9.0.1", "reflect-metadata": "0.1.13", "rx-jupyter": "5.5.12", - "shell-quote": "1.8.4", + "shell-quote": "1.10.0", "styled-components": "5.0.1", "swr": "0.4.0", "terser-webpack-plugin": "5.3.9", diff --git a/src/Contracts/ViewModels.ts b/src/Contracts/ViewModels.ts index 2df718293..dcb19f1a8 100644 --- a/src/Contracts/ViewModels.ts +++ b/src/Contracts/ViewModels.ts @@ -406,6 +406,7 @@ export enum TerminalKind { Cassandra = 2, Postgres = 3, VCoreMongo = 4, + CosmosDB = 5, } export interface DataExplorerInputsFrame { diff --git a/src/Explorer/Controls/VectorSearch/VectorEmbeddingPoliciesComponent.tsx b/src/Explorer/Controls/VectorSearch/VectorEmbeddingPoliciesComponent.tsx index cce26189d..c40bb88a9 100644 --- a/src/Explorer/Controls/VectorSearch/VectorEmbeddingPoliciesComponent.tsx +++ b/src/Explorer/Controls/VectorSearch/VectorEmbeddingPoliciesComponent.tsx @@ -2,6 +2,7 @@ import { DefaultButton, Dropdown, IDropdownOption, + ILabelStyleProps, IStyleFunctionOrObject, ITextFieldStyleProps, ITextFieldStyles, @@ -18,6 +19,7 @@ import { getIndexTypeOptions, getQuantizerTypeOptions, supportsQuantization, + supportsQuantizationByteSize, } from "Explorer/Controls/VectorSearch/VectorSearchUtils"; import { Keys, t } from "Localization"; import React, { FunctionComponent, useState } from "react"; @@ -54,11 +56,13 @@ export interface VectorEmbeddingPolicyData { type VectorEmbeddingPolicyProperty = "dataType" | "distanceFunction" | "indexType"; -const labelStyles = { - root: { - fontSize: 12, - color: "var(--colorNeutralForeground1)", - }, +const labelStyles = (props: ILabelStyleProps) => { + return { + root: { + fontSize: 12, + color: props.disabled ? "var(--colorNeutralForeground3)" : "var(--colorNeutralForeground1)", + }, + }; }; const textFieldStyles: IStyleFunctionOrObject = { @@ -166,7 +170,7 @@ export const VectorEmbeddingPoliciesComponent: FunctionComponent { const vectorEmbeddings = [...vectorEmbeddingPolicyData]; - vectorEmbeddings[index].quantizerType = option.key as VectorIndex["quantizerType"]; + const quantizerType = option.key as VectorIndex["quantizerType"]; + vectorEmbeddings[index].quantizerType = quantizerType; + if (!supportsQuantizationByteSize(quantizerType)) { + vectorEmbeddings[index].quantizationByteSize = undefined; + } setVectorEmbeddingPolicyData(vectorEmbeddings); }; @@ -434,30 +445,6 @@ export const VectorEmbeddingPoliciesComponent: FunctionComponent - - - ) => - onQuantizationByteSizeChange(index, event) - } - /> - + + + ) => + onQuantizationByteSizeChange(index, event) + } + /> +