diff --git a/src/SelfServe/Example/SelfServeExample.tsx b/src/SelfServe/Example/SelfServeExample.tsx index 7b975cb40..5570f01d8 100644 --- a/src/SelfServe/Example/SelfServeExample.tsx +++ b/src/SelfServe/Example/SelfServeExample.tsx @@ -171,7 +171,7 @@ export default class SelfServeExample extends SelfServeBaseClass { public getSelfServeType = (): SelfServeType => { return SelfServeType.example; - } + }; @Values({ labelTKey: "DescriptionLabel", diff --git a/src/SelfServe/GraphAPICompute/GraphAPICompute.tsx b/src/SelfServe/GraphAPICompute/GraphAPICompute.tsx index 5ac872cee..83e04e628 100644 --- a/src/SelfServe/GraphAPICompute/GraphAPICompute.tsx +++ b/src/SelfServe/GraphAPICompute/GraphAPICompute.tsx @@ -362,7 +362,7 @@ export default class GraphAPICompute extends SelfServeBaseClass { public getSelfServeType = (): SelfServeType => { return SelfServeType.graphapicompute; - } + }; @Values({ isDynamicDescription: true, diff --git a/src/SelfServe/MaterializedViewsBuilder/MaterializedViewsBuilder.tsx b/src/SelfServe/MaterializedViewsBuilder/MaterializedViewsBuilder.tsx index 29cfd844e..f381fd800 100644 --- a/src/SelfServe/MaterializedViewsBuilder/MaterializedViewsBuilder.tsx +++ b/src/SelfServe/MaterializedViewsBuilder/MaterializedViewsBuilder.tsx @@ -361,7 +361,7 @@ export default class MaterializedViewsBuilder extends SelfServeBaseClass { public getSelfServeType = (): SelfServeType => { return SelfServeType.materializedviewsbuilder; - } + }; @Values({ isDynamicDescription: true, diff --git a/src/SelfServe/SelfServeTypes.ts b/src/SelfServe/SelfServeTypes.ts index 8ca97ab91..4c4fd7801 100644 --- a/src/SelfServe/SelfServeTypes.ts +++ b/src/SelfServe/SelfServeTypes.ts @@ -122,7 +122,7 @@ export abstract class SelfServeBaseClass { public abstract onRefresh: () => Promise; public abstract getSelfServeType: () => SelfServeType; - test: string = "hello" + /**@internal */ public toSelfServeDescriptor(): SelfServeDescriptor { const className: string = this.getSelfServeType(); diff --git a/src/SelfServe/SelfServeUtils.test.tsx b/src/SelfServe/SelfServeUtils.test.tsx index c6d203927..fa55641ac 100644 --- a/src/SelfServe/SelfServeUtils.test.tsx +++ b/src/SelfServe/SelfServeUtils.test.tsx @@ -1,5 +1,10 @@ import { NumberUiType, OnSaveResult, RefreshResult, SelfServeBaseClass, SmartUiInput } from "./SelfServeTypes"; -import { DecoratorProperties, mapToSmartUiDescriptor, updateContextWithDecorator } from "./SelfServeUtils"; +import { + DecoratorProperties, + mapToSmartUiDescriptor, + SelfServeType, + updateContextWithDecorator, +} from "./SelfServeUtils"; describe("SelfServeUtils", () => { it("initialize should be declared for self serve classes", () => { @@ -7,6 +12,7 @@ describe("SelfServeUtils", () => { public initialize: () => Promise>; public onSave: (currentValues: Map) => Promise; public onRefresh: () => Promise; + public getSelfServeType: () => SelfServeType; } expect(() => new Test().toSelfServeDescriptor()).toThrow("initialize() was not declared for the class 'Test'"); }); @@ -16,6 +22,7 @@ describe("SelfServeUtils", () => { public initialize = jest.fn(); public onSave: () => Promise; public onRefresh: () => Promise; + public getSelfServeType: () => SelfServeType; } expect(() => new Test().toSelfServeDescriptor()).toThrow("onSave() was not declared for the class 'Test'"); }); @@ -25,6 +32,7 @@ describe("SelfServeUtils", () => { public initialize = jest.fn(); public onSave = jest.fn(); public onRefresh: () => Promise; + public getSelfServeType: () => SelfServeType; } expect(() => new Test().toSelfServeDescriptor()).toThrow("onRefresh() was not declared for the class 'Test'"); }); @@ -34,6 +42,7 @@ describe("SelfServeUtils", () => { public initialize = jest.fn(); public onSave = jest.fn(); public onRefresh = jest.fn(); + public getSelfServeType = jest.fn(); } expect(() => new Test().toSelfServeDescriptor()).toThrow( "@IsDisplayable decorator was not declared for the class 'Test'", diff --git a/src/SelfServe/SqlX/SqlX.tsx b/src/SelfServe/SqlX/SqlX.tsx index d5b12fbaf..06e60d1e0 100644 --- a/src/SelfServe/SqlX/SqlX.tsx +++ b/src/SelfServe/SqlX/SqlX.tsx @@ -398,7 +398,7 @@ export default class SqlX extends SelfServeBaseClass { public getSelfServeType = (): SelfServeType => { return SelfServeType.sqlx; - } + }; @Values({ isDynamicDescription: true,