diff --git a/src/Bindings/ReactBindingHandler.ts b/src/Bindings/ReactBindingHandler.ts index bbd6c5b76..297b8a242 100644 --- a/src/Bindings/ReactBindingHandler.ts +++ b/src/Bindings/ReactBindingHandler.ts @@ -22,13 +22,7 @@ export interface ReactAdapter { export class Registerer { public static register(): void { ko.bindingHandlers.react = { - init: ( - element: any, - wrappedValueAccessor: () => any, - allBindings?: ko.AllBindings, - viewModel?: any, - bindingContext?: ko.BindingContext - ) => { + init: (element: any, wrappedValueAccessor: () => any) => { const adapter: ReactAdapter = wrappedValueAccessor(); if (adapter.setElement) { diff --git a/src/Common/Splitter.ts b/src/Common/Splitter.ts index 5785aa8ec..cf2518812 100644 --- a/src/Common/Splitter.ts +++ b/src/Common/Splitter.ts @@ -73,7 +73,7 @@ export class Splitter { $(this.leftSide).resizable(splitterOptions); } - private onResizeStart: JQueryUI.ResizableEvent = (e: Event, ui: JQueryUI.ResizableUIParams) => { + private onResizeStart: JQueryUI.ResizableEvent = () => { if (this.direction === SplitterDirection.Vertical) { $(".ui-resizable-helper").height("100%"); } else { @@ -82,9 +82,7 @@ export class Splitter { $("iframe").css("pointer-events", "none"); }; - private onResizeStop: JQueryUI.ResizableEvent = (e: Event, ui: JQueryUI.ResizableUIParams) => { - $("iframe").css("pointer-events", "auto"); - }; + private onResizeStop: JQueryUI.ResizableEvent = () => $("iframe").css("pointer-events", "auto"); public collapseLeft() { this.lastX = $(this.splitter).position().left; diff --git a/src/Explorer/Controls/InputTypeahead/InputTypeahead.ts b/src/Explorer/Controls/InputTypeahead/InputTypeahead.ts index 14d9ca8dd..03a3b0d87 100644 --- a/src/Explorer/Controls/InputTypeahead/InputTypeahead.ts +++ b/src/Explorer/Controls/InputTypeahead/InputTypeahead.ts @@ -128,21 +128,21 @@ class InputTypeaheadViewModel { }, }, callback: { - onClick: (node: any, a: any, item: OnClickItem, event: any) => { + onClick: (_node: unknown, _a: unknown, item: OnClickItem) => { cache.selection = item; if (params.selection) { params.selection(item); } }, - onResult(node: any, query: any, result: any, resultCount: any, resultCountPerGroup: any) { + onResult(_node: unknown, query: any) { cache.inputValue = query; if (params.inputValue) { params.inputValue(query); } }, }, - template: (query: string, item: any) => { + template: (_query: string, item: any) => { // Don't display id if caption *IS* the id return item.caption === item.value ? "{{caption}}" diff --git a/src/Explorer/Notebook/NotebookComponent/__mocks__/rx-jupyter.ts b/src/Explorer/Notebook/NotebookComponent/__mocks__/rx-jupyter.ts index b16feaf4c..312637fce 100644 --- a/src/Explorer/Notebook/NotebookComponent/__mocks__/rx-jupyter.ts +++ b/src/Explorer/Notebook/NotebookComponent/__mocks__/rx-jupyter.ts @@ -11,7 +11,7 @@ let fakeAjaxResponse: AjaxResponse = { responseType: "json", }; export const sessions = { - create: (serverConfig: unknown, body: object): Observable => of(fakeAjaxResponse), + create: (): Observable => of(fakeAjaxResponse), __setResponse: (response: AjaxResponse) => { fakeAjaxResponse = response; }, diff --git a/src/Explorer/Notebook/NotebookContentClient.ts b/src/Explorer/Notebook/NotebookContentClient.ts index 6679a7e1d..e7f14b112 100644 --- a/src/Explorer/Notebook/NotebookContentClient.ts +++ b/src/Explorer/Notebook/NotebookContentClient.ts @@ -220,7 +220,7 @@ export class NotebookContentClient { return this.contentProvider .remove(this.getServerConfig(), path) .toPromise() - .then((xhr: AjaxResponse) => path); + .then(() => path); } /** diff --git a/src/Explorer/Tree/AccessibleVerticalList.ts b/src/Explorer/Tree/AccessibleVerticalList.ts index 9a0ce3943..be701bb93 100644 --- a/src/Explorer/Tree/AccessibleVerticalList.ts +++ b/src/Explorer/Tree/AccessibleVerticalList.ts @@ -23,7 +23,7 @@ export class AccessibleVerticalList { this.onSelect = onSelect; } - public onKeyDown = (source: any, event: KeyboardEvent): boolean => { + public onKeyDown = (_src: unknown, event: KeyboardEvent): boolean => { const targetContainer: Element = event.target; if (this.items == null || this.items.length === 0) { // no items so this should be a noop diff --git a/src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts b/src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts index cdb5705dc..f6416fe1c 100644 --- a/src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts +++ b/src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts @@ -2,11 +2,11 @@ import { IResourceProviderClient } from "../ResourceProvider/IResourceProviderCl import { NotebookWorkspace } from "../Contracts/DataModels"; export class NotebookWorkspaceSettingsProviderClient implements IResourceProviderClient { - public async deleteAsync(url: string, apiVersion: string): Promise { + public async deleteAsync(_url: string, _apiVersion: string): Promise { throw new Error("Not yet implemented"); } - public async postAsync(url: string, body: any, apiVersion: string): Promise { + public async postAsync(_url: string, _body: any, _apiVersion: string): Promise { return Promise.resolve({ notebookServerEndpoint: "http://localhost:8888", username: "", @@ -14,37 +14,37 @@ export class NotebookWorkspaceSettingsProviderClient implements IResourceProvide }); } - public async getAsync(url: string, apiVersion: string): Promise { + public async getAsync(): Promise { throw new Error("Not yet implemented"); } - public async putAsync(url: string, body: any, apiVersion: string): Promise { + public async putAsync(): Promise { throw new Error("Not yet implemented"); } - public async patchAsync(url: string, apiVersion: string): Promise { + public async patchAsync(): Promise { throw new Error("Not yet implemented"); } } export class NotebookWorkspaceResourceProviderClient implements IResourceProviderClient { - public async deleteAsync(url: string, apiVersion: string): Promise { + public async deleteAsync(): Promise { throw new Error("Not yet implemented"); } - public async postAsync(url: string, body: any, apiVersion: string): Promise { + public async postAsync(): Promise { throw new Error("Not yet implemented"); } - public async getAsync(url: string, apiVersion: string): Promise { + public async getAsync(): Promise { throw new Error("Not yet implemented"); } - public async putAsync(url: string, body: any, apiVersion: string): Promise { + public async putAsync(): Promise { throw new Error("Not yet implemented"); } - public async patchAsync(url: string, body: any, apiVersion: string): Promise { + public async patchAsync(): Promise { throw new Error("Not yet implemented"); } } diff --git a/src/Terminal/index.ts b/src/Terminal/index.ts index d9cd73898..eb272a1a5 100644 --- a/src/Terminal/index.ts +++ b/src/Terminal/index.ts @@ -9,7 +9,7 @@ import { HttpHeaders, TerminalQueryParams } from "../Common/Constants"; const getUrlVars = (): { [key: string]: string } => { const vars: { [key: string]: string } = {}; - window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, (m, key, value): string => { + window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, (_m, key, value): string => { vars[key] = decodeURIComponent(value); return value; }); diff --git a/tsconfig.strict.json b/tsconfig.strict.json index d69793c12..6d5634918 100644 --- a/tsconfig.strict.json +++ b/tsconfig.strict.json @@ -4,7 +4,8 @@ "noEmit": true, "strictNullChecks": true, "strict": true, - "noUnusedLocals": true + "noUnusedLocals": true, + "noUnusedParameters": true }, "files": [ "./src/AuthType.ts",