From 1af44fb207a3cc0a2bfda215ae793b40e90d398f Mon Sep 17 00:00:00 2001 From: hardiknai-techm <80053762+hardiknai-techm@users.noreply.github.com> Date: Tue, 9 Mar 2021 04:40:24 +0530 Subject: [PATCH] Fix Lint errors in JunoUtil (#484) --- .eslintignore | 1 - src/Explorer/Panes/GitHubReposPane.ts | 2 +- src/Utils/JunoUtils.test.ts | 2 +- src/Utils/JunoUtils.ts | 32 +++++++++++++-------------- 4 files changed, 17 insertions(+), 20 deletions(-) diff --git a/.eslintignore b/.eslintignore index 0f0b908f1..d29ce45fd 100644 --- a/.eslintignore +++ b/.eslintignore @@ -275,7 +275,6 @@ src/Utils/AuthorizationUtils.test.ts src/Utils/AuthorizationUtils.ts src/Utils/DatabaseAccountUtils.test.ts src/Utils/DatabaseAccountUtils.ts -src/Utils/JunoUtils.ts src/Utils/MessageValidation.ts src/Utils/NotebookConfigurationUtils.ts src/Utils/PricingUtils.test.ts diff --git a/src/Explorer/Panes/GitHubReposPane.ts b/src/Explorer/Panes/GitHubReposPane.ts index 2ba2517bf..b360b1865 100644 --- a/src/Explorer/Panes/GitHubReposPane.ts +++ b/src/Explorer/Panes/GitHubReposPane.ts @@ -6,7 +6,7 @@ import { IPinnedRepo, JunoClient } from "../../Juno/JunoClient"; import { Action, ActionModifiers } from "../../Shared/Telemetry/TelemetryConstants"; import * as TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor"; import * as GitHubUtils from "../../Utils/GitHubUtils"; -import { JunoUtils } from "../../Utils/JunoUtils"; +import * as JunoUtils from "../../Utils/JunoUtils"; import { AuthorizeAccessComponent } from "../Controls/GitHub/AuthorizeAccessComponent"; import { GitHubReposComponent, GitHubReposComponentProps, RepoListItem } from "../Controls/GitHub/GitHubReposComponent"; import { GitHubReposComponentAdapter } from "../Controls/GitHub/GitHubReposComponentAdapter"; diff --git a/src/Utils/JunoUtils.test.ts b/src/Utils/JunoUtils.test.ts index 1bdb60e89..b08e0b168 100644 --- a/src/Utils/JunoUtils.test.ts +++ b/src/Utils/JunoUtils.test.ts @@ -1,6 +1,6 @@ import { RepoListItem } from "../Explorer/Controls/GitHub/GitHubReposComponent"; import { IPinnedRepo } from "../Juno/JunoClient"; -import { JunoUtils } from "./JunoUtils"; +import * as JunoUtils from "./JunoUtils"; import { IGitHubRepo } from "../GitHub/GitHubClient"; const gitHubRepo: IGitHubRepo = { diff --git a/src/Utils/JunoUtils.ts b/src/Utils/JunoUtils.ts index ecfcaf65d..cd6006a0f 100644 --- a/src/Utils/JunoUtils.ts +++ b/src/Utils/JunoUtils.ts @@ -2,21 +2,19 @@ import { RepoListItem } from "../Explorer/Controls/GitHub/GitHubReposComponent"; import { IGitHubRepo } from "../GitHub/GitHubClient"; import { IPinnedRepo } from "../Juno/JunoClient"; -export class JunoUtils { - public static toPinnedRepo(item: RepoListItem): IPinnedRepo { - return { - owner: item.repo.owner, - name: item.repo.name, - private: item.repo.private, - branches: item.branches.map((element) => ({ name: element.name })), - }; - } - - public static toGitHubRepo(pinnedRepo: IPinnedRepo): IGitHubRepo { - return { - owner: pinnedRepo.owner, - name: pinnedRepo.name, - private: pinnedRepo.private, - }; - } +export function toPinnedRepo(item: RepoListItem): IPinnedRepo { + return { + owner: item.repo.owner, + name: item.repo.name, + private: item.repo.private, + branches: item.branches.map((element) => ({ name: element.name })), + }; +} + +export function toGitHubRepo(pinnedRepo: IPinnedRepo): IGitHubRepo { + return { + owner: pinnedRepo.owner, + name: pinnedRepo.name, + private: pinnedRepo.private, + }; }