Make MongoShell ready message handler backwards compatible (#606)

* Make MongShell message handler backwards compatible

* Fix test title and add one more test case
This commit is contained in:
Armando Trejo Oliver
2021-04-02 12:38:53 -07:00
committed by GitHub
parent bd9bdad78a
commit 1b9070605e
4 changed files with 80 additions and 26519 deletions

View File

@@ -6,11 +6,11 @@ import * as ViewModels from "../../Contracts/ViewModels";
import { Action, ActionModifiers } from "../../Shared/Telemetry/TelemetryConstants";
import * as TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
import { userContext } from "../../UserContext";
import { isInvalidParentFrameOrigin } from "../../Utils/MessageValidation";
import { isInvalidParentFrameOrigin, isReadyMessage } from "../../Utils/MessageValidation";
import * as NotificationConsoleUtils from "../../Utils/NotificationConsoleUtils";
import Explorer from "../Explorer";
import template from "./MongoShellTab.html";
import { ConsoleDataType } from "../Menus/NotificationConsole/NotificationConsoleComponent";
import template from "./MongoShellTab.html";
import TabsBase from "./TabsBase";
export default class MongoShellTab extends TabsBase {
@@ -85,10 +85,7 @@ export default class MongoShellTab extends TabsBase {
}
private handleReadyMessage(event: MessageEvent, shellIframe: HTMLIFrameElement) {
if (typeof event.data["kind"] !== "string") {
return;
}
if (event.data.kind !== "ready") {
if (!isReadyMessage(event)) {
return;
}