random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-12-19 17:01:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove obsolete feature flags (and reformat) (#27)

Browse Source 
* Reformat

* Remove unused feature flags: graph, cacheOptimizations, settingsPane, throughputOverview, enableNteract
This commit is contained in:
Laurent Nguyen
2020-06-11 12:39:58 +02:00
committed by GitHub
parent 1662d20e8a
commit 23b2d8100f
6 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Explorer/Explorer.ts
View File

@@ -205,7 +205,6 @@ export default class Explorer implements ViewModels.Explorer {
// features
public isGalleryEnabled: ko.Computed<boolean>;
public isGitHubPaneEnabled: ko.Observable<boolean>;
public isGraphsEnabled: ko.Computed<boolean>;
public isHostedDataExplorerEnabled: ko.Computed<boolean>;
public isRightPanelV2Enabled: ko.Computed<boolean>;
public canExceedMaximumValue: ko.Computed<boolean>;
@@ -414,9 +413,6 @@ export default class Explorer implements ViewModels.Explorer {
this.shouldShowContextSwitchPrompt = ko.observable<boolean>(false);
this.isGalleryEnabled = ko.computed<boolean>(() => this.isFeatureEnabled(Constants.Features.enableGallery));
this.isGitHubPaneEnabled = ko.observable<boolean>(false);
this.isGraphsEnabled = ko.computed<boolean>(() => {
return this.isFeatureEnabled(Constants.Features.graphs);
});
this.canExceedMaximumValue = ko.computed<boolean>(() =>
this.isFeatureEnabled(Constants.Features.canExceedMaximumValue)
@@ -554,7 +550,9 @@ export default class Explorer implements ViewModels.Explorer {
!this.isRunningOnNationalCloud() &&
!this.isPreferredApiGraph()
);
this.isRightPanelV2Enabled = ko.computed<boolean>(() => this.isFeatureEnabled(Constants.Features.enableRightPanelV2));
this.isRightPanelV2Enabled = ko.computed<boolean>(() =>
this.isFeatureEnabled(Constants.Features.enableRightPanelV2)
);
this.defaultExperience.subscribe((defaultExperience: string) => {
if (
defaultExperience &&

1
src/Explorer/OpenActionsStubs.ts
View File

@@ -98,7 +98,6 @@ export class ExplorerStub implements ViewModels.Explorer {
public manageSparkClusterPane: ViewModels.ContextualPane;
public isGalleryEnabled: ko.Computed<boolean>;
public isGitHubPaneEnabled: ko.Observable<boolean>;
public isGraphsEnabled: ko.Computed<boolean>;
public isRightPanelV2Enabled: ko.Computed<boolean>;
public canExceedMaximumValue: ko.Computed<boolean>;
public isHostedDataExplorerEnabled: ko.Computed<boolean>;

9
src/Explorer/Panes/GenericRightPaneComponent.tsx
View File

@@ -49,7 +49,12 @@ export class GenericRightPaneComponent extends React.Component<GenericRightPaneP
return (
<div tabIndex={-1} onKeyDown={this.onKeyDown}>
<div className="contextual-pane-out" onClick={this.props.onClose}></div>
<div className="contextual-pane" id={this.props.id} style={{ height: this.state.panelHeight }} onKeyDown={this.onKeyDown}>
<div
className="contextual-pane"
id={this.props.id}
style={{ height: this.state.panelHeight }}
onKeyDown={this.onKeyDown}
>
<div className="panelContentWrapper">
{this.createPanelHeader()}
{this.createErrorSection()}
@@ -137,5 +142,5 @@ export class GenericRightPaneComponent extends React.Component<GenericRightPaneP
private getPanelHeight = (): number => {
const notificationConsoleElement: HTMLElement = document.getElementById("explorerNotificationConsole");
return window.innerHeight - $(notificationConsoleElement).height();
}
};
}

6
src/Explorer/Panes/UploadItemsPaneAdapter.tsx
View File

@@ -110,11 +110,7 @@ export class UploadItemsPaneAdapter implements ReactAdapter {
}
private createContent = (): JSX.Element => {
return (
<div className="panelContent">
{this.createMainContentSection()}
</div>
);
return <div className="panelContent">{this.createMainContentSection()}</div>;
};
private createMainContentSection = (): JSX.Element => {