diff --git a/.eslintignore b/.eslintignore index 3de1fdee0..59465ed96 100644 --- a/.eslintignore +++ b/.eslintignore @@ -104,7 +104,7 @@ src/Explorer/Tabs/MongoDocumentsTab.ts src/Explorer/Tabs/NotebookV2Tab.ts src/Explorer/Tabs/ScriptTabBase.ts src/Explorer/Tabs/TabComponents.ts -src/Explorer/Tabs/TabsBase.ts +# src/Explorer/Tabs/TabsBase.ts src/Explorer/Tabs/TriggerTab.ts src/Explorer/Tabs/UserDefinedFunctionTab.ts src/Explorer/Tree/AccessibleVerticalList.ts @@ -132,7 +132,7 @@ src/Shared/DefaultExperienceUtility.ts src/Shared/appInsights.ts src/SparkClusterManager/ArcadiaResourceManager.ts src/SparkClusterManager/SparkClusterManager.ts -src/Terminal/JupyterLabAppFactory.ts +# src/Terminal/JupyterLabAppFactory.ts src/Terminal/NotebookAppContracts.d.ts src/applyExplorerBindings.ts src/global.d.ts diff --git a/src/Explorer/Tabs/Tabs.tsx b/src/Explorer/Tabs/Tabs.tsx index 7948e871a..fea46c8e0 100644 --- a/src/Explorer/Tabs/Tabs.tsx +++ b/src/Explorer/Tabs/Tabs.tsx @@ -44,7 +44,7 @@ function TabNav({ tab, active }: { tab: Tab; active: boolean }) { onMouseOver={() => setHovering(true)} onMouseLeave={() => setHovering(false)} onClick={() => tab.onTabClick()} - onKeyPress={({ nativeEvent: e }) => tab.onKeyPressActivate(undefined, e)} + onKeyPress={({ nativeEvent: e }) => tab.onKeyPressActivate(e)} className={active ? "active tabList" : "tabList"} title={useObservable(tab.tabPath)} aria-selected={active} @@ -83,7 +83,7 @@ const CloseButton = ({ tab, active, hovering }: { tab: Tab; active: boolean; hov className="cancelButton" onClick={() => tab.onCloseTabButtonClick()} tabIndex={active ? 0 : undefined} - onKeyPress={({ nativeEvent: e }) => tab.onKeyPressClose(undefined, e)} + onKeyPress={({ nativeEvent: e }) => tab.onKeyPressClose(e)} > Close @@ -98,8 +98,8 @@ const ErrorIcon = ({ tab, active }: { tab: Tab; active: boolean }) => ( title="Click to view more details" tabIndex={active ? 0 : undefined} className={active ? "actionsEnabled errorIconContainer" : "errorIconContainer"} - onClick={({ nativeEvent: e }) => tab.onErrorDetailsClick(undefined, e)} - onKeyPress={({ nativeEvent: e }) => tab.onErrorDetailsKeyPress(undefined, e)} + onClick={() => tab.onErrorDetailsClick()} + onKeyPress={({ nativeEvent: e }) => tab.onErrorDetailsKeyPress(e)} > diff --git a/src/Explorer/Tabs/TabsBase.ts b/src/Explorer/Tabs/TabsBase.ts index 308bb451f..c96d72286 100644 --- a/src/Explorer/Tabs/TabsBase.ts +++ b/src/Explorer/Tabs/TabsBase.ts @@ -94,11 +94,11 @@ export default class TabsBase extends WaitsForTemplateViewModel { return true; } - public onKeyPressActivate = (source: any, event: KeyboardEvent): boolean => { + public onKeyPressActivate = (event: KeyboardEvent): boolean => { return this.onSpaceOrEnterKeyPress(event, () => this.onTabClick()); }; - public onKeyPressClose = (source: any, event: KeyboardEvent): boolean => { + public onKeyPressClose = (event: KeyboardEvent): boolean => { return this.onSpaceOrEnterKeyPress(event, () => this.onCloseTabButtonClick()); }; @@ -120,22 +120,22 @@ export default class TabsBase extends WaitsForTemplateViewModel { }); } - public onErrorDetailsClick = (src: any, event: MouseEvent): boolean => { + public onErrorDetailsClick = (): boolean => { useNotificationConsole.getState().expandConsole(); useNotificationConsole.getState().expandConsole(); return false; }; - public onErrorDetailsKeyPress = (src: any, event: KeyboardEvent): boolean => { + public onErrorDetailsKeyPress = (event: KeyboardEvent): boolean => { if (event.keyCode === Constants.KeyCodes.Space || event.keyCode === Constants.KeyCodes.Enter) { - this.onErrorDetailsClick(src, null); + this.onErrorDetailsClick(); return false; } return true; }; - public refresh() { + public refresh(): void { location.reload(); } @@ -144,6 +144,7 @@ export default class TabsBase extends WaitsForTemplateViewModel { } /** Renders a Javascript object to be displayed inside Monaco Editor */ + //eslint-disable-next-line public renderObjectForEditor(value: any, replacer: any, space: string | number): string { return JSON.stringify(value, replacer, space); } diff --git a/src/Terminal/JupyterLabAppFactory.ts b/src/Terminal/JupyterLabAppFactory.ts index a1eef5bbf..4d1f0b9a3 100644 --- a/src/Terminal/JupyterLabAppFactory.ts +++ b/src/Terminal/JupyterLabAppFactory.ts @@ -5,6 +5,7 @@ import { ServerConnection, TerminalManager } from "@jupyterlab/services"; import { Terminal } from "@jupyterlab/terminal"; import { Panel, Widget } from "@phosphor/widgets"; +// eslint-disable-next-line @typescript-eslint/no-extraneous-class export class JupyterLabAppFactory { public static async createTerminalApp(serverSettings: ServerConnection.ISettings) { const manager = new TerminalManager({ @@ -21,8 +22,8 @@ export class JupyterLabAppFactory { term.title.closable = false; term.addClass("terminalWidget"); - let panel = new Panel(); - panel.addWidget(term as any); + const panel = new Panel(); + panel.addWidget((term as unknown) as Widget); panel.id = "main"; // Attach the widget to the dom.