From 2527e4bd850f254cf27e545525dd73377705e785 Mon Sep 17 00:00:00 2001 From: Jade Welton Date: Thu, 21 May 2026 11:14:29 -0700 Subject: [PATCH] Remove obsolete firewall check for VCore Mongo CloudShell terminal CloudShell connects from Azure infrastructure and doesn't require a 0.0.0.0-255.255.255.255 firewall rule. The 'Open MongoDB (DocumentDB) shell' button already works without this check because BaseTerminalComponentAdapter skips the firewall gate for VCoreMongo/Mongo shell types. - Remove firewall check, notification, and related state from VCoreMongoQuickstartTab - Remove dead VCoreMongo firewall check from TerminalTab (was never enforced) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- src/Explorer/Tabs/TerminalTab.tsx | 10 ----- src/Explorer/Tabs/VCoreMongoQuickstartTab.tsx | 39 ++++--------------- 2 files changed, 7 insertions(+), 42 deletions(-) diff --git a/src/Explorer/Tabs/TerminalTab.tsx b/src/Explorer/Tabs/TerminalTab.tsx index 65a4e8680..aba2b1680 100644 --- a/src/Explorer/Tabs/TerminalTab.tsx +++ b/src/Explorer/Tabs/TerminalTab.tsx @@ -46,16 +46,6 @@ export default class TerminalTab extends TabsBase { this.isAllPublicIPAddressesEnabled, ); } - - if (options.kind === ViewModels.TerminalKind.VCoreMongo) { - checkFirewallRules( - "2023-03-01-preview", - (rule) => - rule.name.startsWith("AllowAllAzureServicesAndResourcesWithinAzureIps") || - (rule.properties.startIpAddress === "0.0.0.0" && rule.properties.endIpAddress === "255.255.255.255"), - this.isAllPublicIPAddressesEnabled, - ); - } } public getContainer(): Explorer { diff --git a/src/Explorer/Tabs/VCoreMongoQuickstartTab.tsx b/src/Explorer/Tabs/VCoreMongoQuickstartTab.tsx index 2bbdb8072..296910214 100644 --- a/src/Explorer/Tabs/VCoreMongoQuickstartTab.tsx +++ b/src/Explorer/Tabs/VCoreMongoQuickstartTab.tsx @@ -1,49 +1,24 @@ import { Stack } from "@fluentui/react"; -import { MessageTypes } from "Contracts/ExplorerContracts"; import { TerminalKind } from "Contracts/ViewModels"; import { CloudShellTerminalComponent } from "Explorer/Tabs/CloudShellTab/CloudShellTerminalComponent"; -import { QuickstartFirewallNotification } from "Explorer/Quickstart/QuickstartFirewallNotification"; import { VcoreMongoQuickstartGuide } from "Explorer/Quickstart/VCoreMongoQuickstartGuide"; -import { checkFirewallRules } from "Explorer/Tabs/Shared/CheckFirewallRules"; import { userContext } from "UserContext"; -import React, { useEffect, useState } from "react"; -import FirewallRuleScreenshot from "../../../images/vcoreMongoFirewallRule.png"; +import React from "react"; export const VcoreMongoQuickstartTab: React.FC = (): JSX.Element => { - const [isAllPublicIPAddressEnabled, setIsAllPublicIPAddressEnabled] = useState(true); - - useEffect(() => { - checkFirewallRules( - "2023-03-01-preview", - (rule) => - rule.name.startsWith("AllowAllAzureServicesAndResourcesWithinAzureIps") || - (rule.properties.startIpAddress === "0.0.0.0" && rule.properties.endIpAddress === "255.255.255.255"), - setIsAllPublicIPAddressEnabled, - ); - }); - return ( - {!isAllPublicIPAddressEnabled && ( - - )} - {isAllPublicIPAddressEnabled && ( - - )} + );