Add Files to TypeScript Strict Mode (#777)

This commit is contained in:
Sunil Kumar Yadav 2021-05-13 05:53:10 +05:30 committed by GitHub
parent d76aaca0dd
commit 2d506f0312
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 17 additions and 11 deletions

View File

@ -5,7 +5,7 @@ export interface TooltipProps {
children: string; children: string;
} }
export const InfoTooltip: React.FunctionComponent = ({ children }: TooltipProps) => { export const InfoTooltip: React.FunctionComponent<TooltipProps> = ({ children }: TooltipProps) => {
return ( return (
<span> <span>
<TooltipHost content={children}> <TooltipHost content={children}>

View File

@ -103,7 +103,7 @@ export const Dialog: FunctionComponent<DialogProps> = ({
text: secondaryButtonText, text: secondaryButtonText,
onClick: onSecondaryButtonClick, onClick: onSecondaryButtonClick,
} }
: undefined; : {};
return ( return (
<FluentDialog {...dialogProps}> <FluentDialog {...dialogProps}>

View File

@ -1,5 +1,5 @@
import { CommandButton, FontIcon, FontWeights, ITextProps, Separator, Stack, Text } from "@fluentui/react";
import * as React from "react"; import * as React from "react";
import { Stack, Text, Separator, FontIcon, CommandButton, FontWeights, ITextProps } from "@fluentui/react";
export class GalleryHeaderComponent extends React.Component { export class GalleryHeaderComponent extends React.Component {
private static readonly azureText = "Microsoft Azure"; private static readonly azureText = "Microsoft Azure";
@ -61,7 +61,7 @@ export class GalleryHeaderComponent extends React.Component {
<Stack.Item> <Stack.Item>
{this.renderHeaderItem( {this.renderHeaderItem(
GalleryHeaderComponent.galleryText, GalleryHeaderComponent.galleryText,
undefined, () => "",
GalleryHeaderComponent.headerItemTextProps GalleryHeaderComponent.headerItemTextProps
)} )}
</Stack.Item> </Stack.Item>

View File

@ -53,7 +53,7 @@ export class PromptPure extends React.Component<Props> {
} }
} }
const makeMapStateToProps = (state: CdbAppState, ownProps: ComponentProps): ((state: CdbAppState) => StateProps) => { const makeMapStateToProps = (_state: CdbAppState, ownProps: ComponentProps): ((state: CdbAppState) => StateProps) => {
const mapStateToProps = (state: CdbAppState) => { const mapStateToProps = (state: CdbAppState) => {
const { contentRef, id } = ownProps; const { contentRef, id } = ownProps;
const model = selectors.model(state, { contentRef }); const model = selectors.model(state, { contentRef });

View File

@ -1,10 +1,9 @@
import { AppState, ContentRef, DocumentRecordProps, selectors } from "@nteract/core";
import { RecordOf } from "immutable";
import React from "react"; import React from "react";
import { connect } from "react-redux"; import { connect } from "react-redux";
import "./CellLabeler.less"; import "./CellLabeler.less";
import { AppState, ContentRef, selectors, DocumentRecordProps } from "@nteract/core";
import { RecordOf } from "immutable";
interface ComponentProps { interface ComponentProps {
id: string; id: string;
contentRef: ContentRef; // TODO: Make this per contentRef? contentRef: ContentRef; // TODO: Make this per contentRef?
@ -29,7 +28,7 @@ class CellLabeler extends React.Component<ComponentProps & StateProps> {
} }
} }
const makeMapStateToProps = (state: AppState, ownProps: ComponentProps): ((state: AppState) => StateProps) => { const makeMapStateToProps = (_state: AppState, ownProps: ComponentProps): ((state: AppState) => StateProps) => {
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => {
const model = selectors.model(state, { contentRef: ownProps.contentRef }); const model = selectors.model(state, { contentRef: ownProps.contentRef });
const cellOrder = selectors.notebook.cellOrder(model as RecordOf<DocumentRecordProps>); const cellOrder = selectors.notebook.cellOrder(model as RecordOf<DocumentRecordProps>);

View File

@ -18,7 +18,7 @@ export async function fetchPhoto(accessToken: string): Promise<Blob | void> {
} }
export function useGraphPhoto(graphToken: string): string { export function useGraphPhoto(graphToken: string): string {
const [photo, setPhoto] = useState<string>(); const [photo, setPhoto] = useState<string>("");
useEffect(() => { useEffect(() => {
if (graphToken) { if (graphToken) {

View File

@ -8,6 +8,13 @@
"noUnusedParameters": true "noUnusedParameters": true
}, },
"files": [ "files": [
"./src/hooks/useGraphPhoto.tsx",
"./src/Explorer/Notebook/NotebookRenderer/decorators/CellLabeler.tsx",
"./src/Explorer/Notebook/NotebookRenderer/Prompt.tsx",
"./src/Explorer/Controls/Header/GalleryHeaderComponent.tsx",
"./src/Explorer/Controls/Header/GalleryHeaderComponent.tsx",
"./src/Explorer/Controls/Dialog.tsx",
"./src/Common/Tooltip/InfoTooltip.tsx",
"./src/AuthType.ts", "./src/AuthType.ts",
"./src/Bindings/ReactBindingHandler.ts", "./src/Bindings/ReactBindingHandler.ts",
"./src/Common/ArrayHashMap.ts", "./src/Common/ArrayHashMap.ts",
@ -129,4 +136,4 @@
"src/Terminal/**/*", "src/Terminal/**/*",
"src/Utils/arm/**/*" "src/Utils/arm/**/*"
] ]
} }