Move column selection out of mpac (#1980)

This commit is contained in:
Laurent Nguyen 2024-10-09 14:23:31 +02:00 committed by GitHub
parent aa88815c6e
commit 3138580eae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -38,7 +38,6 @@ import {
TextSortDescendingRegular, TextSortDescendingRegular,
} from "@fluentui/react-icons"; } from "@fluentui/react-icons";
import { NormalizedEventKey } from "Common/Constants"; import { NormalizedEventKey } from "Common/Constants";
import { Environment, getEnvironment } from "Common/EnvironmentUtility";
import { TableColumnSelectionPane } from "Explorer/Panes/TableColumnSelectionPane/TableColumnSelectionPane"; import { TableColumnSelectionPane } from "Explorer/Panes/TableColumnSelectionPane/TableColumnSelectionPane";
import { import {
ColumnSizesMap, ColumnSizesMap,
@ -228,31 +227,29 @@ export const DocumentsTableComponent: React.FC<IDocumentsTableComponentProps> =
<MenuItem key="refresh" icon={<ArrowClockwise16Regular />} onClick={onRefreshTable}> <MenuItem key="refresh" icon={<ArrowClockwise16Regular />} onClick={onRefreshTable}>
Refresh Refresh
</MenuItem> </MenuItem>
{[Environment.Development, Environment.Mpac].includes(getEnvironment()) && ( <>
<> <MenuItem
<MenuItem icon={<TextSortAscendingRegular />}
icon={<TextSortAscendingRegular />} onClick={(e) => onSortClick(e, column.id, "ascending")}
onClick={(e) => onSortClick(e, column.id, "ascending")} >
> Sort ascending
Sort ascending </MenuItem>
<MenuItem
icon={<TextSortDescendingRegular />}
onClick={(e) => onSortClick(e, column.id, "descending")}
>
Sort descending
</MenuItem>
<MenuItem icon={<ArrowResetRegular />} onClick={(e) => onSortClick(e, undefined, undefined)}>
Reset sorting
</MenuItem>
{!isColumnSelectionDisabled && (
<MenuItem key="editcolumns" icon={<EditRegular />} onClick={openColumnSelectionPane}>
Edit columns
</MenuItem> </MenuItem>
<MenuItem )}
icon={<TextSortDescendingRegular />} <MenuDivider />
onClick={(e) => onSortClick(e, column.id, "descending")} </>
>
Sort descending
</MenuItem>
<MenuItem icon={<ArrowResetRegular />} onClick={(e) => onSortClick(e, undefined, undefined)}>
Reset sorting
</MenuItem>
{!isColumnSelectionDisabled && (
<MenuItem key="editcolumns" icon={<EditRegular />} onClick={openColumnSelectionPane}>
Edit columns
</MenuItem>
)}
<MenuDivider />
</>
)}
<MenuItem <MenuItem
key="keyboardresize" key="keyboardresize"
icon={<TableResizeColumnRegular />} icon={<TableResizeColumnRegular />}
@ -260,25 +257,24 @@ export const DocumentsTableComponent: React.FC<IDocumentsTableComponentProps> =
> >
Resize with left/right arrow keys Resize with left/right arrow keys
</MenuItem> </MenuItem>
{[Environment.Development, Environment.Mpac].includes(getEnvironment()) && {!isColumnSelectionDisabled && (
!isColumnSelectionDisabled && ( <MenuItem
<MenuItem key="remove"
key="remove" icon={<DeleteRegular />}
icon={<DeleteRegular />} onClick={() => {
onClick={() => { // Remove column id from selectedColumnIds
// Remove column id from selectedColumnIds const index = selectedColumnIds.indexOf(column.id);
const index = selectedColumnIds.indexOf(column.id); if (index === -1) {
if (index === -1) { return;
return; }
} const newSelectedColumnIds = [...selectedColumnIds];
const newSelectedColumnIds = [...selectedColumnIds]; newSelectedColumnIds.splice(index, 1);
newSelectedColumnIds.splice(index, 1); onColumnSelectionChange(newSelectedColumnIds);
onColumnSelectionChange(newSelectedColumnIds); }}
}} >
> Remove column
Remove column </MenuItem>
</MenuItem> )}
)}
</MenuList> </MenuList>
</MenuPopover> </MenuPopover>
</Menu> </Menu>