random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2026-07-20 20:37:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade MSAL library version (#2454)

Browse Source 
* Reapply "MSAL browser migration changes"

This reverts commit 60a65efb7b.

* Fix redirect URI for localhost

* Fix URI for logout and other minor fix

* Remove unnecessary files

* Fix tests

* Fix tests

* Run npm format

* Address comments

* Address comment
This commit is contained in:
sindhuba
2026-04-08 10:40:06 -07:00
committed by GitHub
parent fb250259ed
commit 339ba4f295
12 changed files with 103 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Utils/AuthorizationUtils.test.ts
+13 -25
View File
@@ -1,12 +1,14 @@
import { AuthType } from "../AuthType";
import * as Constants from "../Common/Constants";
import { resetConfigContext, updateConfigContext } from "../ConfigContext";
import { resetConfigContext } from "../ConfigContext";
import { ApiType, updateUserContext, userContext } from "../UserContext";
import * as AuthorizationUtils from "./AuthorizationUtils";
jest.mock("../Explorer/Explorer");
jest.mock("@azure/msal-browser", () => ({
PublicClientApplication: jest.fn().mockImplementation((config) => ({
_config: config,
initialize: jest.fn().mockResolvedValue(undefined),
handleRedirectPromise: jest.fn().mockResolvedValue(null),
})),
}));
@@ -138,41 +140,27 @@ describe("AuthorizationUtils", () => {
});
describe("getMsalInstance()", () => {
const originalHostname = window.location.hostname;
const originalNodeEnv = process.env.NODE_ENV;
afterEach(() => {
process.env.NODE_ENV = originalNodeEnv;
resetConfigContext();
Object.defineProperty(window, "location", {
value: { ...window.location, hostname: originalHostname },
writable: true,
});
});
it("should use configContext.msalRedirectURI when set", async () => {
updateConfigContext({ msalRedirectURI: "https://dataexplorer-preview.azurewebsites.net/" });
it("should use dev redirect bridge URL in development mode", async () => {
process.env.NODE_ENV = "development";
const instance = await AuthorizationUtils.getMsalInstance();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
expect((instance as any)._config.auth.redirectUri).toBe("https://dataexplorer-preview.azurewebsites.net/");
expect((instance as any)._config.auth.redirectUri).toBe(
"https://dataexplorer-dev.azurewebsites.net/redirectBridge.html",
);
});
it("should use dev redirect URI on localhost", async () => {
Object.defineProperty(window, "location", {
value: { ...window.location, hostname: "localhost" },
writable: true,
});
it("should use origin-based redirect bridge URL in production", async () => {
process.env.NODE_ENV = "production";
const instance = await AuthorizationUtils.getMsalInstance();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
expect((instance as any)._config.auth.redirectUri).toBe("https://dataexplorer-dev.azurewebsites.net");
});
it("should not set redirect URI in non-localhost production", async () => {
Object.defineProperty(window, "location", {
value: { ...window.location, hostname: "cosmos.azure.com" },
writable: true,
});
const instance = await AuthorizationUtils.getMsalInstance();
// eslint-disable-next-line @typescript-eslint/no-explicit-any
expect((instance as any)._config.auth.redirectUri).toBeUndefined();
expect((instance as any)._config.auth.redirectUri).toBe("http://localhost/redirectBridge.html");
});
});
});