From 33a7412cf35abc7d5f5f0151c87329502fda8378 Mon Sep 17 00:00:00 2001 From: vchske Date: Fri, 7 Nov 2025 12:36:03 -0800 Subject: [PATCH] Removed broken feature to display PR url in DE console (#2249) --- preview/index.js | 7 +------ .../NotificationConsoleComponent.tsx | 17 ----------------- src/Platform/Hosted/extractFeatures.ts | 2 -- 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/preview/index.js b/preview/index.js index ff4421ca0..1320e3cb2 100644 --- a/preview/index.js +++ b/preview/index.js @@ -7,7 +7,6 @@ const backendEndpoint = "https://cdb-ms-mpac-pbe.cosmos.azure.com"; const previewSiteEndpoint = "https://dataexplorer-preview.azurewebsites.net"; const previewStorageWebsiteEndpoint = "https://dataexplorerpreview.z5.web.core.windows.net/"; const githubApiUrl = "https://api.github.com/repos/Azure/cosmos-explorer"; -const githubPullRequestUrl = "https://github.com/Azure/cosmos-explorer/pull"; const azurePortalMpacEndpoint = "https://ms.portal.azure.com/"; const api = createProxyMiddleware({ @@ -57,11 +56,7 @@ app.get("/pull/:pr(\\d+)", (req, res) => { fetch(`${githubApiUrl}/pulls/${pr}`) .then((response) => response.json()) - .then(({ head: { ref, sha } }) => { - const prUrl = new URL(`${githubPullRequestUrl}/${pr}`); - prUrl.hash = ref; - search.set("feature.pr", prUrl.href); - + .then(({ head: { sha } }) => { const explorer = new URL(`${previewSiteEndpoint}/commit/${sha}/explorer.html`); explorer.search = search.toString(); diff --git a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx index 1288ee5da..b96000cbb 100644 --- a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx +++ b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx @@ -16,7 +16,6 @@ import InfoIcon from "../../../../images/info_color.svg"; import LoadingIcon from "../../../../images/loading.svg"; import WarningIcon from "../../../../images/warning.svg"; import { ClientDefaults, KeyCodes } from "../../../Common/Constants"; -import { userContext } from "../../../UserContext"; import { useNotificationConsole } from "../../../hooks/useNotificationConsole"; import { ConsoleData, ConsoleDataType } from "./ConsoleData"; @@ -127,7 +126,6 @@ export class NotificationConsoleComponent extends React.Component< {numWarningItems} - {userContext.features.pr && } @@ -293,21 +291,6 @@ export class NotificationConsoleComponent extends React.Component< }; } -const PrPreview = (props: { pr: string }) => { - const url = new URL(props.pr); - const [, ref] = url.hash.split("#"); - url.hash = ""; - - return ( - <> - - - {ref} - - - ); -}; - export const NotificationConsole: React.FC = () => { const setIsExpanded = useNotificationConsole((state) => state.setIsExpanded); const isExpanded = useNotificationConsole((state) => state.isExpanded); diff --git a/src/Platform/Hosted/extractFeatures.ts b/src/Platform/Hosted/extractFeatures.ts index 80a5494a4..b5e324116 100644 --- a/src/Platform/Hosted/extractFeatures.ts +++ b/src/Platform/Hosted/extractFeatures.ts @@ -25,7 +25,6 @@ export type Features = { readonly notebookServerUrl?: string; readonly sandboxNotebookOutputs: boolean; readonly selfServeType?: string; - readonly pr?: string; readonly showMinRUSurvey: boolean; readonly ttl90Days: boolean; readonly mongoProxyEndpoint?: string; @@ -96,7 +95,6 @@ export function extractFeatures(given = new URLSearchParams(window.location.sear notebookServerUrl: get("notebookserverurl"), sandboxNotebookOutputs: "true" === get("sandboxnotebookoutputs", "true"), selfServeType: get("selfservetype"), - pr: get("pr"), showMinRUSurvey: "true" === get("showminrusurvey"), ttl90Days: "true" === get("ttl90days"), autoscaleDefault: "true" === get("autoscaledefault"),