Revert "Adding temporary console logging to track down issue (#2492)" (#2501)

This reverts commit 92a56f77b7.

.eslintrc.js

@@ -40,7 +40,7 @@ module.exports = {
     },
   ],
   rules: {
-    //CTODO temp removing this: "no-console": ["error", { allow: ["error", "warn", "dir"] }],
+    "no-console": ["error", { allow: ["error", "warn", "dir"] }],
     curly: "error",
     "@typescript-eslint/switch-exhaustiveness-check": "error",
     "@typescript-eslint/no-unused-vars": "error",

src/Common/ErrorHandlingUtils.ts

@@ -20,7 +20,6 @@ export const handleError = (
   consoleErrorPrefix?: string,
   options?: HandleErrorOptions,
 ): void => {
-  console.log("{{cdbp}} in handleError(): raw error: " + JSON.stringify(error)); //CTODO in case a stray error happens
   const errorMessage = getErrorMessage(error);
   const errorCode = error instanceof ARMError ? error.code : undefined;
 

src/Common/dataAccess/readDatabases.ts

@@ -26,7 +26,6 @@ export async function readDatabases(): Promise<DataModels.Database[]> {
     (userContext.fabricContext?.artifactInfo as FabricArtifactInfo[CosmosDbArtifactType.MIRRORED_KEY]).resourceTokenInfo
       .resourceTokens
   ) {
-    console.log("{{cdbp}} in readDatabases(): isFabricMirroredKey && has resourceTokens"); //CTODO should not get here
     const tokensData = (userContext.fabricContext.artifactInfo as FabricArtifactInfo[CosmosDbArtifactType.MIRRORED_KEY])
       .resourceTokenInfo;
 
@@ -60,7 +59,6 @@ export async function readDatabases(): Promise<DataModels.Database[]> {
     clearMessage();
     return databases;
   } else if (isFabricNative() && userContext.fabricContext?.databaseName) {
-    console.log("{{cdbp}} in readDatabases(): isFabricNative"); //CTODO should not get here
     const databaseId = userContext.fabricContext.databaseName;
     databases = [
       {
@@ -83,15 +81,9 @@ export async function readDatabases(): Promise<DataModels.Database[]> {
       userContext.apiType !== "Tables" &&
       !isFabric()
     ) {
-      console.log("{{cdbp}} in readDatabases(): authType == AAD, enableSDKOperations, apiType != Tables, !isFabric");
-      console.log("{{cdbp}} in readDatabases(): databaseaccount: " + userContext.databaseAccount);
-      console.log("{{cdbp}} in readDatabases(): calling readDatabasesWithARM");
       databases = await readDatabasesWithARM();
-      console.log("{{cdbp}} in readDatabases(): done readDatabasesWithARM");
     } else {
-      console.log("{{cdbp}} in readDatabases(): calling SDK");
       const sdkResponse = await client().databases.readAll().fetchAll();
-      console.log("{{cdbp}} in readDatabases(): done SDK");
       databases = sdkResponse.resources as DataModels.Database[];
     }
   } catch (error) {
@@ -116,30 +108,22 @@ export async function readDatabasesWithARM(accountOverride?: {
   const accountName = accountOverride?.accountName ?? userContext?.databaseAccount?.name ?? "";
   const apiType = accountOverride?.apiType ?? userContext.apiType;
 
-  try {
-    switch (apiType) {
-      case "SQL":
-        console.log("{{cdbp}} in readDatabasesWithARM(): calling listSqlDatabases");
-        rpResponse = await listSqlDatabases(subscriptionId, resourceGroup, accountName);
-        console.log("{{cdbp}} in readDatabasesWithARM(): done listSqlDatabases");
-        break;
-      case "Mongo":
-        rpResponse = await listMongoDBDatabases(subscriptionId, resourceGroup, accountName);
-        break;
-      case "Cassandra":
-        rpResponse = await listCassandraKeyspaces(subscriptionId, resourceGroup, accountName);
-        break;
-      case "Gremlin":
-        rpResponse = await listGremlinDatabases(subscriptionId, resourceGroup, accountName);
-        break;
-      default:
-        throw new Error(`Unsupported default experience type: ${apiType}`);
-    }
-
-    console.log("{{cdbp}} in readDatabasesWithARM(): response: " + JSON.stringify(rpResponse));
-    return rpResponse?.value?.map((database) => database.properties?.resource as DataModels.Database) ?? [];
-  } catch (error) {
-    console.log("{{cdbp}} in readDatabasesWithARM(): ERROR: " + JSON.stringify(error));
-    throw error;
+  switch (apiType) {
+    case "SQL":
+      rpResponse = await listSqlDatabases(subscriptionId, resourceGroup, accountName);
+      break;
+    case "Mongo":
+      rpResponse = await listMongoDBDatabases(subscriptionId, resourceGroup, accountName);
+      break;
+    case "Cassandra":
+      rpResponse = await listCassandraKeyspaces(subscriptionId, resourceGroup, accountName);
+      break;
+    case "Gremlin":
+      rpResponse = await listGremlinDatabases(subscriptionId, resourceGroup, accountName);
+      break;
+    default:
+      throw new Error(`Unsupported default experience type: ${apiType}`);
   }
+
+  return rpResponse?.value?.map((database) => database.properties?.resource as DataModels.Database) ?? [];
 }

src/Explorer/Explorer.tsx

@@ -405,27 +405,19 @@ export default class Explorer {
         },
         startKey,
       );
-      console.log("{{cdbp}} in refreshAllDatabases(): done readDatabases");
       const currentDatabases = useDatabases.getState().databases;
-      console.log("{{cdbp}} in refreshAllDatabases(): currentDatabases: " + currentDatabases);
       const deltaDatabases = this.getDeltaDatabases(databases, currentDatabases);
-      console.log("{{cdbp}} in refreshAllDatabases(): deltaDatabases: " + deltaDatabases);
       let updatedDatabases = currentDatabases.filter(
         (database) => !deltaDatabases.toDelete.some((deletedDatabase) => deletedDatabase.id() === database.id()),
       );
-      console.log("{{cdbp}} in refreshAllDatabases(): updatedDatabases after filter: " + updatedDatabases);
       updatedDatabases = [...updatedDatabases, ...deltaDatabases.toAdd].sort((db1, db2) =>
         db1.id().localeCompare(db2.id()),
       );
-      console.log("{{cdbp}} in refreshAllDatabases(): updatedDatabases after sort: " + updatedDatabases);
       useDatabases.setState({ databases: updatedDatabases, databasesFetchedSuccessfully: true });
       scenarioMonitor.completePhase(MetricScenario.DatabaseLoad, ApplicationMetricPhase.DatabasesFetched);
 
-      console.log("{{cdbp}} in refreshAllDatabases(): calling refreshAndExpandNewDatabases");
       await this.refreshAndExpandNewDatabases(deltaDatabases.toAdd, updatedDatabases);
-      console.log("{{cdbp}} in refreshAllDatabases(): done refreshAndExpandNewDatabases");
     } catch (error) {
-      console.log("{{cdbp}} in refreshAllDatabases(): ERROR: " + JSON.stringify(error)); //CTODO this should be logged already but just in case
       const errorMessage = getErrorMessage(error);
       TelemetryProcessor.traceFailure(
         Action.LoadDatabases,
@@ -615,7 +607,6 @@ export default class Explorer {
         ? databases
         : databases.filter((db) => db.isDatabaseExpanded() || db.id() === Constants.SavedQueries.DatabaseName);
 
-    console.log("{{cdbp}} in refreshAndExpandNewDatabases(): databasesToLoad: " + databasesToLoad);
     const startKey: number = TelemetryProcessor.traceStart(Action.LoadCollections, {
       dataExplorerArea: Constants.Areas.ResourceTree,
     });
@@ -624,7 +615,6 @@ export default class Explorer {
     try {
       await Promise.all(
         databasesToLoad.map(async (database: ViewModels.Database) => {
-          console.log("{{cdbp}} in refreshAndExpandNewDatabases(): loadCollections for database: " + database.id);
           await database.loadCollections(true);
           const isNewDatabase: boolean = _.some(newDatabases, (db: ViewModels.Database) => db.id() === database.id());
           if (isNewDatabase) {
@@ -644,7 +634,6 @@ export default class Explorer {
       // Start DatabaseTreeRendered — React render cycle will complete it in ResourceTree
       scenarioMonitor.startPhase(MetricScenario.DatabaseLoad, ApplicationMetricPhase.DatabaseTreeRendered);
     } catch (error) {
-      console.log("{{cdbp}} in refreshAndExpandNewDatabases(): ERROR: " + JSON.stringify(error)); //CTODO this should be logged already but just in case
       TelemetryProcessor.traceFailure(
         Action.LoadCollections,
         {

src/Utils/arm/generatedClients/cosmos/sqlResources.ts

@@ -6,9 +6,9 @@
   Generated from: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/main/specification/cosmos-db/resource-manager/Microsoft.DocumentDB/DocumentDB/preview/2025-11-01-preview/cosmos-db.json
 */
 
-import { configContext } from "../../../../ConfigContext";
 import { armRequest } from "../../request";
 import * as Types from "./types";
+import { configContext } from "../../../../ConfigContext";
 const apiVersion = "2025-11-01-preview";
 
 /* Lists the SQL databases under an existing Azure Cosmos DB database account. */
@@ -18,14 +18,7 @@ export async function listSqlDatabases(
   accountName: string,
 ): Promise<Types.SqlDatabaseListResult> {
   const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/sqlDatabases`;
-  console.log("{{cdbp}} in listSqlDatabases(): path: " + path);
-  try {
-    console.log("{{cdbp}} in listSqlDatabases(): calling armRequest");
-    return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "GET", apiVersion });
-  } catch (error) {
-    console.log("{{cdbp}} in listSqlDatabases(): ERROR: " + JSON.stringify(error));
-    throw error;
-  }
+  return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "GET", apiVersion });
 }
 
 /* Gets the SQL database under an existing Azure Cosmos DB database account with the provided name. */