From 38c3761260f1633717398b1528b49f21c28a86fc Mon Sep 17 00:00:00 2001 From: Sunil Kumar Yadav <79906609+sunilyadav840@users.noreply.github.com> Date: Fri, 17 Sep 2021 02:53:43 +0530 Subject: [PATCH] fixed input parameter keyboard accessibility issue (#1071) * fixed input parameter keyboard accessibility issue * Fixed autofocus and role issue * make autofocus on close button --- .../ExecuteSprocParamsPane.tsx | 2 +- .../ExecuteSprocParamsPane/InputParameter.tsx | 36 +- .../ExecuteSprocParamsPane.test.tsx.snap | 1232 +++++++++-------- 3 files changed, 646 insertions(+), 624 deletions(-) diff --git a/src/Explorer/Panes/ExecuteSprocParamsPane/ExecuteSprocParamsPane.tsx b/src/Explorer/Panes/ExecuteSprocParamsPane/ExecuteSprocParamsPane.tsx index eacbe9faa..064aadd5a 100644 --- a/src/Explorer/Panes/ExecuteSprocParamsPane/ExecuteSprocParamsPane.tsx +++ b/src/Explorer/Panes/ExecuteSprocParamsPane/ExecuteSprocParamsPane.tsx @@ -153,7 +153,7 @@ export const ExecuteSprocParamsPane: FunctionComponent ))} - + Add param Add New Param diff --git a/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx b/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx index 521ebc966..677158b61 100644 --- a/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx +++ b/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx @@ -59,30 +59,36 @@ export const InputParameter: FunctionComponent = ({ onChange={onParamKeyChange} options={options} styles={dropdownStyles} + tabIndex={0} /> {isAddRemoveVisible && ( <> - Delete param - Add param +
+ Delete param +
+
+ Add param +
)}
diff --git a/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap b/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap index bacad2933..4e673b39c 100644 --- a/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap +++ b/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap @@ -345,6 +345,7 @@ exports[`Excute Sproc Param Pane should render Default properly 1`] = ` }, } } + tabIndex={0} > - - -
- Delete param -
-
-
- + Delete param + + + + +
- -
- Add param -
-
- +
+ Add param +
+ + +