diff --git a/src/TestExplorer.ts b/src/TestExplorer.ts index 9395dfbcd..5a6789e0a 100644 --- a/src/TestExplorer.ts +++ b/src/TestExplorer.ts @@ -41,7 +41,7 @@ class TestExplorer { window.location.search .substr(1) .split("&") - .forEach((item) => { + .forEach(item => { const tmp = item.split("="); const value = decodeURIComponent(tmp[1]); switch (tmp[0]) { diff --git a/test/notebooks/uploadOpenAndDeleteNotebook.spec.ts b/test/notebooks/uploadOpenAndDeleteNotebook.spec.ts index f80795547..7a37ba159 100644 --- a/test/notebooks/uploadOpenAndDeleteNotebook.spec.ts +++ b/test/notebooks/uploadOpenAndDeleteNotebook.spec.ts @@ -6,22 +6,29 @@ jest.setTimeout(300000); describe("Notebook UI tests", () => { it("Upload, Open and Delete Notebook", async () => { - const frame = await getTestExplorerFrame(); - const uploadNotebookName = "GettingStarted.ipynb"; - const uploadNotebookPath = path.join(__dirname, "testNotebooks", uploadNotebookName); + try { + const frame = await getTestExplorerFrame(); + const uploadNotebookName = "GettingStarted.ipynb"; + const uploadNotebookPath = path.join(__dirname, "testNotebooks", uploadNotebookName); - await uploadNotebook(frame, uploadNotebookPath); - const uploadedNotebookNode = await getNotebookNode(frame, uploadNotebookName); + await uploadNotebook(frame, uploadNotebookPath); + const uploadedNotebookNode = await getNotebookNode(frame, uploadNotebookName); - await uploadedNotebookNode.click(); - await frame.waitForSelector(".tabNavText"); - const tabTitle = await frame.$eval(".tabNavText", element => element.textContent); - expect(tabTitle).toEqual(uploadNotebookName); - const closeIcon = await frame.waitForSelector(".close-Icon"); - await closeIcon.click(); + await uploadedNotebookNode.click(); + await frame.waitForSelector(".tabNavText"); + const tabTitle = await frame.$eval(".tabNavText", element => element.textContent); + expect(tabTitle).toEqual(uploadNotebookName); + const closeIcon = await frame.waitForSelector(".close-Icon"); + await closeIcon.click(); - await deleteNotebook(frame, uploadedNotebookNode); - const deletedNotebookNode = await getNotebookNode(frame, uploadNotebookName); - expect(deletedNotebookNode).toBeUndefined(); + await deleteNotebook(frame, uploadedNotebookNode); + const deletedNotebookNode = await getNotebookNode(frame, uploadNotebookName); + expect(deletedNotebookNode).toBeUndefined(); + } catch (error) { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + const testName = (expect as any).getState().currentTestName; + await page.screenshot({ path: `Test Failed ${testName}.jpg` }); + throw error; + } }); });