Added heading role to pane title (#203)

Co-authored-by: Daniel Si Pham <v-danpha@microsoft.com>
This commit is contained in:
DanielSPham 2020-09-16 17:17:23 -07:00 committed by GitHub
parent 34c41e1557
commit 40f4efab7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
21 changed files with 25 additions and 21 deletions

View File

@ -66,7 +66,9 @@ export class GitHubReposComponent extends React.Component<GitHubReposComponentPr
return ( return (
<> <>
<div className={"firstdivbg headerline"}>{header}</div> <div className={"firstdivbg headerline"} role="heading" aria-level={2}>
{header}
</div>
<div className={"paneMainContent"}>{content}</div> <div className={"paneMainContent"}>{content}</div>
{!this.props.showAuthorizeAccess && ( {!this.props.showAuthorizeAccess && (
<> <>

View File

@ -24,7 +24,7 @@
<script type="text/html" id="add-collection-inputs"> <script type="text/html" id="add-collection-inputs">
<!-- Add collection header - Start --> <!-- Add collection header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span id="containerTitle" data-bind="text: title"></span> <span id="containerTitle" role="heading" aria-level="2" data-bind="text: title" ></span>
<div class="closeImg" id="closeBtnAddCollection" role="button" aria-label="Add collection close pane" <div class="closeImg" id="closeBtnAddCollection" role="button" aria-label="Add collection close pane"
data-bind="click: cancel, event: { keypress: onCloseKeyPress }" tabindex="0"> data-bind="click: cancel, event: { keypress: onCloseKeyPress }" tabindex="0">
<img src="../../../images/close-black.svg" title="Close" alt="Close" /> <img src="../../../images/close-black.svg" title="Close" alt="Close" />

View File

@ -24,7 +24,7 @@
<script type="text/html" id="add-database-inputs"> <script type="text/html" id="add-database-inputs">
<!-- Add database header - Start --> <!-- Add database header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span id="databaseTitle" data-bind="text: title"></span> <span id="databaseTitle" role="heading" aria-level="2" data-bind="text: title"></span>
<div class="closeImg" role="button" aria-label="Close pane" <div class="closeImg" role="button" aria-label="Close pane"
data-bind="click: cancel, event: { keypress: onCloseKeyPress }" tabindex="0"> data-bind="click: cancel, event: { keypress: onCloseKeyPress }" tabindex="0">
<img src="../../../images/close-black.svg" title="Close" alt="Close" /> <img src="../../../images/close-black.svg" title="Close" alt="Close" />

View File

@ -6,7 +6,7 @@
<div class="paneContentContainer"> <div class="paneContentContainer">
<!-- Save Query header - Start --> <!-- Save Query header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -17,7 +17,7 @@
> >
<!-- Add Cassandra collection header - Start --> <!-- Add Cassandra collection header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -15,7 +15,7 @@
> >
<!-- Delete Collection Confirmation header - Start --> <!-- Delete Collection Confirmation header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -15,7 +15,7 @@
> >
<!-- Delete Database Confirmation header - Start --> <!-- Delete Database Confirmation header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -11,7 +11,7 @@
<form class="paneContentContainer" data-bind="submit: execute"> <form class="paneContentContainer" data-bind="submit: execute">
<!-- Input params header - Start --> <!-- Input params header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -70,7 +70,9 @@ export class GenericRightPaneComponent extends React.Component<GenericRightPaneP
private renderPanelHeader = (): JSX.Element => { private renderPanelHeader = (): JSX.Element => {
return ( return (
<div className="firstdivbg headerline"> <div className="firstdivbg headerline">
<span id="databaseTitle">{this.props.title}</span> <span id="databaseTitle" role="heading" aria-level={2}>
{this.props.title}
</span>
<IconButton <IconButton
ariaLabel="Close pane" ariaLabel="Close pane"
title="Close pane" title="Close pane"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- New Vertex header - Start --> <!-- New Vertex header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span>New Vertex</span> <span role="heading" aria-level="2">New Vertex</span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Graph Styling header - Start --> <!-- Graph Styling header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span>Graph Styling</span> <span role="heading" aria-level="2">Graph Styling</span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Load Query header - Start --> <!-- Load Query header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -11,7 +11,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Renew ad-hoc access header - Start --> <!-- Renew ad-hoc access header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Save Query header - Start --> <!-- Save Query header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel"> <div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel">
<img src="../../../images/close-black.svg" title="Close" alt="Close" /> <img src="../../../images/close-black.svg" title="Close" alt="Close" />
</div> </div>

View File

@ -12,7 +12,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Settings Confirmation header - Start --> <!-- Settings Confirmation header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<div class="paneContentContainer"> <div class="paneContentContainer">
<!-- Setup notebooks header - Start --> <!-- Setup notebooks header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- String Input header - Start --> <!-- String Input header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel"></div> <div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel"></div>
</div> </div>
<!-- String Input header - End --> <!-- String Input header - End -->

View File

@ -5,7 +5,7 @@
<div class="contextual-pane-in"> <div class="contextual-pane-in">
<!-- Switch Directory header - Start --> <!-- Switch Directory header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: close"> <div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: close">
<img src="../../../images/close-black.svg" title="Close" alt="Close" /> <img src="../../../images/close-black.svg" title="Close" alt="Close" />
</div> </div>

View File

@ -19,7 +19,7 @@
> >
<!-- Edit table entity header - Start --> <!-- Edit table entity header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"

View File

@ -6,7 +6,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Upload File header - Start --> <!-- Upload File header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel"> <div class="closeImg" role="button" aria-label="Close pane" tabindex="0" data-bind="click: cancel">
<img src="../../../images/close-black.svg" title="Close" alt="Close" /> <img src="../../../images/close-black.svg" title="Close" alt="Close" />
</div> </div>

View File

@ -11,7 +11,7 @@
<form class="paneContentContainer" data-bind="submit: submit"> <form class="paneContentContainer" data-bind="submit: submit">
<!-- Upload items header - Start --> <!-- Upload items header - Start -->
<div class="firstdivbg headerline"> <div class="firstdivbg headerline">
<span data-bind="text: title"></span> <span role="heading" aria-level="2" data-bind="text: title"></span>
<div <div
class="closeImg" class="closeImg"
role="button" role="button"