From 420f67698662216b461f2016db575a701f6fb756 Mon Sep 17 00:00:00 2001 From: Sampath Date: Mon, 13 Mar 2023 13:39:25 +0530 Subject: [PATCH] Revert "sev2 accessibilitydefects in data explorer" This reverts commit b84d5b572c6f127cd17033995c919867285d897e. --- images/imgarrowlefticon.svg | 2 +- src/Common/TableEntity.tsx | 7 +- .../ThroughputInput/ThroughputInput.tsx | 2 - .../ThroughputInput.test.tsx.snap | 81 ++-- .../Controls/TreeComponent/TreeComponent.tsx | 4 +- .../__snapshots__/TreeComponent.test.tsx.snap | 405 +++++++++--------- .../GraphVizComponent.tsx | 2 - .../MiddlePaneComponent.tsx | 7 +- .../NotificationConsoleComponent.tsx | 4 +- ...NotificationConsoleComponent.test.tsx.snap | 4 + src/Explorer/Panes/AddCollectionPanel.tsx | 12 +- .../AddCollectionPanel.test.tsx.snap | 143 +++---- src/Explorer/SplashScreen/SplashScreen.tsx | 6 +- 13 files changed, 318 insertions(+), 361 deletions(-) diff --git a/images/imgarrowlefticon.svg b/images/imgarrowlefticon.svg index 716024607..cd886d754 100644 --- a/images/imgarrowlefticon.svg +++ b/images/imgarrowlefticon.svg @@ -1,5 +1,5 @@ - + \ No newline at end of file diff --git a/src/Common/TableEntity.tsx b/src/Common/TableEntity.tsx index b3711fcbc..54c27adf5 100644 --- a/src/Common/TableEntity.tsx +++ b/src/Common/TableEntity.tsx @@ -7,7 +7,7 @@ import { IStackTokens, Stack, TextField, - TooltipHost + TooltipHost, } from "@fluentui/react"; import React, { FunctionComponent } from "react"; import DeleteIcon from "../../images/delete.svg"; @@ -136,20 +136,17 @@ export const TableEntity: FunctionComponent = ({ onEntityTimeValueChange={onEntityTimeValueChange} /> {!isEntityValueDisable && ( - -
editEntity -
- )} {isDeleteOptionVisible && userContext.apiType !== "Cassandra" && ( diff --git a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx index 8b73d9c36..d86b0414f 100644 --- a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx +++ b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx @@ -185,7 +185,6 @@ export const ThroughputInput: FunctionComponent = ({ -
= ({ -
{isAutoscaleSelected && ( diff --git a/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap b/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap index 73c39c2d1..009eab607 100644 --- a/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap +++ b/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap @@ -347,14 +347,12 @@ exports[`ThroughputInput Pane should render Default properly 1`] = ` ariaLabel="Set the throughput — Request Units per second (RU/s) — required for the workload. A read of a 1 KB document uses 1 RU. Select manual if you plan to scale RU/s yourself. Select autoscale to allow the system to scale RU/s based on usage." className="panelInfoIcon" iconName="Info" - role="tooltip" tabIndex={0} >  @@ -656,45 +654,44 @@ exports[`ThroughputInput Pane should render Default properly 1`] = `
-
+
+ Autoscale + + +
 diff --git a/src/Explorer/Controls/TreeComponent/TreeComponent.tsx b/src/Explorer/Controls/TreeComponent/TreeComponent.tsx index cd9bf8aa6..83b00b362 100644 --- a/src/Explorer/Controls/TreeComponent/TreeComponent.tsx +++ b/src/Explorer/Controls/TreeComponent/TreeComponent.tsx @@ -10,7 +10,7 @@ import { IButtonStyles, IconButton, IContextualMenuItemProps, - IContextualMenuProps + IContextualMenuProps, } from "@fluentui/react"; import * as React from "react"; import AnimateHeight from "react-animate-height"; @@ -195,7 +195,7 @@ export class TreeNodeComponent extends React.Component {node.children && ( -
+
{TreeNodeComponent.getSortedChildren(node).map((childNode: TreeNode) => ( -
-
+ label branch is collapsed + - label branch is collapsed - - label - -
+ label +
-
-
+ label branch is expanded + - label branch is expanded +
+ - - label - -
- -
-
-
+ label branch is expanded + - label branch is expanded - - label - -
+ label +
@@ -374,71 +365,69 @@ exports[`TreeNodeComponent renders sorted children, expanded, leaves and parents onKeyPress={[Function]} role="treeitem" > -
-
+ label branch is expanded + - label branch is expanded +
+ - - label - -
- -
-
-
+ label branch is expanded + - label branch is expanded - - label - -
+ label +
{ {/* svg load more icon inlined as-is here: remove the style="fill:#374649;" so we can override it */} {
Graph - +
diff --git a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx index 4f8c0b1b3..c7a2cf108 100644 --- a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx +++ b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx @@ -147,10 +147,12 @@ export class NotificationConsoleComponent extends React.Component<
{ @@ -109,7 +108,6 @@ export class AddCollectionPanel extends React.Component -
Use existing -
{this.state.createNewDatabase && ( @@ -412,7 +405,6 @@ export class AddCollectionPanel extends React.Component @@ -810,7 +802,6 @@ export class AddCollectionPanel extends React.Component -
Off -
{!this.isSynapseLinkEnabled() && ( diff --git a/src/Explorer/Panes/__snapshots__/AddCollectionPanel.test.tsx.snap b/src/Explorer/Panes/__snapshots__/AddCollectionPanel.test.tsx.snap index 0601343f8..7adf8316f 100644 --- a/src/Explorer/Panes/__snapshots__/AddCollectionPanel.test.tsx.snap +++ b/src/Explorer/Panes/__snapshots__/AddCollectionPanel.test.tsx.snap @@ -42,43 +42,39 @@ exports[`AddCollectionPanel should render Default properly 1`] = ` horizontal={true} verticalAlign="center" > -
+ - - - Create new - - - - Use existing - -
+ Create new +
+ + + Use existing + @@ -347,46 +342,42 @@ exports[`AddCollectionPanel should render Default properly 1`] = ` horizontal={true} verticalAlign="center" > -
+ - - - On - - - - Off - -
+ On +
+ + + Off + {
-
+
{userContext.apiType === "Postgres" ? "Welcome to Azure Cosmos DB for PostgreSQL" : "Welcome to Azure Cosmos DB"}