Move selectedNode to zustand (#903)

2026-01-01 15:22:08 +00:00 · 2021-06-24 11:56:33 -07:00
parent a7239c7579
commit 4d2a6999d4
40 changed files with 481 additions and 955 deletions
--- a/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.test.tsx
+++ b/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.test.tsx
@@ -1,6 +1,6 @@
 jest.mock("../../Common/dataAccess/deleteDatabase");
 jest.mock("../../Shared/Telemetry/TelemetryProcessor");
-import { mount, ReactWrapper, shallow } from "enzyme";
+import { mount, shallow } from "enzyme";
 import * as ko from "knockout";
 import React from "react";
 import { deleteDatabase } from "../../Common/dataAccess/deleteDatabase";
@@ -13,121 +13,102 @@ import { updateUserContext } from "../../UserContext";
 import Explorer from "../Explorer";
 import { TabsManager } from "../Tabs/TabsManager";
 import { useDatabases } from "../useDatabases";
+import { useSelectedNode } from "../useSelectedNode";
 import { DeleteDatabaseConfirmationPanel } from "./DeleteDatabaseConfirmationPanel";

 describe("Delete Database Confirmation Pane", () => {
-  describe("shouldRecordFeedback()", () => {
-    it("should return true if last non empty database or is last database that has shared throughput, else false", () => {
-      const fakeExplorer = {} as Explorer;
-      fakeExplorer.refreshAllDatabases = () => undefined;
-      fakeExplorer.isSelectedDatabaseShared = () => false;
+  const selectedDatabaseId = "testDatabase";
+  let fakeExplorer: Explorer;
+  let database: Database;

-      const database = {} as Database;
-      database.collections = ko.observableArray<Collection>([{ id: ko.observable("testCollection") } as Collection]);
-      database.id = ko.observable<string>("testDatabase");
-
-      const props = {
-        explorer: fakeExplorer,
-        closePanel: (): void => undefined,
-        openNotificationConsole: (): void => undefined,
-        selectedDatabase: database,
-      };
-
-      const wrapper = shallow(<DeleteDatabaseConfirmationPanel {...props} />);
-      expect(wrapper.exists(".deleteDatabaseFeedback")).toBe(false);
-
-      useDatabases.getState().addDatabases([database]);
-
-      wrapper.setProps(props);
-      expect(wrapper.exists(".deleteDatabaseFeedback")).toBe(true);
-      useDatabases.getState().clearDatabases();
+  beforeAll(() => {
+    updateUserContext({
+      databaseAccount: {
+        name: "testDatabaseAccountName",
+        properties: {
+          cassandraEndpoint: "testEndpoint",
+        },
+        id: "testDatabaseAccountId",
+      } as DatabaseAccount,
+      apiType: "SQL",
    });
+    (deleteDatabase as jest.Mock).mockResolvedValue(undefined);
+    (TelemetryProcessor.trace as jest.Mock).mockReturnValue(undefined);
  });

-  describe("submit()", () => {
-    const selectedDatabaseId = "testDatabse";
-    const database = { id: ko.observable("testDatabase") } as Database;
+  beforeEach(() => {
+    fakeExplorer = {} as Explorer;
+    fakeExplorer.refreshAllDatabases = () => undefined;
+    fakeExplorer.tabsManager = new TabsManager();
+
+    database = {} as Database;
    database.collections = ko.observableArray<Collection>([{ id: ko.observable("testCollection") } as Collection]);
    database.id = ko.observable<string>(selectedDatabaseId);
-    const fakeExplorer = {} as Explorer;
-    fakeExplorer.refreshAllDatabases = () => undefined;
-    fakeExplorer.isSelectedDatabaseShared = () => false;
-    fakeExplorer.tabsManager = new TabsManager();
-    fakeExplorer.selectedNode = ko.observable();
+    database.nodeKind = "Database";

-    let wrapper: ReactWrapper;
-    beforeAll(() => {
-      updateUserContext({
-        databaseAccount: {
-          name: "testDatabaseAccountName",
-          properties: {
-            cassandraEndpoint: "testEndpoint",
-          },
-          id: "testDatabaseAccountId",
-        } as DatabaseAccount,
-        apiType: "SQL",
-      });
-      (deleteDatabase as jest.Mock).mockResolvedValue(undefined);
-      (TelemetryProcessor.trace as jest.Mock).mockReturnValue(undefined);
-      useDatabases.getState().addDatabases([database]);
-    });
-
-    beforeEach(() => {
-      const props = {
-        explorer: fakeExplorer,
-        closePanel: (): void => undefined,
-        openNotificationConsole: (): void => undefined,
-        selectedDatabase: database,
-      };
-
-      wrapper = mount(<DeleteDatabaseConfirmationPanel {...props} />);
-    });
-
-    afterAll(() => useDatabases.getState().clearDatabases());
-
-    it("Should call delete database", () => {
-      expect(wrapper).toMatchSnapshot();
-      expect(wrapper.exists("#confirmDatabaseId")).toBe(true);
-
-      wrapper
-        .find("#confirmDatabaseId")
-        .hostNodes()
-        .simulate("change", { target: { value: selectedDatabaseId } });
-      expect(wrapper.exists("button")).toBe(true);
-      wrapper.find("button").hostNodes().simulate("submit");
-      expect(deleteDatabase).toHaveBeenCalledWith(selectedDatabaseId);
-      wrapper.unmount();
-    });
-
-    it("should record feedback", async () => {
-      expect(wrapper.exists("#confirmDatabaseId")).toBe(true);
-      wrapper
-        .find("#confirmDatabaseId")
-        .hostNodes()
-        .simulate("change", { target: { value: selectedDatabaseId } });
-
-      expect(wrapper.exists("#deleteDatabaseFeedbackInput")).toBe(true);
-      const feedbackText = "Test delete Database feedback text";
-      wrapper
-        .find("#deleteDatabaseFeedbackInput")
-        .hostNodes()
-        .simulate("change", { target: { value: feedbackText } });
-
-      expect(wrapper.exists("#sidePanelOkButton")).toBe(true);
-      wrapper.find("#sidePanelOkButton").hostNodes().simulate("submit");
-      expect(deleteDatabase).toHaveBeenCalledWith(selectedDatabaseId);
-
-      const deleteFeedback = new DeleteFeedback(
-        "testDatabaseAccountId",
-        "testDatabaseAccountName",
-        ApiKind.SQL,
-        feedbackText
-      );
-      await new Promise((resolve) => setTimeout(resolve, 0));
-      expect(TelemetryProcessor.trace).toHaveBeenCalledWith(Action.DeleteDatabase, ActionModifiers.Mark, {
-        message: JSON.stringify(deleteFeedback, Object.getOwnPropertyNames(deleteFeedback)),
-      });
-      wrapper.unmount();
+    useDatabases.getState().addDatabases([database]);
+    useSelectedNode.getState().setSelectedNode(database);
+  });
+
+  afterEach(() => {
+    useDatabases.getState().clearDatabases();
+    useSelectedNode.getState().setSelectedNode(undefined);
+  });
+
+  it("shouldRecordFeedback() should return true if last non empty database or is last database that has shared throughput", () => {
+    const wrapper = shallow(<DeleteDatabaseConfirmationPanel explorer={fakeExplorer} />);
+    expect(wrapper.exists(".deleteDatabaseFeedback")).toBe(true);
+
+    useDatabases.getState().addDatabases([database]);
+    wrapper.setProps({ explorer: fakeExplorer });
+    expect(wrapper.exists(".deleteDatabaseFeedback")).toBe(false);
+    useDatabases.getState().clearDatabases();
+  });
+
+  it("Should call delete database", () => {
+    const wrapper = mount(<DeleteDatabaseConfirmationPanel explorer={fakeExplorer} />);
+    expect(wrapper).toMatchSnapshot();
+    expect(wrapper.exists("#confirmDatabaseId")).toBe(true);
+
+    wrapper
+      .find("#confirmDatabaseId")
+      .hostNodes()
+      .simulate("change", { target: { value: selectedDatabaseId } });
+    expect(wrapper.exists("button")).toBe(true);
+    wrapper.find("button").hostNodes().simulate("submit");
+    expect(deleteDatabase).toHaveBeenCalledWith(selectedDatabaseId);
+    wrapper.unmount();
+  });
+
+  it("should record feedback", async () => {
+    const wrapper = mount(<DeleteDatabaseConfirmationPanel explorer={fakeExplorer} />);
+    expect(wrapper.exists("#confirmDatabaseId")).toBe(true);
+    wrapper
+      .find("#confirmDatabaseId")
+      .hostNodes()
+      .simulate("change", { target: { value: selectedDatabaseId } });
+
+    expect(wrapper.exists("#deleteDatabaseFeedbackInput")).toBe(true);
+    const feedbackText = "Test delete Database feedback text";
+    wrapper
+      .find("#deleteDatabaseFeedbackInput")
+      .hostNodes()
+      .simulate("change", { target: { value: feedbackText } });
+
+    expect(wrapper.exists("#sidePanelOkButton")).toBe(true);
+    wrapper.find("#sidePanelOkButton").hostNodes().simulate("submit");
+    expect(deleteDatabase).toHaveBeenCalledWith(selectedDatabaseId);
+
+    const deleteFeedback = new DeleteFeedback(
+      "testDatabaseAccountId",
+      "testDatabaseAccountName",
+      ApiKind.SQL,
+      feedbackText
+    );
+    await new Promise((resolve) => setTimeout(resolve, 0));
+    expect(TelemetryProcessor.trace).toHaveBeenCalledWith(Action.DeleteDatabase, ActionModifiers.Mark, {
+      message: JSON.stringify(deleteFeedback, Object.getOwnPropertyNames(deleteFeedback)),
    });
+    wrapper.unmount();
  });
 });