More gallery updates (#418)

* More gallery updates

* Add PublishContent icon

* Address feedback

src/Explorer/Panes/PublishNotebookPaneAdapter.tsx

@@ -14,6 +14,7 @@ import { handleError, getErrorMessage, getErrorStack } from "../../Common/ErrorH
 import { GalleryTab } from "../Controls/NotebookGallery/GalleryViewerComponent";
 import { traceFailure, traceStart, traceSuccess } from "../../Shared/Telemetry/TelemetryProcessor";
 import { Action } from "../../Shared/Telemetry/TelemetryConstants";
+import { FileSystemUtil } from "../Notebook/FileSystemUtil";
 
 export class PublishNotebookPaneAdapter implements ReactAdapter {
   parameters: ko.Observable<number>;
@@ -203,7 +204,7 @@ export class PublishNotebookPaneAdapter implements ReactAdapter {
       );
 
       const errorMessage = getErrorMessage(error);
-      this.formError = `Failed to publish ${this.name} to gallery`;
+      this.formError = `Failed to publish ${FileSystemUtil.stripExtension(this.name, "ipynb")} to gallery`;
       this.formErrorDetail = `${errorMessage}`;
       handleError(errorMessage, "PublishNotebookPaneAdapter/submit", this.formError);
       return;

src/Explorer/Tabs/NotebookV2Tab.ts

@@ -18,7 +18,7 @@ import ClearAllOutputsIcon from "../../../images/notebook/Notebook-clear-all-out
 import InterruptKernelIcon from "../../../images/notebook/Notebook-stop.svg";
 import KillKernelIcon from "../../../images/notebook/Notebook-stop.svg";
 import * as TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
-import { Action, ActionModifiers } from "../../Shared/Telemetry/TelemetryConstants";
+import { Action, ActionModifiers, Source } from "../../Shared/Telemetry/TelemetryConstants";
 import { Areas, ArmApiVersions } from "../../Common/Constants";
 import { CommandBarComponentButtonFactory } from "../Menus/CommandBar/CommandBarComponentButtonFactory";
 import { ConsoleDataType } from "../Menus/NotificationConsole/NotificationConsoleComponent";
@@ -485,6 +485,10 @@ export default class NotebookTabV2 extends TabsBase {
   }
 
   private publishToGallery = async () => {
+    TelemetryProcessor.trace(Action.NotebooksGalleryClickPublishToGallery, ActionModifiers.Mark, {
+      source: Source.CommandBarMenu,
+    });
+
     const notebookContent = this.notebookComponentAdapter.getContent();
     await this.container.publishNotebook(
       notebookContent.name,

src/Explorer/Tree/ResourceTreeAdapter.tsx

@@ -15,12 +15,13 @@ import NotebookIcon from "../../../images/notebook/Notebook-resource.svg";
 import RefreshIcon from "../../../images/refresh-cosmos.svg";
 import NewNotebookIcon from "../../../images/notebook/Notebook-new.svg";
 import FileIcon from "../../../images/notebook/file-cosmos.svg";
+import PublishIcon from "../../../images/notebook/publish_content.svg";
 import { ArrayHashMap } from "../../Common/ArrayHashMap";
 import { NotebookUtil } from "../Notebook/NotebookUtil";
 import _ from "underscore";
 import { IPinnedRepo } from "../../Juno/JunoClient";
 import * as TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
-import { Action, ActionModifiers } from "../../Shared/Telemetry/TelemetryConstants";
+import { Action, ActionModifiers, Source } from "../../Shared/Telemetry/TelemetryConstants";
 import { Areas } from "../../Common/Constants";
 import * as GitHubUtils from "../../Utils/GitHubUtils";
 import GalleryIcon from "../../../images/GalleryIcon.svg";
@@ -716,11 +717,15 @@ export class ResourceTreeAdapter implements ReactAdapter {
       },
     ];
 
-    if (item.type === NotebookContentItemType.Notebook) {
+    if (this.container.isGalleryPublishEnabled() && item.type === NotebookContentItemType.Notebook) {
       items.push({
         label: "Publish to gallery",
-        iconSrc: undefined, // TODO
+        iconSrc: PublishIcon,
         onClick: async () => {
+          TelemetryProcessor.trace(Action.NotebooksGalleryClickPublishToGallery, ActionModifiers.Mark, {
+            source: Source.ResourceTreeMenu,
+          });
+
           const content = await this.container.readFile(item);
           if (content) {
             await this.container.publishNotebook(item.name, content);

src/Shared/Telemetry/TelemetryConstants.ts

@@ -109,6 +109,7 @@ export enum Action {
   NotebooksGalleryViewPublicGallery,
   NotebooksGalleryViewFavorites,
   NotebooksGalleryViewPublishedNotebooks,
+  NotebooksGalleryClickPublishToGallery,
 }
 
 export const ActionModifiers = {
@@ -151,3 +152,8 @@ export enum SourceBlade {
   ScriptExplorer,
   Keys,
 }
+
+export enum Source {
+  ResourceTreeMenu = "ResourceTreeMenu",
+  CommandBarMenu = "CommandBarMenu",
+}