Remove OpenActionsStubs (#106)

src/Explorer/Tabs/ConflictsTab.ts

@@ -22,7 +22,7 @@ import { QueryIterator, ItemDefinition, Resource, ConflictDefinition } from "@az
 import { MinimalQueryIterator } from "../../Common/IteratorUtilities";
 import Explorer from "../Explorer";
 
-export default class ConflictsTab extends TabsBase implements ViewModels.ConflictsTab {
+export default class ConflictsTab extends TabsBase {
   public selectedConflictId: ko.Observable<ViewModels.ConflictId>;
   public selectedConflictContent: ViewModels.Editable<string>;
   public selectedConflictCurrent: ViewModels.Editable<string>;

src/Explorer/Tabs/DatabaseSettingsTab.ts

@@ -48,8 +48,7 @@ const throughputApplyLongDelayMessage = (isAutoscale: boolean, throughput: numbe
   This operation will take 1-3 business days to complete. View the latest status in Notifications.<br />
   Database: ${databaseName}, ${currentThroughput(isAutoscale, throughput)}`;
 
-export default class DatabaseSettingsTab extends TabsBase
-  implements ViewModels.DatabaseSettingsTab, ViewModels.WaitsForTemplate {
+export default class DatabaseSettingsTab extends TabsBase implements ViewModels.WaitsForTemplate {
   // editables
   public isAutoPilotSelected: ViewModels.Editable<boolean>;
   public throughput: ViewModels.Editable<number>;

src/Explorer/Tabs/QueryTab.test.ts

@@ -2,21 +2,22 @@ import * as ko from "knockout";
 import * as Constants from "../../Common/Constants";
 import * as ViewModels from "../../Contracts/ViewModels";
 import Explorer from "../Explorer";
-import { CollectionStub, DatabaseStub } from "../../Explorer/OpenActionsStubs";
 import QueryTab from "./QueryTab";
+import { View } from "@nteract/data-explorer/lib/utilities/types";
+import { PartitionKey } from "../../Contracts/DataModels";
 
 describe("Query Tab", () => {
   function getNewQueryTabForContainer(container: Explorer): ViewModels.QueryTab {
-    const database: ViewModels.Database = new DatabaseStub({
+    const database = {
       container: container,
       id: ko.observable<string>("test"),
       isDatabaseShared: () => false
-    });
-    const collection: ViewModels.Collection = new CollectionStub({
+    } as ViewModels.Database;
+    const collection = {
       container: container,
       databaseId: "test",
       id: ko.observable<string>("test")
-    });
+    } as ViewModels.Collection;
 
     return new QueryTab({
       tabKind: ViewModels.CollectionTabKind.Query,
@@ -33,19 +34,12 @@ describe("Query Tab", () => {
   }
 
   describe("shouldSetSystemPartitionKeyContainerPartitionKeyValueUndefined", () => {
-    const collection: ViewModels.Collection = new CollectionStub({
-      id: "withoutsystempk",
+    const collection = {
+      id: ko.observable<string>("withoutsystempk"),
       partitionKey: {
         systemKey: true
       }
-    });
-
-    const collectionSystemPK: ViewModels.Collection = new CollectionStub({
-      id: "withsystempk",
-      partitionKey: {
-        systemKey: true
-      }
-    });
+    } as ViewModels.Collection;
 
     it("no container with system pk, should not set partition key option", () => {
       const iteratorOptions = QueryTab.getIteratorOptions(collection);

src/Explorer/Tabs/SettingsTab.ts

@@ -125,7 +125,7 @@ enum ChangeFeedPolicyToggledState {
   On = "On"
 }
 
-export default class SettingsTab extends TabsBase implements ViewModels.SettingsTab, ViewModels.WaitsForTemplate {
+export default class SettingsTab extends TabsBase implements ViewModels.WaitsForTemplate {
   public GEOGRAPHY: string = "Geography";
   public GEOMETRY: string = "Geometry";
 

src/Explorer/Tabs/StoredProcedureTab.ts

@@ -9,6 +9,7 @@ import editable from "../../Common/EditableUtility";
 import ScriptTabBase from "./ScriptTabBase";
 import TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
 import ExecuteQueryIcon from "../../../images/ExecuteQuery.svg";
+import StoredProcedure from "../Tree/StoredProcedure";
 
 enum ToggleState {
   Result = "result",
@@ -17,7 +18,7 @@ enum ToggleState {
 
 export default class StoredProcedureTab extends ScriptTabBase implements ViewModels.StoredProcedureTab {
   public collection: ViewModels.Collection;
-  public node: ViewModels.StoredProcedure;
+  public node: StoredProcedure;
   public executeResultsEditorId: string;
   public executeLogsEditorId: string;
   public toggleState: ko.Observable<ToggleState>;

src/Explorer/Tabs/TabsManager.test.ts

@@ -1,6 +1,5 @@
 import * as ko from "knockout";
 import * as ViewModels from "../../Contracts/ViewModels";
-import { CollectionStub, DatabaseStub } from "../../Explorer/OpenActionsStubs";
 import { DataAccessUtility } from "../../Platform/Portal/DataAccessUtility";
 import { TabsManager } from "./TabsManager";
 import DocumentClientUtilityBase from "../../Common/DocumentClientUtilityBase";
@@ -28,19 +27,19 @@ describe("Tabs manager tests", () => {
       properties: undefined
     });
 
-    database = new DatabaseStub({
+    database = {
       container: explorer,
       id: ko.observable<string>("test"),
       isDatabaseShared: () => false
-    });
+    } as ViewModels.Database;
     database.isDatabaseExpanded = ko.observable<boolean>(true);
     database.selectedSubnodeKind = ko.observable<ViewModels.CollectionTabKind>();
 
-    collection = new CollectionStub({
+    collection = {
       container: explorer,
       databaseId: "test",
       id: ko.observable<string>("test")
-    });
+    } as ViewModels.Collection;
     collection.getDatabase = (): ViewModels.Database => database;
     collection.isCollectionExpanded = ko.observable<boolean>(true);
     collection.selectedSubnodeKind = ko.observable<ViewModels.CollectionTabKind>();

src/Explorer/Tabs/TriggerTab.ts

@@ -6,10 +6,11 @@ import { Action } from "../../Shared/Telemetry/TelemetryConstants";
 import ScriptTabBase from "./ScriptTabBase";
 import editable from "../../Common/EditableUtility";
 import TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
+import Trigger from "../Tree/Trigger";
 
 export default class TriggerTab extends ScriptTabBase implements ViewModels.TriggerTab {
   public collection: ViewModels.Collection;
-  public node: ViewModels.Trigger;
+  public node: Trigger;
   public triggerType: ViewModels.Editable<string>;
   public triggerOperation: ViewModels.Editable<string>;
 

src/Explorer/Tabs/UserDefinedFunctionTab.ts

@@ -5,10 +5,11 @@ import * as ViewModels from "../../Contracts/ViewModels";
 import { Action } from "../../Shared/Telemetry/TelemetryConstants";
 import ScriptTabBase from "./ScriptTabBase";
 import TelemetryProcessor from "../../Shared/Telemetry/TelemetryProcessor";
+import UserDefinedFunction from "../Tree/UserDefinedFunction";
 
 export default class UserDefinedFunctionTab extends ScriptTabBase implements ViewModels.UserDefinedFunctionTab {
   public collection: ViewModels.Collection;
-  public node: ViewModels.UserDefinedFunction;
+  public node: UserDefinedFunction;
   constructor(options: ViewModels.ScriptTabOption) {
     super(options);
     this.ariaLabel("User Defined Function Body");