From 5a5bf34d4d7b32416808ba5503517f420507ac33 Mon Sep 17 00:00:00 2001 From: sindhuba <122321535+sindhuba@users.noreply.github.com> Date: Fri, 19 Jan 2024 07:08:11 -0800 Subject: [PATCH] Update logic for NPS survey for existing accounts > 90 days (#1725) * Update logic for NPS survey for existing accounts > 90 days * Remove lint error * Address comments * Fix error in code --- src/Explorer/Explorer.tsx | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/Explorer/Explorer.tsx b/src/Explorer/Explorer.tsx index 3c34d77db..e58602cfd 100644 --- a/src/Explorer/Explorer.tsx +++ b/src/Explorer/Explorer.tsx @@ -277,10 +277,6 @@ export default class Explorer { const NINETY_DAYS_IN_MS = 7776000000; const ONE_DAY_IN_MS = 86400000; const THREE_DAYS_IN_MS = 259200000; - const isAccountNewerThanNinetyDays = isAccountNewerThanThresholdInMs( - userContext.databaseAccount?.systemData?.createdAt || "", - NINETY_DAYS_IN_MS, - ); const lastSubmitted: string = localStorage.getItem("lastSubmitted"); if (lastSubmitted !== null) { @@ -302,17 +298,11 @@ export default class Explorer { this.sendNPSMessage(); } } else { - // An existing account is older than 3 days but less than 90 days old. For existing account show to 100% of users in Data Explorer. + // Show survey when an existing account is older than 3 days if ( - !isAccountNewerThanThresholdInMs(userContext.databaseAccount?.systemData?.createdAt || "", THREE_DAYS_IN_MS) && - isAccountNewerThanNinetyDays + !isAccountNewerThanThresholdInMs(userContext.databaseAccount?.systemData?.createdAt || "", THREE_DAYS_IN_MS) ) { this.sendNPSMessage(); - } else { - // An existing account is greater than 90 days. For existing account show to random 33% of users in Data Explorer. - if (this.getRandomInt(100) < 33) { - this.sendNPSMessage(); - } } } }