Removing TODO comments

This commit is contained in:
Balaji Sridharan 2021-02-17 10:43:23 -08:00
parent 67ebce444f
commit 5b0a98dce7
2 changed files with 0 additions and 6 deletions

View File

@ -25,7 +25,6 @@ export const getPath = (subscriptionId: string, resourceGroup: string, name: str
}; };
export const updateDedicatedGatewayResource = async (sku: string, instances: number): Promise<void> => { export const updateDedicatedGatewayResource = async (sku: string, instances: number): Promise<void> => {
// TODO: write RP call to update dedicated gateway provisioning
const path = getPath(userContext.subscriptionId, userContext.resourceGroup, userContext.databaseAccount.name); const path = getPath(userContext.subscriptionId, userContext.resourceGroup, userContext.databaseAccount.name);
const body: UpdateDedicatedGatewayRequestParameters = { const body: UpdateDedicatedGatewayRequestParameters = {
properties: { properties: {
@ -62,7 +61,6 @@ export const getCurrentProvisioningState = async (): Promise<DedicatedGatewayRes
}; };
export const refreshDedicatedGatewayProvisioning = async (): Promise<RefreshResult> => { export const refreshDedicatedGatewayProvisioning = async (): Promise<RefreshResult> => {
// TODO: write RP call to check if dedicated gateway update has gone through
try { try {
const response = await getDedicatedGatewayResource(); const response = await getDedicatedGatewayResource();
if (response.properties.status === ResourceStatus.Running.toString()) { if (response.properties.status === ResourceStatus.Running.toString()) {

View File

@ -48,17 +48,14 @@ const skuDropDownItems: ChoiceItem[] = [
]; ];
const getSkus = async (): Promise<ChoiceItem[]> => { const getSkus = async (): Promise<ChoiceItem[]> => {
// TODO: get SKUs from getRegionSpecificSkus() RP call and return array of {label:..., key:...}.
return skuDropDownItems; return skuDropDownItems;
}; };
const getInstancesMin = async (): Promise<number> => { const getInstancesMin = async (): Promise<number> => {
// TODO: get SKUs from getRegionSpecificSkus() RP call and return array of {label:..., key:...}.
return 1; return 1;
}; };
const getInstancesMax = async (): Promise<number> => { const getInstancesMax = async (): Promise<number> => {
// TODO: get SKUs from getRegionSpecificSkus() RP call and return array of {label:..., key:...}.
return 5; return 5;
}; };
@ -120,7 +117,6 @@ export default class SqlX extends SelfServeBaseClass {
}; };
public initialize = async (): Promise<Map<string, SmartUiInput>> => { public initialize = async (): Promise<Map<string, SmartUiInput>> => {
// TODO: RP call to check if dedicated gateway has already been provisioned.
// Based on the RP call enableDedicatedGateway will be true if it has not yet been enabled and false if it has. // Based on the RP call enableDedicatedGateway will be true if it has not yet been enabled and false if it has.
const defaults = new Map<string, SmartUiInput>(); const defaults = new Map<string, SmartUiInput>();
const enableDedicatedGateway = false; const enableDedicatedGateway = false;