Bug fix: match monaco-editor version with @nteract/monaco-editor (#322)

Browse Source

Opening notebook (which contains code cell), then "Items"-> document editor is broken. Our JsonEditor component will hang at `monaco.editor.create()`.

Matching the `monaco-editor` version with `@nteract/monaco-editor` fixes it.

I looked into using one, but we cannot rely nteract, because it does not get loaded if notebook isn't enabled. Forcing nteract to use ours (if at all possible) isn't a good idea, since their code is tuned to their version.

For now, we'll have to keep the versions in sync.

...

This commit is contained in:

Laurent Nguyen

2020-11-19 15:33:23 +01:00

committed by GitHub

parent 85d2378d3a

commit 5c93c11bd9

2 changed files with 1819 additions and 1402 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

package-lock.json

Generated

+1816 -1399

File diff suppressed because it is too large Load Diff