random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-03-27 12:10:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix eslint issues for ContainerSampleGenerator aand its test case file

Browse Source
This commit is contained in:
vaidankarswapnil 2021-10-20 12:22:08 +05:30
parent 55837db65b
commit 646bbeb40f
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.eslintignore
View File

@ -40,8 +40,8 @@ src/Explorer/Controls/DiffEditor/DiffEditorComponent.ts
src/Explorer/Controls/Editor/EditorComponent.ts src/Explorer/Controls/Editor/EditorComponent.ts
src/Explorer/Controls/JsonEditor/JsonEditorComponent.ts src/Explorer/Controls/JsonEditor/JsonEditorComponent.ts
src/Explorer/DataSamples/ContainerSampleGenerator.test.ts # src/Explorer/DataSamples/ContainerSampleGenerator.test.ts
src/Explorer/DataSamples/ContainerSampleGenerator.ts # src/Explorer/DataSamples/ContainerSampleGenerator.ts
src/Explorer/DataSamples/DataSamplesUtil.test.ts src/Explorer/DataSamples/DataSamplesUtil.test.ts
src/Explorer/DataSamples/DataSamplesUtil.ts src/Explorer/DataSamples/DataSamplesUtil.ts
src/Explorer/Graph/GraphExplorerComponent/ArraysByKeyCache.test.ts src/Explorer/Graph/GraphExplorerComponent/ArraysByKeyCache.test.ts

3
src/Explorer/DataSamples/ContainerSampleGenerator.test.ts
View File

@ -1,3 +1,4 @@
/*eslint-disable @typescript-eslint/no-empty-function*/
jest.mock("../Graph/GraphExplorerComponent/GremlinClient"); jest.mock("../Graph/GraphExplorerComponent/GremlinClient");
jest.mock("../../Common/dataAccess/createCollection"); jest.mock("../../Common/dataAccess/createCollection");
jest.mock("../../Common/dataAccess/createDocument"); jest.mock("../../Common/dataAccess/createDocument");
@ -69,6 +70,7 @@ describe("ContainerSampleGenerator", () => {
expect(createDocument).toHaveBeenCalled(); expect(createDocument).toHaveBeenCalled();
}); });
// eslint-disable-next-line jest/expect-expect
it("should send gremlin queries for Graph API account", async () => { it("should send gremlin queries for Graph API account", async () => {
updateUserContext({ updateUserContext({
databaseAccount: { databaseAccount: {
@ -134,6 +136,7 @@ describe("ContainerSampleGenerator", () => {
}); });
// Rejects with error that contains experience // Rejects with error that contains experience
// eslint-disable-next-line jest/valid-expect
expect(ContainerSampleGenerator.createSampleGeneratorAsync(explorerStub)).rejects.toMatch(experience); expect(ContainerSampleGenerator.createSampleGeneratorAsync(explorerStub)).rejects.toMatch(experience);
}); });

6
src/Explorer/DataSamples/ContainerSampleGenerator.ts
View File

@ -10,6 +10,7 @@ import { GremlinClient } from "../Graph/GraphExplorerComponent/GremlinClient";
import { useDatabases } from "../useDatabases"; import { useDatabases } from "../useDatabases";
interface SampleDataFile extends DataModels.CreateCollectionParams { interface SampleDataFile extends DataModels.CreateCollectionParams {
//eslint-disable-next-line
data: any[]; data: any[];
} }
@ -23,6 +24,7 @@ export class ContainerSampleGenerator {
*/ */
public static async createSampleGeneratorAsync(container: Explorer): Promise<ContainerSampleGenerator> { public static async createSampleGeneratorAsync(container: Explorer): Promise<ContainerSampleGenerator> {
const generator = new ContainerSampleGenerator(container); const generator = new ContainerSampleGenerator(container);
//eslint-disable-next-line
let dataFileContent: any; let dataFileContent: any;
if (userContext.apiType === "Gremlin") { if (userContext.apiType === "Gremlin") {
dataFileContent = await import( dataFileContent = await import(
@ -72,7 +74,7 @@ export class ContainerSampleGenerator {
if (!collection) { if (!collection) {
throw new Error("No container to populate"); throw new Error("No container to populate");
} }
const promises: Q.Promise<any>[] = []; // const promises: Q.Promise<any>[] = [];
if (userContext.apiType === "Gremlin") { if (userContext.apiType === "Gremlin") {
// For Gremlin, all queries are executed sequentially, because some queries might be dependent on other queries // For Gremlin, all queries are executed sequentially, because some queries might be dependent on other queries
@ -113,7 +115,7 @@ export class ContainerSampleGenerator {
* public for unit testing * public for unit testing
* @param data * @param data
*/ */
public setData(data: SampleDataFile) { public setData(data: SampleDataFile): void {
this.sampleDataFile = data; this.sampleDataFile = data;
} }
} }