From 658e2ffe85aab2243d021be11b4f1c2e3e89ac92 Mon Sep 17 00:00:00 2001
From: Laurent Nguyen <laurent.nguyen@microsoft.com>
Date: Fri, 21 Jun 2024 13:12:50 +0200
Subject: [PATCH] Do not allow deselecting all columns

---
 src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx          | 5 +++++
 src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.tsx | 1 -
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
index f13622061..3d8cc2f9a 100644
--- a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
+++ b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
@@ -1753,6 +1753,11 @@ export const DocumentsTabComponent: React.FunctionComponent<IDocumentsTabCompone
   };
 
   const onColumnSelectionChange = (newSelectedColumnIds: string[]): void => {
+    // Do not allow to unselecting all columns
+    if (newSelectedColumnIds.length === 0) {
+      return;
+    }
+
     setSelectedColumnIds(newSelectedColumnIds);
   };
 
diff --git a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.tsx b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.tsx
index 6d8b743d7..c60736ecd 100644
--- a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.tsx
+++ b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTableComponent.tsx
@@ -329,7 +329,6 @@ export const DocumentsTableComponent: React.FC<IDocumentsTableComponentProps> =
   );
 
   const onCheckedValueChange = (_: MenuCheckedValueChangeEvent, data: MenuCheckedValueChangeData) => {
-    // TODO this is expensive
     // eslint-disable-next-line react/prop-types
     onColumnSelectionChange(data.checkedItems);
   };