From 69b8196cf07459b649af49e7348f5a10dc799eaf Mon Sep 17 00:00:00 2001
From: Zachary Foster <zfoster@users.noreply.github.com>
Date: Fri, 28 May 2021 08:12:33 -0400
Subject: [PATCH] Removes feature flag from passing masterKey to SDK (#843)

* Remove Feature flag from master key usage

* Adds flag to fallback

* format
---
 src/Common/CosmosClient.ts       | 2 +-
 src/hooks/useKnockoutExplorer.ts | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/Common/CosmosClient.ts b/src/Common/CosmosClient.ts
index 756c53a2e..14aa882fa 100644
--- a/src/Common/CosmosClient.ts
+++ b/src/Common/CosmosClient.ts
@@ -83,7 +83,7 @@ export function client(): Cosmos.CosmosClient {
   if (_client) return _client;
   const options: Cosmos.CosmosClientOptions = {
     endpoint: endpoint() || "https://cosmos.azure.com", // CosmosClient gets upset if we pass a bad URL. This should never actually get called
-    ...(!userContext.features.enableAadDataPlane && { key: userContext.masterKey }),
+    key: userContext.masterKey,
     tokenProvider,
     connectionPolicy: {
       enableEndpointDiscovery: false,
diff --git a/src/hooks/useKnockoutExplorer.ts b/src/hooks/useKnockoutExplorer.ts
index 43e7013a2..765974cad 100644
--- a/src/hooks/useKnockoutExplorer.ts
+++ b/src/hooks/useKnockoutExplorer.ts
@@ -106,7 +106,11 @@ async function configureHostedWithAAD(config: AAD, explorerParams: ExplorerParam
   try {
     keys = await listKeys(subscriptionId, resourceGroup, account.name);
   } catch (e) {
-    console.warn(e);
+    if (userContext.features.enableAadDataPlane) {
+      console.warn(e);
+    } else {
+      throw new Error(`List keys failed: ${e.message}`);
+    }
   }
   updateUserContext({
     subscriptionId,