random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-02-16 17:25:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bug 1242529: [Usable - Azure Cosmos DB - Input Parameters]: Aria-label is not descriptive enough for the 'Close(x)' button of 'Input Parameters' blade. (#1760)

Browse Source 
* screen reader name for the button has been changed to read out the name of the dialog box

* tests have been updated
This commit is contained in:
MokireddySampath 2024-03-06 12:56:07 +05:30 committed by GitHub
parent 0039adf1c2
commit 6e1c4fd037
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Explorer/Panes/PanelContainerComponent.tsx
View File

@ -58,7 +58,7 @@ export class PanelContainerComponent extends React.Component<PanelContainerProps
onDismiss={this.onDissmiss} onDismiss={this.onDissmiss}
isLightDismiss isLightDismiss
type={PanelType.custom} type={PanelType.custom}
closeButtonAriaLabel="Close" closeButtonAriaLabel={`Close ${this.props.headerText}`}
customWidth={this.props.panelWidth ? this.props.panelWidth : "440px"} customWidth={this.props.panelWidth ? this.props.panelWidth : "440px"}
headerClassName="panelHeader" headerClassName="panelHeader"
onRenderNavigationContent={this.props.onRenderNavigationContent} onRenderNavigationContent={this.props.onRenderNavigationContent}

4
src/Explorer/Panes/__snapshots__/PanelContainerComponent.test.tsx.snap
View File

@ -2,7 +2,7 @@
exports[`PaneContainerComponent test should be resize if notification console is expanded 1`] = ` exports[`PaneContainerComponent test should be resize if notification console is expanded 1`] = `
<StyledPanelBase <StyledPanelBase
closeButtonAriaLabel="Close" closeButtonAriaLabel="Close test"
customWidth="440px" customWidth="440px"
headerClassName="panelHeader" headerClassName="panelHeader"
headerText="test" headerText="test"
@ -42,7 +42,7 @@ exports[`PaneContainerComponent test should render nothing if content is undefin
exports[`PaneContainerComponent test should render with panel content and header 1`] = ` exports[`PaneContainerComponent test should render with panel content and header 1`] = `
<StyledPanelBase <StyledPanelBase
closeButtonAriaLabel="Close" closeButtonAriaLabel="Close test"
customWidth="440px" customWidth="440px"
headerClassName="panelHeader" headerClassName="panelHeader"
headerText="test" headerText="test"