Fix file downloads from notebooks container (#196)

* Fix file downloads from notebooks container

* Add downloading message
This commit is contained in:
Tanuj Mittal
2020-09-11 19:37:00 -07:00
committed by GitHub
parent 83b13de685
commit 728eeefa17
3 changed files with 42 additions and 12 deletions

View File

@@ -194,18 +194,24 @@ export class NotebookContentClient {
});
}
public readFileContent(filePath: string): Promise<string> {
const fileType = NotebookUtil.isNotebookFile(filePath) ? "notebook" : "file";
return this.contentProvider
.get(this.getServerConfig(), filePath, { type: fileType, format: "text", content: 1 })
.toPromise()
.then(xhr => {
const content = (xhr.response as any).content;
if (!content) {
throw new Error("No content read");
}
public async readFileContent(filePath: string): Promise<string> {
const xhr = await this.contentProvider.get(this.getServerConfig(), filePath, { content: 1 }).toPromise();
const content = (xhr.response as any).content;
if (!content) {
throw new Error("No content read");
}
const format = (xhr.response as any).format;
switch (format) {
case "text":
return content;
case "base64":
return atob(content);
case "json":
return stringifyNotebook(content);
});
default:
throw new Error(`Unsupported content format ${format}`);
}
}
private deleteNotebookFile(path: string): Promise<string> {