From 7c73a59ff5603164107d4b50e44b6baed695aeed Mon Sep 17 00:00:00 2001
From: Laurent Nguyen <laurent.nguyen@microsoft.com>
Date: Fri, 3 May 2024 10:17:59 +0200
Subject: [PATCH] Fix update id list after delete

---
 src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
index a43a82e25..0d0cb178c 100644
--- a/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
+++ b/src/Explorer/Tabs/DocumentsTabV2/DocumentsTabV2.tsx
@@ -859,15 +859,8 @@ const DocumentsTabComponent: React.FunctionComponent<{
       setIsExecuting(true);
       _deleteDocuments(toDeleteDocumentIds)
         .then((deletedIds: string[]) => {
-          const newDocumentIds = [...documentIds];
-          deletedIds.forEach((deletedId) => {
-            if (deletedId !== undefined) {
-              const index = toDeleteDocumentIds.findIndex((documentId) => documentId.rid === deletedId);
-              if (index !== -1) {
-                newDocumentIds.splice(index, 1);
-              }
-            }
-          });
+          // This could be optimized by using Set.has instead of array.includes
+          const newDocumentIds = [...documentIds.filter((documentId) => !deletedIds.includes(documentId.id()))];
           setDocumentIds(newDocumentIds);
 
           setSelectedDocumentContent(undefined);