From 8e6d274b117dadd0014ffd57caaea08d802814b1 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Yadav <79906609+sunilyadav840@users.noreply.github.com> Date: Thu, 13 May 2021 06:26:48 +0530 Subject: [PATCH] Add Files to TypeScript Strict (#776) Co-authored-by: Steve Faulkner --- .../Panes/PanelInfoErrorComponent.tsx | 2 +- tsconfig.strict.json | 20 +++++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/src/Explorer/Panes/PanelInfoErrorComponent.tsx b/src/Explorer/Panes/PanelInfoErrorComponent.tsx index 50f6745ea..43fc978e9 100644 --- a/src/Explorer/Panes/PanelInfoErrorComponent.tsx +++ b/src/Explorer/Panes/PanelInfoErrorComponent.tsx @@ -18,7 +18,7 @@ export const PanelInfoErrorComponent: React.FunctionComponent { - let icon: JSX.Element; + let icon: JSX.Element = ; if (messageType === "error") { icon = ; } else if (messageType === "warning") { diff --git a/tsconfig.strict.json b/tsconfig.strict.json index 7443dd212..3ff54e123 100644 --- a/tsconfig.strict.json +++ b/tsconfig.strict.json @@ -8,13 +8,6 @@ "noUnusedParameters": true }, "files": [ - "./src/hooks/useGraphPhoto.tsx", - "./src/Explorer/Notebook/NotebookRenderer/decorators/CellLabeler.tsx", - "./src/Explorer/Notebook/NotebookRenderer/Prompt.tsx", - "./src/Explorer/Controls/Header/GalleryHeaderComponent.tsx", - "./src/Explorer/Controls/Header/GalleryHeaderComponent.tsx", - "./src/Explorer/Controls/Dialog.tsx", - "./src/Common/Tooltip/InfoTooltip.tsx", "./src/AuthType.ts", "./src/Bindings/ReactBindingHandler.ts", "./src/Common/ArrayHashMap.ts", @@ -43,6 +36,7 @@ "./src/Contracts/SelfServeContracts.ts", "./src/Contracts/SubscriptionType.ts", "./src/Contracts/Versions.ts", + "./src/Explorer/Controls/Dialog.tsx", "./src/Explorer/Controls/GitHub/GitHubStyleConstants.ts", "./src/Explorer/Controls/InputTypeahead/InputTypeahead.ts", "./src/Explorer/Controls/SmartUi/InputUtils.ts", @@ -60,12 +54,16 @@ "./src/Explorer/Notebook/NotebookContentClient.ts", "./src/Explorer/Notebook/NotebookContentItem.ts", "./src/Explorer/Notebook/NotebookRenderer/AzureTheme.tsx", + "./src/Explorer/Notebook/NotebookRenderer/Prompt.tsx", + "./src/Explorer/Notebook/NotebookRenderer/PromptContent.tsx", "./src/Explorer/Notebook/NotebookRenderer/decorators/CellCreator.tsx", + "./src/Explorer/Notebook/NotebookRenderer/decorators/CellLabeler.tsx", "./src/Explorer/Notebook/NotebookUtil.ts", "./src/Explorer/OpenFullScreen.test.tsx", "./src/Explorer/OpenFullScreen.tsx", "./src/Explorer/Panes/PaneComponents.ts", "./src/Explorer/Panes/PanelFooterComponent.tsx", + "./src/Explorer/Panes/PanelInfoErrorComponent.tsx", "./src/Explorer/Panes/PanelLoadingScreen.tsx", "./src/Explorer/Panes/Tables/Validators/EntityPropertyNameValidator.ts", "./src/Explorer/Panes/Tables/Validators/EntityPropertyValidationCommon.ts", @@ -81,6 +79,8 @@ "./src/Index.ts", "./src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts", "./src/Platform/Hosted/Authorization.ts", + "./src/Platform/Hosted/Components/MeControl.test.tsx", + "./src/Platform/Hosted/Components/MeControl.tsx", "./src/Platform/Hosted/Components/SignInButton.tsx", "./src/Platform/Hosted/extractFeatures.test.ts", "./src/Platform/Hosted/extractFeatures.ts", @@ -114,6 +114,7 @@ "./src/Utils/WindowUtils.ts", "./src/hooks/useDirectories.tsx", "./src/hooks/useFullScreenURLs.tsx", + "./src/hooks/useGraphPhoto.tsx", "./src/hooks/useObservable.ts", "./src/i18n.ts", "./src/quickstart.ts", @@ -122,13 +123,16 @@ ], "include": [ "src/CellOutputViewer/transforms/**/*", + "src/Common/Tooltip/**/*", "src/Controls/**/*", "src/Definitions/**/*", "src/Explorer/Controls/ErrorDisplayComponent/**/*", + "src/Explorer/Controls/Header/**/*", "src/Explorer/Controls/RadioSwitchComponent/**/*", "src/Explorer/Controls/ResizeSensorReactComponent/**/*", "src/Explorer/Graph/GraphExplorerComponent/__mocks__/**/*", "src/Explorer/Notebook/NotebookComponent/__mocks__/**/*", + "src/Explorer/Panes/RightPaneForm/**/*", "src/Libs/**/*", "src/Localization/**/*", "src/Platform/Emulator/**/*", @@ -136,4 +140,4 @@ "src/Terminal/**/*", "src/Utils/arm/**/*" ] -} \ No newline at end of file +}