Update Code of Conduct Overlay and other minor changes (#424)

* Use light theme for coc-overlay

* Updates

* Fix vertical height for COC overlay
This commit is contained in:
Tanuj Mittal 2021-02-05 14:56:50 +05:30 committed by GitHub
parent 3fd014ddad
commit 93cfd52e36
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 8 deletions

View File

@ -101,7 +101,7 @@ export class CodeOfConductComponent extends React.Component<CodeOfConductCompone
fontSize: 12, fontSize: 12,
}, },
}} }}
label="I have read and accepted the code of conduct." label="I have read and accept the code of conduct."
onChange={this.onChangeCheckbox} onChange={this.onChangeCheckbox}
/> />
</Stack.Item> </Stack.Item>

View File

@ -10,9 +10,11 @@
.publicGalleryTabContainer { .publicGalleryTabContainer {
position: relative; position: relative;
height: 100vh;
} }
.publicGalleryTabOverlayContent { .publicGalleryTabOverlayContent {
background: white; background: white;
padding: 20px; padding: 20px;
margin: 10%;
} }

View File

@ -164,12 +164,7 @@ export class GalleryViewerComponent extends React.Component<GalleryViewerCompone
if (this.props.container?.isGalleryPublishEnabled()) { if (this.props.container?.isGalleryPublishEnabled()) {
tabs.push(this.createFavoritesTab(GalleryTab.Favorites, this.state.favoriteNotebooks)); tabs.push(this.createFavoritesTab(GalleryTab.Favorites, this.state.favoriteNotebooks));
tabs.push(this.createPublishedNotebooksTab(GalleryTab.Published, this.state.publishedNotebooks));
// explicitly checking if isCodeOfConductAccepted is not false, as it is initially undefined.
// Displaying code of conduct component on gallery load should not be the default behavior.
if (this.state.isCodeOfConductAccepted !== false) {
tabs.push(this.createPublishedNotebooksTab(GalleryTab.Published, this.state.publishedNotebooks));
}
} }
const pivotProps: IPivotProps = { const pivotProps: IPivotProps = {

View File

@ -38,7 +38,7 @@ exports[`CodeOfConductComponent renders 1`] = `
</StackItem> </StackItem>
<StackItem> <StackItem>
<StyledCheckboxBase <StyledCheckboxBase
label="I have read and accepted the code of conduct." label="I have read and accept the code of conduct."
onChange={[Function]} onChange={[Function]}
styles={ styles={
Object { Object {