From a2b0cf236ecd3af1af0738c2b548c7db4aa6d0cf Mon Sep 17 00:00:00 2001 From: Sampath Date: Mon, 27 Mar 2023 16:33:08 +0530 Subject: [PATCH] fix for defects 2276938,2280272,2276941,2262647 --- src/Common/TableEntity.tsx | 1 - .../ThroughputInput/ThroughputInput.test.tsx | 4 +- .../ThroughputInput/ThroughputInput.tsx | 33 +- .../ThroughputInput.test.tsx.snap | 592 +++++++++--------- .../MiddlePaneComponent.tsx | 2 +- 5 files changed, 324 insertions(+), 308 deletions(-) diff --git a/src/Common/TableEntity.tsx b/src/Common/TableEntity.tsx index f3ec564f5..e4072f190 100644 --- a/src/Common/TableEntity.tsx +++ b/src/Common/TableEntity.tsx @@ -142,7 +142,6 @@ export const TableEntity: FunctionComponent = ({ {...imageProps} src={EditIcon} alt="editEntity" - id="editEntity" onClick={onEditEntity} tabIndex={0} onKeyPress={handleKeyPress} diff --git a/src/Explorer/Controls/ThroughputInput/ThroughputInput.test.tsx b/src/Explorer/Controls/ThroughputInput/ThroughputInput.test.tsx index 4dc81a97d..eb43ad13a 100644 --- a/src/Explorer/Controls/ThroughputInput/ThroughputInput.test.tsx +++ b/src/Explorer/Controls/ThroughputInput/ThroughputInput.test.tsx @@ -23,12 +23,12 @@ describe("ThroughputInput Pane", () => { }); it("should switch mode properly", () => { - wrapper.find('[aria-label="Manual database throughput"]').simulate("change"); + wrapper.find('[id="Manual-input"]').simulate("change"); expect(wrapper.find('[aria-label="Throughput header"]').at(0).text()).toBe( "Container throughput (400 - unlimited RU/s)" ); - wrapper.find('[aria-label="Autoscale database throughput"]').simulate("change"); + wrapper.find('[id="Autoscale-input"]').simulate("change"); expect(wrapper.find('[aria-label="Throughput header"]').at(0).text()).toBe("Container throughput (autoscale)"); }); }); diff --git a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx index 926b1af5c..a8677c0d9 100644 --- a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx +++ b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx @@ -189,7 +189,7 @@ export const ThroughputInput: FunctionComponent = ({ = ({ = ({ Estimate your required RU/s with{" "} - - capacity calculator - + + + capacity calculator + + . @@ -249,8 +251,9 @@ export const ThroughputInput: FunctionComponent = ({ onChange={(event, newInput?: string) => onThroughputValueChange(newInput)} step={AutoPilotUtils.autoPilotIncrementStep} min={AutoPilotUtils.autoPilotThroughput1K} + max={!isSharded ? 10000 : 9000000000000} value={throughput.toString()} - aria-label="Max request units per second" + ariaLabel="Max request units per second" required={true} errorMessage={throughputError} /> @@ -270,9 +273,11 @@ export const ThroughputInput: FunctionComponent = ({ Estimate your required RU/s with  - - capacity calculator - + + + capacity calculator + + . @@ -295,7 +300,7 @@ export const ThroughputInput: FunctionComponent = ({ min={SharedConstants.CollectionCreation.DefaultCollectionRUs400} max={userContext.isTryCosmosDBSubscription ? Constants.TryCosmosExperience.maxRU : Infinity} value={throughput.toString()} - aria-label="Max request units per second" + ariaLabel="Max request units per second" required={true} errorMessage={throughputError} /> diff --git a/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap b/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap index 864124ad4..3b17a8ead 100644 --- a/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap +++ b/src/Explorer/Controls/ThroughputInput/__snapshots__/ThroughputInput.test.tsx.snap @@ -659,7 +659,7 @@ exports[`ThroughputInput Pane should render Default properly 1`] = ` role="radiogroup" > Estimate your required RU/s with - - - - capacity calculator - - - + + capacity calculator + + + + . @@ -1640,10 +1648,11 @@ exports[`ThroughputInput Pane should render Default properly 1`] = `