random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-12-20 17:30:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add support for changing GitHub OAuth permissions (#4)

Browse Source
This commit is contained in:
Tanuj Mittal
2020-05-29 19:16:50 -07:00
committed by GitHub
parent f308aeb929
commit a6c44e0e69
3 changed files with 28 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/GitHub/GitHubOAuthService.test.ts
View File

@@ -60,20 +60,20 @@ describe("GitHubOAuthService", () => {
expect(gitHubOAuthService.getTokenObservable()()).toBeUndefined();
});
it("startOAuth resets OAuth state", () => {
it("startOAuth resets OAuth state", async () => {
let url: string;
const windowOpenCallback = jest.fn().mockImplementation((value: string) => {
url = value;
});
window.open = windowOpenCallback;
gitHubOAuthService.startOAuth("scope");
await gitHubOAuthService.startOAuth("scope");
expect(windowOpenCallback).toBeCalled();
const initialParams = new URLSearchParams(new URL(url).search);
expect(initialParams.get("state")).toBeDefined();
gitHubOAuthService.startOAuth("another scope");
await gitHubOAuthService.startOAuth("another scope");
expect(windowOpenCallback).toBeCalled();
const newParams = new URLSearchParams(new URL(url).search);
@@ -106,7 +106,7 @@ describe("GitHubOAuthService", () => {
junoClient.getGitHubToken = getGitHubTokenCallback;
const initialToken = gitHubOAuthService.getTokenObservable()();
const state = gitHubOAuthService.startOAuth("scope");
const state = await gitHubOAuthService.startOAuth("scope");
const params: IGitHubConnectorParams = {
state,
@@ -120,7 +120,7 @@ describe("GitHubOAuthService", () => {
});
it("finishOAuth updates token to error if state doesn't match", async () => {
gitHubOAuthService.startOAuth("scope");
await gitHubOAuthService.startOAuth("scope");
const params: IGitHubConnectorParams = {
state: "state",
@@ -135,7 +135,7 @@ describe("GitHubOAuthService", () => {
const getGitHubTokenCallback = jest.fn().mockReturnValue({ status: HttpStatusCodes.NotFound });
junoClient.getGitHubToken = getGitHubTokenCallback;
const state = gitHubOAuthService.startOAuth("scope");
const state = await gitHubOAuthService.startOAuth("scope");
const params: IGitHubConnectorParams = {
state,