diff --git a/.eslintrc.js b/.eslintrc.js index e292cb2bd..74f83d9ad 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -34,6 +34,7 @@ module.exports = { }, ], rules: { + "jsx-a11y/anchor-is-valid": 1, "no-console": ["error", { allow: ["error", "warn", "dir"] }], curly: "error", "@typescript-eslint/switch-exhaustiveness-check": "error", diff --git a/src/Common/EntityValue.tsx b/src/Common/EntityValue.tsx index edea0fa35..be8bfeecc 100644 --- a/src/Common/EntityValue.tsx +++ b/src/Common/EntityValue.tsx @@ -40,7 +40,6 @@ export const EntityValue: FunctionComponent = ({ = ({ label={entityValueLabel && entityValueLabel} className="addEntityTextField" id="entityValueId" - autoFocus disabled={isEntityValueDisable} type={entityValueType} placeholder={entityValuePlaceholder} diff --git a/src/Common/TableEntity.tsx b/src/Common/TableEntity.tsx index 3a38f275e..ab725a717 100644 --- a/src/Common/TableEntity.tsx +++ b/src/Common/TableEntity.tsx @@ -96,7 +96,6 @@ export const TableEntity: FunctionComponent = ({ = ({ props.onUpload(event); } }; - const title = label + " to upload"; + return (
{label} @@ -67,7 +67,7 @@ export const Upload: FunctionComponent = ({ role="button" /> - {title} + {label}
diff --git a/src/Explorer/Controls/ErrorDisplayComponent/ErrorDisplayComponent.less b/src/Explorer/Controls/ErrorDisplayComponent/ErrorDisplayComponent.less index 492903c5f..1a316747e 100644 --- a/src/Explorer/Controls/ErrorDisplayComponent/ErrorDisplayComponent.less +++ b/src/Explorer/Controls/ErrorDisplayComponent/ErrorDisplayComponent.less @@ -32,6 +32,9 @@ .errorLink { cursor: pointer; } + .errorLinkColor { + color: @AccentMediumHigh; + } } .paneErrorIcon { diff --git a/src/Explorer/Controls/RadioSwitchComponent/RadioSwitchComponent.tsx b/src/Explorer/Controls/RadioSwitchComponent/RadioSwitchComponent.tsx index 5a4c38b43..44ae25bad 100644 --- a/src/Explorer/Controls/RadioSwitchComponent/RadioSwitchComponent.tsx +++ b/src/Explorer/Controls/RadioSwitchComponent/RadioSwitchComponent.tsx @@ -25,6 +25,7 @@ export class RadioSwitchComponent extends React.Component {this.props.choices.map((choice: Choice) => ( this.onSelect(choice)} diff --git a/src/Explorer/Controls/Settings/SettingsSubComponents/IndexingPolicyComponent.tsx b/src/Explorer/Controls/Settings/SettingsSubComponents/IndexingPolicyComponent.tsx index 1f216b241..b5b5559f7 100644 --- a/src/Explorer/Controls/Settings/SettingsSubComponents/IndexingPolicyComponent.tsx +++ b/src/Explorer/Controls/Settings/SettingsSubComponents/IndexingPolicyComponent.tsx @@ -122,7 +122,7 @@ export class IndexingPolicyComponent extends React.Component< {isDirty(this.props.indexingPolicyContent, this.props.indexingPolicyContentBaseline) && ( {indexingPolicynUnsavedWarningMessage} )} -
+
); } diff --git a/src/Explorer/Controls/Settings/SettingsSubComponents/__snapshots__/IndexingPolicyComponent.test.tsx.snap b/src/Explorer/Controls/Settings/SettingsSubComponents/__snapshots__/IndexingPolicyComponent.test.tsx.snap index 1f66324f5..53f9a1882 100644 --- a/src/Explorer/Controls/Settings/SettingsSubComponents/__snapshots__/IndexingPolicyComponent.test.tsx.snap +++ b/src/Explorer/Controls/Settings/SettingsSubComponents/__snapshots__/IndexingPolicyComponent.test.tsx.snap @@ -13,6 +13,7 @@ exports[`IndexingPolicyComponent renders 1`] = ` />
diff --git a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx index 8d1321500..323cea83b 100644 --- a/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx +++ b/src/Explorer/Controls/ThroughputInput/ThroughputInput.tsx @@ -57,7 +57,6 @@ export class ThroughputInput extends React.Component @@ -68,7 +67,6 @@ export class ThroughputInput extends React.Component diff --git a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx index f2c427c2b..ef04f5036 100644 --- a/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx +++ b/src/Explorer/Menus/NotificationConsole/NotificationConsoleComponent.tsx @@ -120,6 +120,7 @@ export class NotificationConsoleComponent extends React.Component< onClick={() => this.expandCollapseConsole()} onKeyDown={(event: React.KeyboardEvent) => this.onExpandCollapseKeyPress(event)} tabIndex={0} + role="button" >
@@ -179,7 +180,7 @@ export class NotificationConsoleComponent extends React.Component< onKeyDown={(event: React.KeyboardEvent) => this.onClearNotificationsKeyPress(event)} tabIndex={0} > - clear notifications image + clear notifications Clear Notifications
diff --git a/src/Explorer/Menus/NotificationConsole/__snapshots__/NotificationConsoleComponent.test.tsx.snap b/src/Explorer/Menus/NotificationConsole/__snapshots__/NotificationConsoleComponent.test.tsx.snap index c28eb6008..fe1b53fa5 100644 --- a/src/Explorer/Menus/NotificationConsole/__snapshots__/NotificationConsoleComponent.test.tsx.snap +++ b/src/Explorer/Menus/NotificationConsole/__snapshots__/NotificationConsoleComponent.test.tsx.snap @@ -9,6 +9,7 @@ exports[`NotificationConsoleComponent renders the console 1`] = ` id="notificationConsoleHeader" onClick={[Function]} onKeyDown={[Function]} + role="button" tabIndex={0} >
clear notifications image Clear Notifications @@ -173,6 +174,7 @@ exports[`NotificationConsoleComponent renders the console 2`] = ` id="notificationConsoleHeader" onClick={[Function]} onKeyDown={[Function]} + role="button" tabIndex={0} >
clear notifications image Clear Notifications diff --git a/src/Explorer/Panes/AddCollectionPanel.tsx b/src/Explorer/Panes/AddCollectionPanel.tsx index 89cf46d6c..20205c223 100644 --- a/src/Explorer/Panes/AddCollectionPanel.tsx +++ b/src/Explorer/Panes/AddCollectionPanel.tsx @@ -139,7 +139,6 @@ export class AddCollectionPanel extends React.Component @@ -175,7 +173,6 @@ export class AddCollectionPanel extends React.Component) => this.setState({ newDatabaseId: event.target.value }) @@ -287,7 +284,6 @@ export class AddCollectionPanel extends React.Component @@ -299,7 +295,6 @@ export class AddCollectionPanel extends React.Component @@ -342,7 +337,6 @@ export class AddCollectionPanel extends React.Component) => { const uniqueKeys = this.state.uniqueKeys.map((uniqueKey: string, j: number) => { @@ -594,7 +586,6 @@ export class AddCollectionPanel extends React.ComponentConfirm by typing the {collectionName.toLowerCase()} id { diff --git a/src/Explorer/Panes/DeleteCollectionConfirmationPane/__snapshots__/DeleteCollectionConfirmationPane.test.tsx.snap b/src/Explorer/Panes/DeleteCollectionConfirmationPane/__snapshots__/DeleteCollectionConfirmationPane.test.tsx.snap index d0082d724..a445e6fe4 100644 --- a/src/Explorer/Panes/DeleteCollectionConfirmationPane/__snapshots__/DeleteCollectionConfirmationPane.test.tsx.snap +++ b/src/Explorer/Panes/DeleteCollectionConfirmationPane/__snapshots__/DeleteCollectionConfirmationPane.test.tsx.snap @@ -28,21 +28,27 @@ exports[`Delete Collection Confirmation Pane submit() should call delete collect >
@@ -1198,7 +1206,6 @@ exports[`Delete Collection Confirmation Pane submit() should call delete collect Loader img diff --git a/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.tsx b/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.tsx index 1aef7a411..66dc2964b 100644 --- a/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.tsx +++ b/src/Explorer/Panes/DeleteDatabaseConfirmationPanel.tsx @@ -1,5 +1,5 @@ -import { useBoolean } from "@fluentui/react-hooks"; import { Text, TextField } from "@fluentui/react"; +import { useBoolean } from "@fluentui/react-hooks"; import React, { FunctionComponent, useState } from "react"; import { Areas } from "../../Common/Constants"; import { deleteDatabase } from "../../Common/dataAccess/deleteDatabase"; @@ -134,7 +134,6 @@ export const DeleteDatabaseConfirmationPanel: FunctionComponentConfirm by typing the database id { setDatabaseInput(newInput); diff --git a/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx b/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx index 521ebc966..eb92d34ed 100644 --- a/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx +++ b/src/Explorer/Panes/ExecuteSprocParamsPane/InputParameter.tsx @@ -63,7 +63,6 @@ export const InputParameter: FunctionComponent = ({ diff --git a/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap b/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap index 207e955ae..87a54f2ba 100644 --- a/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap +++ b/src/Explorer/Panes/ExecuteSprocParamsPane/__snapshots__/ExecuteSprocParamsPane.test.tsx.snap @@ -19,21 +19,27 @@ exports[`Excute Sproc Param Pane should render Default properly 1`] = ` >
@@ -2709,14 +2717,12 @@ exports[`Excute Sproc Param Pane should render Default properly 1`] = `
@@ -97,7 +104,7 @@ export const GenericRightPaneComponent: FunctionComponent const renderLoadingScreen = (): JSX.Element => { return ( ); }; @@ -110,9 +117,16 @@ export const GenericRightPaneComponent: FunctionComponent }; return ( -
-
-
+
+
+
{renderPanelHeader()} {renderErrorSection()} diff --git a/src/Explorer/Panes/LoadQueryPane/LoadQueryPane.tsx b/src/Explorer/Panes/LoadQueryPane/LoadQueryPane.tsx index d1536f5be..1bcf8ddb1 100644 --- a/src/Explorer/Panes/LoadQueryPane/LoadQueryPane.tsx +++ b/src/Explorer/Panes/LoadQueryPane/LoadQueryPane.tsx @@ -1,5 +1,5 @@ -import { useBoolean } from "@fluentui/react-hooks"; import { IImageProps, Image, ImageFit, Stack, TextField } from "@fluentui/react"; +import { useBoolean } from "@fluentui/react-hooks"; import React, { FunctionComponent, useState } from "react"; import folderIcon from "../../../../images/folder_16x16.svg"; import { logError } from "../../../Common/Logger"; @@ -115,7 +115,6 @@ export const LoadQueryPane: FunctionComponent = ({ id="confirmCollectionId" label="Select a query document" value={selectedFileName} - autoFocus readOnly styles={{ fieldGroup: { width: 300 } }} /> diff --git a/src/Explorer/Panes/LoadQueryPane/__snapshots__/LoadQueryPane.test.tsx.snap b/src/Explorer/Panes/LoadQueryPane/__snapshots__/LoadQueryPane.test.tsx.snap index 641b3ef6f..6994b1846 100644 --- a/src/Explorer/Panes/LoadQueryPane/__snapshots__/LoadQueryPane.test.tsx.snap +++ b/src/Explorer/Panes/LoadQueryPane/__snapshots__/LoadQueryPane.test.tsx.snap @@ -22,7 +22,6 @@ exports[`Load Query Pane should render Default properly 1`] = ` horizontal={true} > {showErrorDetails && ( - + )} diff --git a/src/Explorer/Panes/PanelLoadingScreen.tsx b/src/Explorer/Panes/PanelLoadingScreen.tsx index 339b3ceb8..a4077a9c4 100644 --- a/src/Explorer/Panes/PanelLoadingScreen.tsx +++ b/src/Explorer/Panes/PanelLoadingScreen.tsx @@ -3,6 +3,6 @@ import LoadingIndicator_3Squares from "../../../images/LoadingIndicator_3Squares export const PanelLoadingScreen: React.FunctionComponent = () => (
- + Loader
); diff --git a/src/Explorer/Panes/RightPaneForm/RightPaneForm.tsx b/src/Explorer/Panes/RightPaneForm/RightPaneForm.tsx index 40120ff76..e1f529286 100644 --- a/src/Explorer/Panes/RightPaneForm/RightPaneForm.tsx +++ b/src/Explorer/Panes/RightPaneForm/RightPaneForm.tsx @@ -78,9 +78,16 @@ export const RightPaneForm: FunctionComponent = ({ }; return ( -
-
-
+
+
+
{renderPanelHeader()} diff --git a/src/Explorer/Panes/RightPaneForm/__snapshots__/RightPaneForm.test.tsx.snap b/src/Explorer/Panes/RightPaneForm/__snapshots__/RightPaneForm.test.tsx.snap index f11ff705e..df3da7092 100644 --- a/src/Explorer/Panes/RightPaneForm/__snapshots__/RightPaneForm.test.tsx.snap +++ b/src/Explorer/Panes/RightPaneForm/__snapshots__/RightPaneForm.test.tsx.snap @@ -15,21 +15,27 @@ exports[`Load Query Pane should render Default properly 1`] = ` >
= ({ label={inputLabel} name="collectionIdConfirmation" value={stringInput} - autoFocus required onChange={(event: FormEvent, newValue?: string) => setStringInput(newValue) diff --git a/src/Explorer/Panes/StringInputPane/__snapshots__/StringInputPane.test.tsx.snap b/src/Explorer/Panes/StringInputPane/__snapshots__/StringInputPane.test.tsx.snap index 54de722ba..cf22f5730 100644 --- a/src/Explorer/Panes/StringInputPane/__snapshots__/StringInputPane.test.tsx.snap +++ b/src/Explorer/Panes/StringInputPane/__snapshots__/StringInputPane.test.tsx.snap @@ -1294,21 +1294,27 @@ exports[`StringInput Pane should render Create new directory properly 1`] = ` >
@@ -2443,7 +2451,6 @@ exports[`StringInput Pane should render Create new directory properly 1`] = ` >