random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-02-16 17:25:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add lint rule to prefer arror function (#114)

Browse Source
This commit is contained in:
Steve Faulkner 2020-07-27 16:40:04 -05:00 committed by GitHub
parent fea321cd68
commit aea168c893
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.eslintrc.js
View File

@ -3,7 +3,7 @@ module.exports = {
browser: true, browser: true,
es6: true es6: true
}, },
plugins: ["@typescript-eslint", "no-null"], plugins: ["@typescript-eslint", "no-null", "prefer-arrow"],
extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"], extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
globals: { globals: {
Atomics: "readonly", Atomics: "readonly",
@ -40,6 +40,7 @@ module.exports = {
"@typescript-eslint/no-unused-vars": "error", "@typescript-eslint/no-unused-vars": "error",
"@typescript-eslint/no-extraneous-class": "error", "@typescript-eslint/no-extraneous-class": "error",
"no-null/no-null": "error", "no-null/no-null": "error",
"@typescript-eslint/no-explicit-any": "error" "@typescript-eslint/no-explicit-any": "error",
"prefer-arrow/prefer-arrow-functions": ["error", { allowStandaloneDeclarations: true }]
} }
}; };

6
package-lock.json generated
View File

@ -12757,6 +12757,12 @@
"integrity": "sha1-EjaoEjkTkKGHetQAfCbnRTQclR8=", "integrity": "sha1-EjaoEjkTkKGHetQAfCbnRTQclR8=",
"dev": true "dev": true
}, },
"eslint-plugin-prefer-arrow": {
"version": "1.2.2",
"resolved": "https://registry.npmjs.org/eslint-plugin-prefer-arrow/-/eslint-plugin-prefer-arrow-1.2.2.tgz",
"integrity": "sha512-C8YMhL+r8RMeMdYAw/rQtE6xNdMulj+zGWud/qIGnlmomiPRaLDGLMeskZ3alN6uMBojmooRimtdrXebLN4svQ==",
"dev": true
},
"eslint-plugin-react": { "eslint-plugin-react": {
"version": "7.20.0", "version": "7.20.0",
"resolved": "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.20.0.tgz", "resolved": "https://registry.npmjs.org/eslint-plugin-react/-/eslint-plugin-react-7.20.0.tgz",

1
package.json
View File

@ -131,6 +131,7 @@
"eslint": "7.3.1", "eslint": "7.3.1",
"eslint-cli": "1.1.1", "eslint-cli": "1.1.1",
"eslint-plugin-no-null": "1.0.2", "eslint-plugin-no-null": "1.0.2",
"eslint-plugin-prefer-arrow": "1.2.2",
"eslint-plugin-react": "7.20.0", "eslint-plugin-react": "7.20.0",
"expose-loader": "0.7.5", "expose-loader": "0.7.5",
"file-loader": "2.0.0", "file-loader": "2.0.0",

6
src/Explorer/Panes/PublishNotebookPaneComponent.tsx
View File

@ -60,12 +60,12 @@ export class PublishNotebookPaneComponent extends React.Component<PublishNoteboo
this.imageToBase64 = (file: File, updateImageSrc: (result: string) => void) => { this.imageToBase64 = (file: File, updateImageSrc: (result: string) => void) => {
const reader = new FileReader(); const reader = new FileReader();
reader.readAsDataURL(file); reader.readAsDataURL(file);
reader.onload = function() { reader.onload = () => {
updateImageSrc(reader.result.toString()); updateImageSrc(reader.result.toString());
}; };
const onError = this.props.onError; const onError = this.props.onError;
reader.onerror = function(error) { reader.onerror = error => {
const formError = `Failed to convert ${file.name} to base64 format`; const formError = `Failed to convert ${file.name} to base64 format`;
const formErrorDetail = `${error}`; const formErrorDetail = `${error}`;
const area = "PublishNotebookPaneComponent/selectImageFile"; const area = "PublishNotebookPaneComponent/selectImageFile";
@ -95,7 +95,7 @@ export class PublishNotebookPaneComponent extends React.Component<PublishNoteboo
const context = canvas.getContext("2d"); const context = canvas.getContext("2d");
const image = new Image(); const image = new Image();
image.src = originalImageData; image.src = originalImageData;
image.onload = function() { image.onload = () => {
context.drawImage(image, 0, 0); context.drawImage(image, 0, 0);
updateImageSrcWithScreenshot(canvas.toDataURL()); updateImageSrcWithScreenshot(canvas.toDataURL());
}; };