From b85a20cbeaba5d5791628fc4b836ab95aa75a050 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Yadav <79906609+sunilyadav840@users.noreply.github.com> Date: Wed, 10 Mar 2021 07:03:29 +0530 Subject: [PATCH] Fix Lint errors in StringUtility.ts (#479) --- .eslintignore | 2 -- src/Explorer/Panes/SettingsPane.ts | 2 +- src/Shared/StorageUtility.ts | 2 +- src/Shared/StringUtility.test.ts | 2 +- src/Shared/StringUtility.ts | 14 ++++++-------- 5 files changed, 9 insertions(+), 13 deletions(-) diff --git a/.eslintignore b/.eslintignore index 3f7846c9b..35b4ceda5 100644 --- a/.eslintignore +++ b/.eslintignore @@ -248,8 +248,6 @@ src/Shared/ExplorerSettings.ts src/Shared/PriceEstimateCalculator.ts src/Shared/StorageUtility.test.ts src/Shared/StorageUtility.ts -src/Shared/StringUtility.test.ts -src/Shared/StringUtility.ts src/Shared/appInsights.ts src/SparkClusterManager/ArcadiaResourceManager.ts src/SparkClusterManager/SparkClusterManager.ts diff --git a/src/Explorer/Panes/SettingsPane.ts b/src/Explorer/Panes/SettingsPane.ts index 980c822fe..d3539bd66 100644 --- a/src/Explorer/Panes/SettingsPane.ts +++ b/src/Explorer/Panes/SettingsPane.ts @@ -5,7 +5,7 @@ import { ConsoleDataType } from "../Menus/NotificationConsole/NotificationConsol import { ContextualPaneBase } from "./ContextualPaneBase"; import { LocalStorageUtility, StorageKey } from "../../Shared/StorageUtility"; import * as NotificationConsoleUtils from "../../Utils/NotificationConsoleUtils"; -import { StringUtility } from "../../Shared/StringUtility"; +import * as StringUtility from "../../Shared/StringUtility"; import { configContext } from "../../ConfigContext"; export class SettingsPane extends ContextualPaneBase { diff --git a/src/Shared/StorageUtility.ts b/src/Shared/StorageUtility.ts index 09cd64c89..adf271cec 100644 --- a/src/Shared/StorageUtility.ts +++ b/src/Shared/StorageUtility.ts @@ -1,4 +1,4 @@ -import { StringUtility } from "./StringUtility"; +import * as StringUtility from "./StringUtility"; export class LocalStorageUtility { public static hasItem(key: StorageKey): boolean { diff --git a/src/Shared/StringUtility.test.ts b/src/Shared/StringUtility.test.ts index 5b8fa2580..068711a61 100644 --- a/src/Shared/StringUtility.test.ts +++ b/src/Shared/StringUtility.test.ts @@ -1,4 +1,4 @@ -import { StringUtility } from "./StringUtility"; +import * as StringUtility from "./StringUtility"; describe("String utility", () => { it("Convert to integer from string", () => { diff --git a/src/Shared/StringUtility.ts b/src/Shared/StringUtility.ts index 122f014bb..63ace6020 100644 --- a/src/Shared/StringUtility.ts +++ b/src/Shared/StringUtility.ts @@ -1,9 +1,7 @@ -export class StringUtility { - public static toNumber(num: string | null): number { - return Number(num); - } - - public static toBoolean(valueStr: string | null): boolean { - return valueStr === "true"; - } +export function toNumber(num: string | null): number { + return Number(num); +} + +export function toBoolean(valueStr: string | null): boolean { + return valueStr === "true"; }