random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2025-04-22 09:35:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixed ts strict issue of useSubscription useDatabaseAccount markdown-cells text-file

Browse Source
This commit is contained in:
sunilyadav840 2021-08-30 18:28:33 +05:30
parent 8eeda41021
commit bb134a2441
5 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Explorer/Notebook/NotebookComponent/contents/file/text-file.tsx
View File

@ -18,7 +18,7 @@ const EditorContainer = styled.div`
`; `;
interface MappedStateProps { interface MappedStateProps {
mimetype: string; mimetype: string | null;
text: string; text: string;
contentRef: ContentRef; contentRef: ContentRef;
theme?: "light" | "dark"; theme?: "light" | "dark";
@ -37,7 +37,7 @@ interface TextFileState {
class EditorPlaceholder extends React.PureComponent<MonacoEditorProps> { class EditorPlaceholder extends React.PureComponent<MonacoEditorProps> {
render(): JSX.Element { render(): JSX.Element {
// TODO: Show a little blocky placeholder // TODO: Show a little blocky placeholder
return undefined; return <div />;
} }
} }
@ -83,7 +83,7 @@ interface InitialProps {
} }
function makeMapStateToTextFileProps( function makeMapStateToTextFileProps(
initialState: AppState, _initialState: AppState,
initialProps: InitialProps initialProps: InitialProps
): (state: AppState) => MappedStateProps { ): (state: AppState) => MappedStateProps {
const { contentRef } = initialProps; const { contentRef } = initialProps;
@ -106,7 +106,7 @@ function makeMapStateToTextFileProps(
} }
const makeMapDispatchToTextFileProps = ( const makeMapDispatchToTextFileProps = (
initialDispatch: Dispatch, _initialDispatch: Dispatch,
initialProps: InitialProps initialProps: InitialProps
): ((dispatch: Dispatch) => MappedDispatchProps) => { ): ((dispatch: Dispatch) => MappedDispatchProps) => {
const { contentRef } = initialProps; const { contentRef } = initialProps;

4
src/Explorer/Notebook/NotebookRenderer/markdown-cell.tsx
View File

@ -99,7 +99,7 @@ export class PureMarkdownCell extends React.Component<ComponentProps & DispatchP
} }
export const makeMapStateToProps = ( export const makeMapStateToProps = (
initialState: AppState, _initialState: AppState,
ownProps: ComponentProps ownProps: ComponentProps
): ((state: AppState) => StateProps) => { ): ((state: AppState) => StateProps) => {
const { id, contentRef } = ownProps; const { id, contentRef } = ownProps;
@ -134,7 +134,7 @@ export const makeMapStateToProps = (
}; };
const makeMapDispatchToProps = ( const makeMapDispatchToProps = (
initialDispatch: Dispatch, _initialDispatch: Dispatch,
ownProps: ComponentProps ownProps: ComponentProps
): ((dispatch: Dispatch) => DispatchProps) => { ): ((dispatch: Dispatch) => DispatchProps) => {
const { id, contentRef } = ownProps; const { id, contentRef } = ownProps;

5
src/hooks/useDatabaseAccounts.tsx
View File

@ -32,8 +32,9 @@ export async function fetchDatabaseAccounts(subscriptionId: string, accessToken:
export function useDatabaseAccounts(subscriptionId: string, armToken: string): DatabaseAccount[] | undefined { export function useDatabaseAccounts(subscriptionId: string, armToken: string): DatabaseAccount[] | undefined {
const { data } = useSWR( const { data } = useSWR(
() => (armToken && subscriptionId ? ["databaseAccounts", subscriptionId, armToken] : undefined), // eslint-disable-next-line no-null/no-null
(_, subscriptionId, armToken) => fetchDatabaseAccounts(subscriptionId, armToken) () => (armToken && subscriptionId ? ["databaseAccounts", subscriptionId, armToken] : null),
(_: string, subscriptionId: string, armToken: string) => fetchDatabaseAccounts(subscriptionId, armToken)
); );
return data; return data;
} }

5
src/hooks/useSubscriptions.tsx
View File

@ -34,8 +34,9 @@ export async function fetchSubscriptions(accessToken: string): Promise<Subscript
export function useSubscriptions(armToken: string): Subscription[] | undefined { export function useSubscriptions(armToken: string): Subscription[] | undefined {
const { data } = useSWR( const { data } = useSWR(
() => (armToken ? ["subscriptions", armToken] : undefined), // eslint-disable-next-line no-null/no-null
(_, armToken) => fetchSubscriptions(armToken) () => (armToken ? ["subscriptions", armToken] : null),
(_: string, armToken: string) => fetchSubscriptions(armToken)
); );
return data; return data;
} }

3
tsconfig.strict.json
View File

@ -8,6 +8,9 @@
"noUnusedParameters": true "noUnusedParameters": true
}, },
"files": [ "files": [
"./src/hooks/useDatabaseAccounts.tsx",
"./src/hooks/useSubscriptions.tsx",
"./src/Explorer/Notebook/NotebookComponent/contents/file/text-file.tsx",
"./src/AuthType.ts", "./src/AuthType.ts",
"./src/Bindings/ReactBindingHandler.ts", "./src/Bindings/ReactBindingHandler.ts",
"./src/Common/ArrayHashMap.ts", "./src/Common/ArrayHashMap.ts",