diff --git a/playwright.config.ts b/playwright.config.ts index b1f6a622d..3805281bd 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -14,7 +14,7 @@ export default defineConfig({ trace: "off", video: "off", screenshot: "on", - testIdAttribute: "data-test", + testIdAttribute: "data-testid", contextOptions: { ignoreHTTPSErrors: true, }, diff --git a/src/Explorer/ContainerCopy/Context/CopyJobContext.test.tsx b/src/Explorer/ContainerCopy/Context/CopyJobContext.test.tsx index cd3d550a5..d3776f07c 100644 --- a/src/Explorer/ContainerCopy/Context/CopyJobContext.test.tsx +++ b/src/Explorer/ContainerCopy/Context/CopyJobContext.test.tsx @@ -32,7 +32,7 @@ describe("CopyJobContext", () => { it("should render children correctly", () => { render( -
Test Child
+
Test Child
, ); @@ -552,7 +552,7 @@ describe("CopyJobContext", () => { const TestComponent2 = (): JSX.Element => { const context = useCopyJobContext(); contextValue2 = context; - return
Component 2
; + return
Component 2
; }; render( diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AddReadPermissionToDefaultIdentity.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AddReadPermissionToDefaultIdentity.test.tsx index 5f457f70d..5ef3577b8 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AddReadPermissionToDefaultIdentity.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AddReadPermissionToDefaultIdentity.test.tsx @@ -20,7 +20,7 @@ jest.mock("../../../CopyJobUtils", () => ({ jest.mock("../Components/InfoTooltip", () => { const MockInfoTooltip = ({ content }: { content: React.ReactNode }) => { - return
{content}
; + return
{content}
; }; MockInfoTooltip.displayName = "MockInfoTooltip"; return MockInfoTooltip; @@ -46,13 +46,13 @@ jest.mock("../Components/PopoverContainer", () => { return null; } return ( -
-
{title}
-
{children}
- -
diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AssignPermissions.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AssignPermissions.test.tsx index fcda3e15f..047a2ee5a 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AssignPermissions.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/AssignPermissions.test.tsx @@ -26,7 +26,7 @@ jest.mock("./hooks/usePermissionsSection", () => ({ jest.mock("../../../../../Common/ShimmerTree/ShimmerTree", () => { const MockShimmerTree = (props: any) => { return ( -
+
Loading...
); @@ -37,7 +37,7 @@ jest.mock("../../../../../Common/ShimmerTree/ShimmerTree", () => { jest.mock("./AddManagedIdentity", () => { const MockAddManagedIdentity = () => { - return
Add Managed Identity Component
; + return
Add Managed Identity Component
; }; MockAddManagedIdentity.displayName = "MockAddManagedIdentity"; return MockAddManagedIdentity; @@ -45,7 +45,7 @@ jest.mock("./AddManagedIdentity", () => { jest.mock("./AddReadPermissionToDefaultIdentity", () => { const MockAddReadPermissionToDefaultIdentity = () => { - return
Add Read Permission Component
; + return
Add Read Permission Component
; }; MockAddReadPermissionToDefaultIdentity.displayName = "MockAddReadPermissionToDefaultIdentity"; return MockAddReadPermissionToDefaultIdentity; @@ -53,7 +53,7 @@ jest.mock("./AddReadPermissionToDefaultIdentity", () => { jest.mock("./DefaultManagedIdentity", () => { const MockDefaultManagedIdentity = () => { - return
Default Managed Identity Component
; + return
Default Managed Identity Component
; }; MockDefaultManagedIdentity.displayName = "MockDefaultManagedIdentity"; return MockDefaultManagedIdentity; @@ -61,7 +61,8 @@ jest.mock("./DefaultManagedIdentity", () => { jest.mock("./OnlineCopyEnabled", () => { const MockOnlineCopyEnabled = () => { - return
Online Copy Enabled Component
; + return
Online Copy Enabled Component
; + return
Online Copy Enabled Component
; }; MockOnlineCopyEnabled.displayName = "MockOnlineCopyEnabled"; return MockOnlineCopyEnabled; @@ -69,7 +70,8 @@ jest.mock("./OnlineCopyEnabled", () => { jest.mock("./PointInTimeRestore", () => { const MockPointInTimeRestore = () => { - return
Point In Time Restore Component
; + return
Point In Time Restore Component
; + return
Point In Time Restore Component
; }; MockPointInTimeRestore.displayName = "MockPointInTimeRestore"; return MockPointInTimeRestore; @@ -196,14 +198,16 @@ describe("AssignPermissions Component", () => { { id: "addManagedIdentity", title: "Add Managed Identity", - Component: () =>
Add Managed Identity Component
, + Component: () =>
Add Managed Identity Component
, + Component: () =>
Add Managed Identity Component
, disabled: false, completed: true, }, { id: "readPermissionAssigned", title: "Read Permission Assigned", - Component: () =>
Add Read Permission Component
, + Component: () =>
Add Read Permission Component
, + Component: () =>
Add Read Permission Component
, disabled: false, completed: false, }, @@ -228,14 +232,18 @@ describe("AssignPermissions Component", () => { { id: "pointInTimeRestore", title: "Point In Time Restore", - Component: () =>
Point In Time Restore Component
, + Component: () =>
Point In Time Restore Component
, + Component: () =>
Point In Time Restore Component
, disabled: false, completed: true, }, { id: "onlineCopyEnabled", title: "Online Copy Enabled", - Component: () =>
Online Copy Enabled Component
, + Component: () =>
Online Copy Enabled Component
, + Component: () =>
Online Copy Enabled Component
, + Component: () =>
Add Managed Identity Component
, + Component: () =>
Online Copy Enabled Component
, disabled: false, completed: false, }, @@ -262,7 +270,7 @@ describe("AssignPermissions Component", () => { { id: "addManagedIdentity", title: "Add Managed Identity", - Component: () =>
Add Managed Identity Component
, + Component: () =>
Add Managed Identity Component
, disabled: false, completed: true, }, @@ -276,7 +284,7 @@ describe("AssignPermissions Component", () => { { id: "onlineCopyEnabled", title: "Online Copy Enabled", - Component: () =>
Online Copy Enabled Component
, + Component: () =>
Online Copy Enabled Component
, disabled: false, completed: false, }, diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/DefaultManagedIdentity.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/DefaultManagedIdentity.test.tsx index 0e02e9aba..93418859f 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/DefaultManagedIdentity.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/DefaultManagedIdentity.test.tsx @@ -15,7 +15,7 @@ jest.mock("../../../../../Utils/arm/identityUtils", () => ({ jest.mock("../Components/InfoTooltip", () => { const MockInfoTooltip = ({ content }: { content: React.ReactNode }) => { - return
{content}
; + return
{content}
; }; MockInfoTooltip.displayName = "MockInfoTooltip"; return MockInfoTooltip; @@ -41,14 +41,14 @@ jest.mock("../Components/PopoverContainer", () => { return null; } return ( -
-
{title}
-
{children}
-
{isLoading ? "Loading" : "Not Loading"}
- -
diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/OnlineCopyEnabled.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/OnlineCopyEnabled.test.tsx index 3d87f90d2..189b354e6 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/OnlineCopyEnabled.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/OnlineCopyEnabled.test.tsx @@ -25,7 +25,8 @@ jest.mock("../../../../../Common/Logger", () => ({ jest.mock("../../../../../Common/LoadingOverlay", () => { const MockLoadingOverlay = ({ isLoading, label }: { isLoading: boolean; label: string }) => { - return isLoading ?
{label}
: null; + return isLoading ?
{label}
: null; + return isLoading ?
{label}
: null; }; MockLoadingOverlay.displayName = "MockLoadingOverlay"; return MockLoadingOverlay; diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useManagedIdentity.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useManagedIdentity.test.tsx index 952ad7e01..2a91c8c69 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useManagedIdentity.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useManagedIdentity.test.tsx @@ -52,11 +52,11 @@ const TestComponent: React.FC = ({ updateIdentityFn, onError return (
- -
{loading ? "true" : "false"}
- {contextError &&
{contextError}
} +
{loading ? "true" : "false"}
+ {contextError &&
{contextError}
}
); }; diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/usePermissionsSection.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/usePermissionsSection.test.tsx index 6c2a47779..faa4033a2 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/usePermissionsSection.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/usePermissionsSection.test.tsx @@ -34,7 +34,7 @@ jest.mock("../../../../CopyJobUtils", () => ({ jest.mock("../AddManagedIdentity", () => { const MockAddManagedIdentity = () => { - return
AddManagedIdentity
; + return
AddManagedIdentity
; }; MockAddManagedIdentity.displayName = "MockAddManagedIdentity"; return MockAddManagedIdentity; @@ -42,7 +42,7 @@ jest.mock("../AddManagedIdentity", () => { jest.mock("../AddReadPermissionToDefaultIdentity", () => { const MockAddReadPermissionToDefaultIdentity = () => { - return
AddReadPermissionToDefaultIdentity
; + return
AddReadPermissionToDefaultIdentity
; }; MockAddReadPermissionToDefaultIdentity.displayName = "MockAddReadPermissionToDefaultIdentity"; return MockAddReadPermissionToDefaultIdentity; @@ -50,7 +50,7 @@ jest.mock("../AddReadPermissionToDefaultIdentity", () => { jest.mock("../DefaultManagedIdentity", () => { const MockDefaultManagedIdentity = () => { - return
DefaultManagedIdentity
; + return
DefaultManagedIdentity
; }; MockDefaultManagedIdentity.displayName = "MockDefaultManagedIdentity"; return MockDefaultManagedIdentity; @@ -58,7 +58,7 @@ jest.mock("../DefaultManagedIdentity", () => { jest.mock("../OnlineCopyEnabled", () => { const MockOnlineCopyEnabled = () => { - return
OnlineCopyEnabled
; + return
OnlineCopyEnabled
; }; MockOnlineCopyEnabled.displayName = "MockOnlineCopyEnabled"; return MockOnlineCopyEnabled; @@ -66,7 +66,7 @@ jest.mock("../OnlineCopyEnabled", () => { jest.mock("../PointInTimeRestore", () => { const MockPointInTimeRestore = () => { - return
PointInTimeRestore
; + return
PointInTimeRestore
; }; MockPointInTimeRestore.displayName = "MockPointInTimeRestore"; return MockPointInTimeRestore; @@ -76,12 +76,10 @@ const mockedRbacUtils = RbacUtils as jest.Mocked; const mockedCopyJobPrerequisitesCache = CopyJobPrerequisitesCacheModule as jest.Mocked< typeof CopyJobPrerequisitesCacheModule >; - interface TestWrapperProps { state: CopyJobContextState; onResult?: (result: PermissionGroupConfig[]) => void; } - const TestWrapper: React.FC = ({ state, onResult }) => { const result = usePermissionSections(state); @@ -92,18 +90,18 @@ const TestWrapper: React.FC = ({ state, onResult }) => { }, [result, onResult]); return ( -
-
{result.length}
+
+
{result.length}
{result.map((group) => ( -
+

{group.title}

{group.description}

{group.sections.map((section) => ( -
- +
+ {section.completed?.toString() || "undefined"} - {section.disabled.toString()} + {section.disabled.toString()}
))}
diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useToggle.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useToggle.test.tsx index ed3f1a335..e74d334dc 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useToggle.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/AssignPermissions/hooks/useToggle.test.tsx @@ -7,14 +7,14 @@ const TestToggleComponent: React.FC<{ initialState?: boolean }> = ({ initialStat return (
- {state ? "true" : "false"} - - -
@@ -57,8 +57,8 @@ describe("useToggle hook", () => { return (
- {state ? "true" : "false"} -
diff --git a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/Components/FieldRow.test.tsx b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/Components/FieldRow.test.tsx index c83a0c754..33fd7e0ce 100644 --- a/src/Explorer/ContainerCopy/CreateCopyJob/Screens/Components/FieldRow.test.tsx +++ b/src/Explorer/ContainerCopy/CreateCopyJob/Screens/Components/FieldRow.test.tsx @@ -24,8 +24,8 @@ describe("FieldRow", () => { it("renders children content correctly", () => { render( - - + + , ); @@ -123,7 +123,7 @@ describe("FieldRow", () => { it("positions children in grow container with center alignment", () => { const { container } = render( -
{mockChildContent}
+
{mockChildContent}
, ); @@ -135,7 +135,7 @@ describe("FieldRow", () => { it("maintains layout when no label is provided", () => { const { container } = render( -
{mockChildContent}
+
{mockChildContent}
, ); diff --git a/src/Explorer/Controls/Dialog.tsx b/src/Explorer/Controls/Dialog.tsx index a4c50a3fd..42913967a 100644 --- a/src/Explorer/Controls/Dialog.tsx +++ b/src/Explorer/Controls/Dialog.tsx @@ -214,9 +214,9 @@ export const Dialog: FC = () => { {contentHtml} {progressIndicatorProps && } - + {secondaryButtonProps && ( - + )} diff --git a/src/Explorer/Controls/Editor/EditorReact.tsx b/src/Explorer/Controls/Editor/EditorReact.tsx index 9ca544631..823558842 100644 --- a/src/Explorer/Controls/Editor/EditorReact.tsx +++ b/src/Explorer/Controls/Editor/EditorReact.tsx @@ -137,7 +137,7 @@ export class EditorReact extends React.Component )}
this.setRef(elt)} @@ -148,7 +148,7 @@ export class EditorReact extends React.Component = ({ <> = ({ checked={isAutoscaleSelected} type="radio" role="radio" - data-test="ThroughputInput/ThroughputMode:Autoscale" + data-testid="ThroughputInput/ThroughputMode:Autoscale" tabIndex={0} onChange={(e) => handleOnChangeMode(e, "Autoscale")} /> @@ -225,7 +225,7 @@ export const ThroughputInput: FunctionComponent = ({ type="radio" aria-required={true} role="radio" - data-test="ThroughputInput/ThroughputMode:Manual" + data-testid="ThroughputInput/ThroughputMode:Manual" tabIndex={0} onChange={(e) => handleOnChangeMode(e, "Manual")} /> @@ -288,7 +288,7 @@ export const ThroughputInput: FunctionComponent = ({ = ({ } > = ({ const contextMenuItems = (node.contextMenu ?? []).map((menuItem) => ( menuItem.onClick(contextMenuRef)} @@ -160,14 +160,14 @@ export const TreeNodeComponent: React.FC = ({ const expandIcon = isLoading ? ( ) : !isBranch ? undefined : openItems.includes(treeNodeId) ? ( - + ) : ( - + ); const treeItem = ( = ({ shouldShowAsSelected && treeStyles.selectedItem, node.className && treeStyles[node.className], )} - data-test={`TreeNode:${treeNodeId}`} + data-testid={`TreeNode:${treeNodeId}`} actions={ contextMenuItems.length > 0 && { className: treeStyles.actionsButtonContainer, @@ -189,13 +189,13 @@ export const TreeNodeComponent: React.FC = ({