Remove show div after applyExplorerBindings (#797)

This commit is contained in:
Steve Faulkner 2021-05-18 23:41:44 -05:00 committed by GitHub
parent ae76fb0258
commit c2de2f2eec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions

View File

@ -98,7 +98,7 @@ const App: React.FunctionComponent = () => {
return ( return (
<div className="flexContainer"> <div className="flexContainer">
<div id="divExplorer" className="flexContainer hideOverflows" style={{ display: "none" }}> <div id="divExplorer" className="flexContainer hideOverflows">
{/* Main Command Bar - Start */} {/* Main Command Bar - Start */}
<div data-bind="react: commandBarComponentAdapter" /> <div data-bind="react: commandBarComponentAdapter" />
{/* Collections Tree and Tabs - Begin */} {/* Collections Tree and Tabs - Begin */}

View File

@ -1,5 +1,5 @@
import { BindingHandlersRegisterer } from "./Bindings/BindingHandlersRegisterer";
import * as ko from "knockout"; import * as ko from "knockout";
import { BindingHandlersRegisterer } from "./Bindings/BindingHandlersRegisterer";
import Explorer from "./Explorer/Explorer"; import Explorer from "./Explorer/Explorer";
export const applyExplorerBindings = (explorer: Explorer) => { export const applyExplorerBindings = (explorer: Explorer) => {
@ -7,8 +7,5 @@ export const applyExplorerBindings = (explorer: Explorer) => {
window.dataExplorer = explorer; window.dataExplorer = explorer;
BindingHandlersRegisterer.registerBindingHandlers(); BindingHandlersRegisterer.registerBindingHandlers();
ko.applyBindings(explorer); ko.applyBindings(explorer);
// This message should ideally be sent immediately after explorer has been initialized for optimal data explorer load times.
// TODO: Send another message to describe that the bindings have been applied, and handle message transfers accordingly in the portal
$("#divExplorer").show();
} }
}; };