removed enableGalleryPublish, enableLinkInjection feature flags (#454)

* removed enableGalleryPublish, enableLinkInjection * removed ENABLE_GALLERY_PUBLISH
2025-12-20 01:11:25 +00:00 · 2021-02-26 13:07:44 -08:00
parent 3cc1945140
commit cf01ffa957
20 changed files with 163 additions and 130 deletions
--- a/src/Explorer/Controls/FeaturePanel/FeaturePanelComponent.tsx
+++ b/src/Explorer/Controls/FeaturePanel/FeaturePanelComponent.tsx
@@ -47,13 +47,7 @@ export const FeaturePanelComponent: React.FunctionComponent = () => {
    { key: "feature.dataexplorerexecutesproc", label: "Execute stored procedure", value: "true" },
    { key: "feature.hosteddataexplorerenabled", label: "Hosted Data Explorer (deprecated?)", value: "true" },
    { key: "feature.enablettl", label: "Enable TTL", value: "true" },
-    { key: "feature.enablegallerypublish", label: "Enable Notebook Gallery Publishing", value: "true" },
    { key: "feature.selfServeType", label: "Self serve feature", value: "sample" },
-    {
-      key: "feature.enableLinkInjection",
-      label: "Enable Injecting Notebook Viewer Link into the first cell",
-      value: "true",
-    },
    { key: "feature.canexceedmaximumvalue", label: "Can exceed max value", value: "true" },
    {
      key: "feature.enablefixedcollectionwithsharedthroughput",
--- a/src/Explorer/Controls/FeaturePanel/snapshots/FeaturePanelComponent.test.tsx.snap
+++ b/src/Explorer/Controls/FeaturePanel/snapshots/FeaturePanelComponent.test.tsx.snap
@@ -149,12 +149,6 @@ exports[`Feature panel renders all flags 1`] = `
          label="Enable TTL"
          onChange={[Function]}
        />
-        <StyledCheckboxBase
-          checked={false}
-          key="feature.enablegallerypublish"
-          label="Enable Notebook Gallery Publishing"
-          onChange={[Function]}
-        />
        <StyledCheckboxBase
          checked={false}
          key="feature.selfServeType"
@@ -163,8 +157,8 @@ exports[`Feature panel renders all flags 1`] = `
        />
        <StyledCheckboxBase
          checked={false}
-          key="feature.enableLinkInjection"
-          label="Enable Injecting Notebook Viewer Link into the first cell"
+          key="feature.canexceedmaximumvalue"
+          label="Can exceed max value"
          onChange={[Function]}
        />
      </Stack>
@@ -172,12 +166,6 @@ exports[`Feature panel renders all flags 1`] = `
        className="checkboxRow"
        horizontalAlign="space-between"
      >
-        <StyledCheckboxBase
-          checked={false}
-          key="feature.canexceedmaximumvalue"
-          label="Can exceed max value"
-          onChange={[Function]}
-        />
        <StyledCheckboxBase
          checked={false}
          key="feature.enablefixedcollectionwithsharedthroughput"
--- a/src/Explorer/Controls/NotebookGallery/GalleryAndNotebookViewerComponent.tsx
+++ b/src/Explorer/Controls/NotebookGallery/GalleryAndNotebookViewerComponent.tsx
@@ -7,7 +7,6 @@ import Explorer from "../../Explorer";

 export interface GalleryAndNotebookViewerComponentProps {
  container?: Explorer;
-  isGalleryPublishEnabled: boolean;
  junoClient: JunoClient;
  notebookUrl?: string;
  galleryItem?: IGalleryItem;
@@ -61,7 +60,6 @@ export class GalleryAndNotebookViewerComponent extends React.Component<

    const props: GalleryViewerComponentProps = {
      container: this.props.container,
-      isGalleryPublishEnabled: this.props.isGalleryPublishEnabled,
      junoClient: this.props.junoClient,
      selectedTab: this.state.selectedTab,
      sortBy: this.state.sortBy,
--- a/src/Explorer/Controls/NotebookGallery/GalleryViewerComponent.test.tsx
+++ b/src/Explorer/Controls/NotebookGallery/GalleryViewerComponent.test.tsx
@@ -5,7 +5,6 @@ import { GalleryViewerComponent, GalleryViewerComponentProps, GalleryTab, SortBy
 describe("GalleryViewerComponent", () => {
  it("renders", () => {
    const props: GalleryViewerComponentProps = {
-      isGalleryPublishEnabled: false,
      junoClient: undefined,
      selectedTab: GalleryTab.OfficialSamples,
      sortBy: SortBy.MostViewed,
--- a/src/Explorer/Controls/NotebookGallery/GalleryViewerComponent.tsx
+++ b/src/Explorer/Controls/NotebookGallery/GalleryViewerComponent.tsx
@@ -36,7 +36,6 @@ import { Action, ActionModifiers } from "../../../Shared/Telemetry/TelemetryCons

 export interface GalleryViewerComponentProps {
  container?: Explorer;
-  isGalleryPublishEnabled: boolean;
  junoClient: JunoClient;
  selectedTab: GalleryTab;
  sortBy: SortBy;
@@ -140,17 +139,13 @@ export class GalleryViewerComponent extends React.Component<GalleryViewerCompone
        text: GalleryViewerComponent.mostRecentText,
      },
    ];
-    if (this.props.container?.isGalleryPublishEnabled()) {
-      this.sortingOptions.push({
-        key: SortBy.MostFavorited,
-        text: GalleryViewerComponent.mostFavoritedText,
-      });
-    }
+    this.sortingOptions.push({
+      key: SortBy.MostFavorited,
+      text: GalleryViewerComponent.mostFavoritedText,
+    });

    this.loadTabContent(this.state.selectedTab, this.state.searchText, this.state.sortBy, false);
-    if (this.props.container?.isGalleryPublishEnabled()) {
-      this.loadFavoriteNotebooks(this.state.searchText, this.state.sortBy, false); // Need this to show correct favorite button state
-    }
+    this.loadFavoriteNotebooks(this.state.searchText, this.state.sortBy, false); // Need this to show correct favorite button state
  }

  public render(): JSX.Element {
@@ -158,20 +153,16 @@ export class GalleryViewerComponent extends React.Component<GalleryViewerCompone

    const tabs: GalleryTabInfo[] = [this.createSamplesTab(GalleryTab.OfficialSamples, this.state.sampleNotebooks)];

-    if (this.props.isGalleryPublishEnabled) {
-      tabs.push(
-        this.createPublicGalleryTab(
-          GalleryTab.PublicGallery,
-          this.state.publicNotebooks,
-          this.state.isCodeOfConductAccepted
-        )
-      );
-    }
+    tabs.push(
+      this.createPublicGalleryTab(
+        GalleryTab.PublicGallery,
+        this.state.publicNotebooks,
+        this.state.isCodeOfConductAccepted
+      )
+    );

-    if (this.props.container?.isGalleryPublishEnabled()) {
-      tabs.push(this.createFavoritesTab(GalleryTab.Favorites, this.state.favoriteNotebooks));
-      tabs.push(this.createPublishedNotebooksTab(GalleryTab.Published, this.state.publishedNotebooks));
-    }
+    tabs.push(this.createFavoritesTab(GalleryTab.Favorites, this.state.favoriteNotebooks));
+    tabs.push(this.createPublishedNotebooksTab(GalleryTab.Published, this.state.publishedNotebooks));

    const pivotProps: IPivotProps = {
      onLinkClick: this.onPivotChange,
@@ -406,11 +397,9 @@ export class GalleryViewerComponent extends React.Component<GalleryViewerCompone
          <Stack.Item styles={{ root: { minWidth: 200 } }}>
            <Dropdown options={this.sortingOptions} selectedKey={this.state.sortBy} onChange={this.onDropdownChange} />
          </Stack.Item>
-          {this.props.isGalleryPublishEnabled && (
-            <Stack.Item>
-              <InfoComponent />
-            </Stack.Item>
-          )}
+          <Stack.Item>
+            <InfoComponent />
+          </Stack.Item>
        </Stack>
        <Stack.Item>{content}</Stack.Item>
      </Stack>
@@ -664,10 +653,7 @@ export class GalleryViewerComponent extends React.Component<GalleryViewerCompone
  };

  private onRenderCell = (data?: IGalleryItem): JSX.Element => {
-    let isFavorite: boolean;
-    if (this.props.container?.isGalleryPublishEnabled()) {
-      isFavorite = this.favoriteNotebooks?.find((item) => item.id === data.id) !== undefined;
-    }
+    const isFavorite = this.favoriteNotebooks?.find((item) => item.id === data.id) !== undefined;
    const props: GalleryCardComponentProps = {
      data,
      isFavorite,
--- a/src/Explorer/Controls/NotebookGallery/snapshots/GalleryViewerComponent.test.tsx.snap
+++ b/src/Explorer/Controls/NotebookGallery/snapshots/GalleryViewerComponent.test.tsx.snap
@@ -72,11 +72,18 @@ exports[`GalleryViewerComponent renders 1`] = `
                    "key": 3,
                    "text": "Most recent",
                  },
+                  Object {
+                    "key": 2,
+                    "text": "Most favorited",
+                  },
                ]
              }
              selectedKey={0}
            />
          </StackItem>
+          <StackItem>
+            <InfoComponent />
+          </StackItem>
        </Stack>
        <StackItem>
          <StyledSpinnerBase
@@ -85,6 +92,122 @@ exports[`GalleryViewerComponent renders 1`] = `
        </StackItem>
      </Stack>
    </PivotItem>
+    <PivotItem
+      headerText="Public gallery"
+      itemKey="PublicGallery"
+      key="PublicGallery"
+      style={
+        Object {
+          "marginTop": 20,
+        }
+      }
+    >
+      <div
+        className="publicGalleryTabContainer"
+      >
+        <Stack
+          tokens={
+            Object {
+              "childrenGap": 10,
+            }
+          }
+        >
+          <Stack
+            horizontal={true}
+            tokens={
+              Object {
+                "childrenGap": 20,
+                "padding": 10,
+              }
+            }
+          >
+            <StackItem
+              grow={true}
+            >
+              <StyledSearchBoxBase
+                onChange={[Function]}
+                placeholder="Search"
+              />
+            </StackItem>
+            <StackItem>
+              <StyledLabelBase>
+                Sort by
+              </StyledLabelBase>
+            </StackItem>
+            <StackItem
+              styles={
+                Object {
+                  "root": Object {
+                    "minWidth": 200,
+                  },
+                }
+              }
+            >
+              <StyledWithResponsiveMode
+                onChange={[Function]}
+                options={
+                  Array [
+                    Object {
+                      "key": 0,
+                      "text": "Most viewed",
+                    },
+                    Object {
+                      "key": 1,
+                      "text": "Most downloaded",
+                    },
+                    Object {
+                      "key": 3,
+                      "text": "Most recent",
+                    },
+                    Object {
+                      "key": 2,
+                      "text": "Most favorited",
+                    },
+                  ]
+                }
+                selectedKey={0}
+              />
+            </StackItem>
+            <StackItem>
+              <InfoComponent />
+            </StackItem>
+          </Stack>
+          <StackItem>
+            <StyledSpinnerBase
+              size={3}
+            />
+          </StackItem>
+        </Stack>
+      </div>
+    </PivotItem>
+    <PivotItem
+      headerText="My favorites"
+      itemKey="Favorites"
+      key="Favorites"
+      style={
+        Object {
+          "marginTop": 20,
+        }
+      }
+    >
+      <StyledSpinnerBase
+        size={3}
+      />
+    </PivotItem>
+    <PivotItem
+      headerText="My published work"
+      itemKey="Published"
+      key="Published"
+      style={
+        Object {
+          "marginTop": 20,
+        }
+      }
+    >
+      <StyledSpinnerBase
+        size={3}
+      />
+    </PivotItem>
  </StyledPivotBase>
 </div>
 `;
--- a/src/Explorer/Controls/Settings/snapshots/SettingsComponent.test.tsx.snap
+++ b/src/Explorer/Controls/Settings/snapshots/SettingsComponent.test.tsx.snap
@@ -925,11 +925,9 @@ exports[`SettingsComponent renders 1`] = `
                "isCopyNotebookPaneEnabled": [Function],
                "isEnableMongoCapabilityPresent": [Function],
                "isFixedCollectionWithSharedThroughputSupported": [Function],
-                "isGalleryPublishEnabled": [Function],
                "isGitHubPaneEnabled": [Function],
                "isHostedDataExplorerEnabled": [Function],
                "isLeftPaneExpanded": [Function],
-                "isLinkInjectionEnabled": [Function],
                "isMongoIndexingEnabled": [Function],
                "isNotebookEnabled": [Function],
                "isNotebooksEnabledForAccount": [Function],
@@ -2143,11 +2141,9 @@ exports[`SettingsComponent renders 1`] = `
              "isCopyNotebookPaneEnabled": [Function],
              "isEnableMongoCapabilityPresent": [Function],
              "isFixedCollectionWithSharedThroughputSupported": [Function],
-              "isGalleryPublishEnabled": [Function],
              "isGitHubPaneEnabled": [Function],
              "isHostedDataExplorerEnabled": [Function],
              "isLeftPaneExpanded": [Function],
-              "isLinkInjectionEnabled": [Function],
              "isMongoIndexingEnabled": [Function],
              "isNotebookEnabled": [Function],
              "isNotebooksEnabledForAccount": [Function],
@@ -3374,11 +3370,9 @@ exports[`SettingsComponent renders 1`] = `
                "isCopyNotebookPaneEnabled": [Function],
                "isEnableMongoCapabilityPresent": [Function],
                "isFixedCollectionWithSharedThroughputSupported": [Function],
-                "isGalleryPublishEnabled": [Function],
                "isGitHubPaneEnabled": [Function],
                "isHostedDataExplorerEnabled": [Function],
                "isLeftPaneExpanded": [Function],
-                "isLinkInjectionEnabled": [Function],
                "isMongoIndexingEnabled": [Function],
                "isNotebookEnabled": [Function],
                "isNotebooksEnabledForAccount": [Function],
@@ -4592,11 +4586,9 @@ exports[`SettingsComponent renders 1`] = `
              "isCopyNotebookPaneEnabled": [Function],
              "isEnableMongoCapabilityPresent": [Function],
              "isFixedCollectionWithSharedThroughputSupported": [Function],
-              "isGalleryPublishEnabled": [Function],
              "isGitHubPaneEnabled": [Function],
              "isHostedDataExplorerEnabled": [Function],
              "isLeftPaneExpanded": [Function],
-              "isLinkInjectionEnabled": [Function],
              "isMongoIndexingEnabled": [Function],
              "isNotebookEnabled": [Function],
              "isNotebooksEnabledForAccount": [Function],