random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2024-11-25 06:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix gremlin timeout (#1457)

Browse Source 
* Increase Gremlin request timeout from 6min to 1hr

* Increase query MAX_RESULT_SIZE limit from 10k to 100k.

* Run npm format

---------

Co-authored-by: Laurent Nguyen <laurent.nguyen@microsoft.com>
This commit is contained in:
sindhuba 2023-05-23 13:49:40 -07:00 committed by GitHub
parent 9b214a3171
commit d1c4059320
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Explorer/Graph/GraphExplorerComponent/GraphExplorer.tsx
View File

@ -6,9 +6,9 @@ import * as React from "react";
import LoadGraphIcon from "../../../../images/LoadGraph.png";
import LoadingIndicatorIcon from "../../../../images/LoadingIndicator_3Squares.gif";
import * as Constants from "../../../Common/Constants";
import { getErrorMessage } from "../../../Common/ErrorHandlingUtils";
import { queryDocuments } from "../../../Common/dataAccess/queryDocuments";
import { queryDocumentsPage } from "../../../Common/dataAccess/queryDocumentsPage";
import { getErrorMessage } from "../../../Common/ErrorHandlingUtils";
import * as DataModels from "../../../Contracts/DataModels";
import * as ViewModels from "../../../Contracts/ViewModels";
import { InputProperty } from "../../../Contracts/ViewModels";
@ -182,7 +182,8 @@ export class GraphExplorer extends React.Component<GraphExplorerProps, GraphExpl
public static readonly WITHOUT_STEP_ARGS_MAX_CHARS = 10000; // maximums char size of the without() step parameter
public static readonly ROOT_LIST_PAGE_SIZE = 100;
private static readonly MAX_LATEST_QUERIES = 10;
private static readonly MAX_RESULT_SIZE = 10000;
// TODO This prevents loading too much data in GraphExplorer and d3. A better is to cap the size of the result, rather than the number of items in the array.
private static readonly MAX_RESULT_SIZE = 100_000;
private static readonly TAB_INDEX_JSON = 0;
private static readonly TAB_INDEX_GRAPH = 1;

2
src/Explorer/Graph/GraphExplorerComponent/GremlinClient.ts
View File

@ -31,7 +31,7 @@ export class GremlinClient {
public client: GremlinSimpleClient;
public pendingResults: Map<string, PendingResultData>; // public for testing purposes
private maxResultSize: number;
private static readonly PENDING_REQUEST_TIMEOUT_MS = 6 /* minutes */ * 60 /* seconds */ * 1000 /* ms */;
private static readonly PENDING_REQUEST_TIMEOUT_MS = 1 /* hour */ * 3_600 /* seconds */ * 1_000 /* ms */;
private static readonly TIMEOUT_ERROR_MSG = `Pending request timed out (${GremlinClient.PENDING_REQUEST_TIMEOUT_MS} ms)`;
private static readonly LOG_AREA = "GremlinClient";