mirror of
https://github.com/Azure/cosmos-explorer.git
synced 2026-06-08 13:37:29 +01:00
resolve the copilot suggestions
This commit is contained in:
@@ -187,7 +187,7 @@ export class DocumentsTabV2 extends TabsBase {
|
|||||||
partitionKey: this.partitionKey,
|
partitionKey: this.partitionKey,
|
||||||
documentIds: ko.observableArray<DocumentId>([]),
|
documentIds: ko.observableArray<DocumentId>([]),
|
||||||
tabKind: ViewModels.CollectionTabKind.Documents,
|
tabKind: ViewModels.CollectionTabKind.Documents,
|
||||||
title: "Items",
|
title: this.tabTitle(),
|
||||||
collection: this.collection,
|
collection: this.collection,
|
||||||
node: this.collection,
|
node: this.collection,
|
||||||
tabPath: `${this.collection.databaseId}>${this.collection.id()}>Documents`,
|
tabPath: `${this.collection.databaseId}>${this.collection.id()}>Documents`,
|
||||||
|
|||||||
+11
-13
@@ -87,9 +87,7 @@ function TabNav({ tab, active, tabKind }: { tab?: Tab; active: boolean; tabKind?
|
|||||||
focusTab.current.focus();
|
focusTab.current.focus();
|
||||||
}
|
}
|
||||||
}, [active]);
|
}, [active]);
|
||||||
return (
|
const liElement = (
|
||||||
<Menu openOnContext>
|
|
||||||
<MenuTrigger disableButtonEnhancement>
|
|
||||||
<li
|
<li
|
||||||
data-test={`TabNav:${tab !== undefined ? tab.tabId : ReactTabKind[tabKind!]}`}
|
data-test={`TabNav:${tab !== undefined ? tab.tabId : ReactTabKind[tabKind!]}`}
|
||||||
onMouseOver={() => setHovering(true)}
|
onMouseOver={() => setHovering(true)}
|
||||||
@@ -163,19 +161,19 @@ function TabNav({ tab, active, tabKind }: { tab?: Tab; active: boolean; tabKind?
|
|||||||
</div>
|
</div>
|
||||||
</span>
|
</span>
|
||||||
</li>
|
</li>
|
||||||
</MenuTrigger>
|
);
|
||||||
|
|
||||||
|
if (!tab?.canDuplicate()) {
|
||||||
|
return liElement;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Menu openOnContext>
|
||||||
|
<MenuTrigger disableButtonEnhancement>{liElement}</MenuTrigger>
|
||||||
<MenuPopover>
|
<MenuPopover>
|
||||||
<MenuList>
|
<MenuList>
|
||||||
{tab?.canDuplicate() && (
|
|
||||||
<MenuItem onClick={() => tab.duplicateTab()}>{t(Keys.tabs.tabMenu.duplicateTab)}</MenuItem>
|
<MenuItem onClick={() => tab.duplicateTab()}>{t(Keys.tabs.tabMenu.duplicateTab)}</MenuItem>
|
||||||
)}
|
<MenuItem onClick={() => tab.onCloseTabButtonClick()}>{t(Keys.tabs.tabMenu.closeTab)}</MenuItem>
|
||||||
<MenuItem
|
|
||||||
onClick={() => {
|
|
||||||
tab ? tab.onCloseTabButtonClick() : useTabs.getState().closeReactTab(tabKind);
|
|
||||||
}}
|
|
||||||
>
|
|
||||||
{t(Keys.tabs.tabMenu.closeTab)}
|
|
||||||
</MenuItem>
|
|
||||||
</MenuList>
|
</MenuList>
|
||||||
</MenuPopover>
|
</MenuPopover>
|
||||||
</Menu>
|
</Menu>
|
||||||
|
|||||||
@@ -77,15 +77,13 @@ test("Duplicate Query tab preserves query text in new tab", async () => {
|
|||||||
expect(editorText).toContain("duplicate-query-test");
|
expect(editorText).toContain("duplicate-query-test");
|
||||||
});
|
});
|
||||||
|
|
||||||
test("Duplicate tab menu item is not shown for the Home tab", async () => {
|
test("Right-click context menu does not appear for the Home tab", async () => {
|
||||||
// The Home tab (ReactTabKind) is never duplicable
|
// The Home tab (ReactTabKind) is never duplicable — no context menu should appear
|
||||||
await explorer.tabNavHeader("Home").click({ button: "right" });
|
await explorer.tabNavHeader("Home").click({ button: "right" });
|
||||||
|
|
||||||
// "Close tab" should always appear
|
// Neither menu item should be visible
|
||||||
await expect(explorer.tabContextMenuItem("Close tab")).toBeVisible();
|
|
||||||
|
|
||||||
// "Duplicate tab" must NOT appear
|
|
||||||
await expect(explorer.tabContextMenuItem("Duplicate tab")).not.toBeVisible();
|
await expect(explorer.tabContextMenuItem("Duplicate tab")).not.toBeVisible();
|
||||||
|
await expect(explorer.tabContextMenuItem("Close tab")).not.toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
test("Close tab from right-click menu closes the tab", async () => {
|
test("Close tab from right-click menu closes the tab", async () => {
|
||||||
|
|||||||
Reference in New Issue
Block a user