From de4dbb9df14bfc7844f61a5e333ecf73efd4f067 Mon Sep 17 00:00:00 2001 From: Chuck Skelton Date: Fri, 15 May 2026 12:00:32 -0700 Subject: [PATCH] Addressing some PR comments --- .../ChangePartitionKeyPane.tsx | 18 +++++++++--------- src/Localization/en/Resources.json | 4 +++- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/Explorer/Panes/ChangePartitionKeyPane/ChangePartitionKeyPane.tsx b/src/Explorer/Panes/ChangePartitionKeyPane/ChangePartitionKeyPane.tsx index a0bd9c55d..e23672381 100644 --- a/src/Explorer/Panes/ChangePartitionKeyPane/ChangePartitionKeyPane.tsx +++ b/src/Explorer/Panes/ChangePartitionKeyPane/ChangePartitionKeyPane.tsx @@ -247,10 +247,10 @@ export const ChangePartitionKeyPane: React.FC = ({ const partitionKeyString = partitionKey.trim(); const partitionKeyData: DataModels.PartitionKey = partitionKeyString ? { - paths: [partitionKeyString, ...(subPartitionKeys.length > 0 ? subPartitionKeys : [])], - kind: subPartitionKeys.length > 0 ? "MultiHash" : "Hash", - version: 2, - } + paths: [partitionKeyString, ...(subPartitionKeys.length > 0 ? subPartitionKeys : [])], + kind: subPartitionKeys.length > 0 ? "MultiHash" : "Hash", + version: 2, + } : undefined; const createCollectionParams: DataModels.CreateCollectionParams = { @@ -301,7 +301,7 @@ export const ChangePartitionKeyPane: React.FC = ({ {/* Migration Type */} - Migration type + {t(Keys.containerCopy.migrationType.title)}
@@ -317,7 +317,7 @@ export const ChangePartitionKeyPane: React.FC = ({ tabIndex={0} onChange={() => setOnlineMode(false)} /> - Offline mode + {t(Keys.containerCopy.migrationType.offline.title)} = ({ tabIndex={0} onChange={() => setOnlineMode(true)} /> - Online mode + {t(Keys.containerCopy.migrationType.online.title)}
{migrationTypeContent && ( @@ -348,7 +348,7 @@ export const ChangePartitionKeyPane: React.FC = ({ - Database id + {t(Keys.panes.addDatabase.databaseIdLabel)} = ({ {!onlinePrerequisitesMet && ( - Online migration prerequisites must be enabled before proceeding. + {t(Keys.containerCopy.onlineCopyEnabled.onlineMigrationPrerequisitesMessage)} )} diff --git a/src/Localization/en/Resources.json b/src/Localization/en/Resources.json index f5ed13a65..a180bdc4e 100644 --- a/src/Localization/en/Resources.json +++ b/src/Localization/en/Resources.json @@ -1027,6 +1027,7 @@ "accountDropdownPlaceholder": "Select an account" }, "migrationType": { + "title": "Migration type", "offline": { "title": "Offline mode", "description": "Offline container copy jobs let you copy data from a source container to a destination Cosmos DB container for supported APIs. To ensure data integrity between the source and destination, we recommend stopping updates on the source container before creating the copy job. Learn more about [offline copy jobs](https://learn.microsoft.com/azure/cosmos-db/how-to-container-copy?tabs=offline-copy&pivots=api-nosql)." @@ -1120,7 +1121,8 @@ "buttonText": "Enable Online Copy", "validateAllVersionsAndDeletesChangeFeedSpinnerLabel": "Validating All versions and deletes change feed mode (preview)...", "enablingAllVersionsAndDeletesChangeFeedSpinnerLabel": "Enabling All versions and deletes change feed mode (preview)...", - "enablingOnlineCopySpinnerLabel": "Enabling online copy on your \"{{accountName}}\" account ..." + "enablingOnlineCopySpinnerLabel": "Enabling online copy on your \"{{accountName}}\" account ...", + "onlineMigrationPrerequisitesMessage": "Online migration prerequisites must be enabled before proceeding." }, "monitorJobs": { "columns": {