Add float16 data type and make vector embedding policies mutable (#2433)

* vector index work

* format

* fixed tests

---------

Co-authored-by: Asier Isayas <aisayas@microsoft.com>

src/Explorer/Controls/Settings/SettingsComponent.tsx

@@ -124,6 +124,7 @@ export interface SettingsComponentState {
 
   vectorEmbeddingPolicy: DataModels.VectorEmbeddingPolicy;
   vectorEmbeddingPolicyBaseline: DataModels.VectorEmbeddingPolicy;
+  isVectorEmbeddingPolicyValid: boolean;
   fullTextPolicy: DataModels.FullTextPolicy;
   fullTextPolicyBaseline: DataModels.FullTextPolicy;
   shouldDiscardContainerPolicies: boolean;
@@ -245,6 +246,7 @@ export class SettingsComponent extends React.Component<SettingsComponentProps, S
 
       vectorEmbeddingPolicy: undefined,
       vectorEmbeddingPolicyBaseline: undefined,
+      isVectorEmbeddingPolicyValid: true,
       fullTextPolicy: undefined,
       fullTextPolicyBaseline: undefined,
       shouldDiscardContainerPolicies: false,
@@ -372,6 +374,10 @@ export class SettingsComponent extends React.Component<SettingsComponentProps, S
       return false;
     }
 
+    if (!this.state.isVectorEmbeddingPolicyValid) {
+      return false;
+    }
+
     return (
       this.state.isScaleSaveable ||
       this.state.isSubSettingsSaveable ||
@@ -506,6 +512,7 @@ export class SettingsComponent extends React.Component<SettingsComponentProps, S
       changeFeedPolicy: this.state.changeFeedPolicyBaseline,
       autoPilotThroughput: this.state.autoPilotThroughputBaseline,
       isAutoPilotSelected: this.state.wasAutopilotOriginallySet,
+      isVectorEmbeddingPolicyValid: true,
       shouldDiscardContainerPolicies: true,
       shouldDiscardIndexingPolicy: true,
       isScaleSaveable: false,
@@ -650,6 +657,9 @@ export class SettingsComponent extends React.Component<SettingsComponentProps, S
   private onVectorEmbeddingPolicyDirtyChange = (isVectorEmbeddingPolicyDirty: boolean): void =>
     this.setState({ isContainerPolicyDirty: isVectorEmbeddingPolicyDirty });
 
+  private onVectorEmbeddingPolicyValidationChange = (isVectorEmbeddingPolicyValid: boolean): void =>
+    this.setState({ isVectorEmbeddingPolicyValid });
+
   private onFullTextPolicyDirtyChange = (isFullTextPolicyDirty: boolean): void =>
     this.setState({ isContainerPolicyDirty: isFullTextPolicyDirty });
 
@@ -1321,6 +1331,7 @@ export class SettingsComponent extends React.Component<SettingsComponentProps, S
       vectorEmbeddingPolicyBaseline: this.state.vectorEmbeddingPolicyBaseline,
       onVectorEmbeddingPolicyChange: this.onVectorEmbeddingPolicyChange,
       onVectorEmbeddingPolicyDirtyChange: this.onVectorEmbeddingPolicyDirtyChange,
+      onVectorEmbeddingPolicyValidationChange: this.onVectorEmbeddingPolicyValidationChange,
       isVectorSearchEnabled: this.isVectorSearchEnabled,
       fullTextPolicy: this.state.fullTextPolicy,
       fullTextPolicyBaseline: this.state.fullTextPolicyBaseline,

src/Explorer/Controls/Settings/SettingsSubComponents/ContainerPolicyComponent.tsx

@@ -15,6 +15,7 @@ export interface ContainerPolicyComponentProps {
   vectorEmbeddingPolicyBaseline: VectorEmbeddingPolicy;
   onVectorEmbeddingPolicyChange: (newVectorEmbeddingPolicy: VectorEmbeddingPolicy) => void;
   onVectorEmbeddingPolicyDirtyChange: (isVectorEmbeddingPolicyDirty: boolean) => void;
+  onVectorEmbeddingPolicyValidationChange: (isValid: boolean) => void;
   isVectorSearchEnabled: boolean;
   fullTextPolicy: FullTextPolicy;
   fullTextPolicyBaseline: FullTextPolicy;
@@ -31,6 +32,7 @@ export const ContainerPolicyComponent: React.FC<ContainerPolicyComponentProps> =
   vectorEmbeddingPolicyBaseline,
   onVectorEmbeddingPolicyChange,
   onVectorEmbeddingPolicyDirtyChange,
+  onVectorEmbeddingPolicyValidationChange,
   isVectorSearchEnabled,
   fullTextPolicy,
   fullTextPolicyBaseline,
@@ -43,8 +45,12 @@ export const ContainerPolicyComponent: React.FC<ContainerPolicyComponentProps> =
   const [selectedTab, setSelectedTab] = React.useState<ContainerPolicyTabTypes>(
     ContainerPolicyTabTypes.VectorPolicyTab,
   );
-  const [vectorEmbeddings, setVectorEmbeddings] = React.useState<VectorEmbedding[]>();
-  const [vectorEmbeddingsBaseline, setVectorEmbeddingsBaseline] = React.useState<VectorEmbedding[]>();
+  const [vectorEmbeddings, setVectorEmbeddings] = React.useState<VectorEmbedding[]>(
+    vectorEmbeddingPolicy?.vectorEmbeddings ?? [],
+  );
+  const [vectorEmbeddingsBaseline, setVectorEmbeddingsBaseline] = React.useState<VectorEmbedding[]>(
+    vectorEmbeddingPolicyBaseline?.vectorEmbeddings ?? [],
+  );
   const [discardVectorChanges, setDiscardVectorChanges] = React.useState<boolean>(false);
   const [fullTextSearchPolicy, setFullTextSearchPolicy] = React.useState<FullTextPolicy>();
   const [fullTextSearchPolicyBaseline, setFullTextSearchPolicyBaseline] = React.useState<FullTextPolicy>();
@@ -53,7 +59,7 @@ export const ContainerPolicyComponent: React.FC<ContainerPolicyComponentProps> =
   React.useEffect(() => {
     setVectorEmbeddings(vectorEmbeddingPolicy?.vectorEmbeddings);
     setVectorEmbeddingsBaseline(vectorEmbeddingPolicyBaseline?.vectorEmbeddings);
-  }, [vectorEmbeddingPolicy]);
+  }, [vectorEmbeddingPolicy, vectorEmbeddingPolicyBaseline]);
 
   React.useEffect(() => {
     setFullTextSearchPolicy(fullTextPolicy);
@@ -70,12 +76,15 @@ export const ContainerPolicyComponent: React.FC<ContainerPolicyComponentProps> =
     }
   });
 
-  const checkAndSendVectorEmbeddingPoliciesToSettings = (newVectorEmbeddings: VectorEmbedding[]): void => {
-    if (isDirty(newVectorEmbeddings, vectorEmbeddingsBaseline)) {
-      onVectorEmbeddingPolicyDirtyChange(true);
+  const checkAndSendVectorEmbeddingPoliciesToSettings = (
+    newVectorEmbeddings: VectorEmbedding[],
+    validationPassed: boolean,
+  ): void => {
+    onVectorEmbeddingPolicyValidationChange(validationPassed);
+    const isVectorDirty: boolean = isDirty(newVectorEmbeddings, vectorEmbeddingsBaseline);
+    onVectorEmbeddingPolicyDirtyChange(isVectorDirty);
+    if (isVectorDirty) {
       onVectorEmbeddingPolicyChange({ vectorEmbeddings: newVectorEmbeddings });
-    } else {
-      resetShouldDiscardContainerPolicyChange();
     }
   };
 
@@ -157,18 +166,18 @@ export const ContainerPolicyComponent: React.FC<ContainerPolicyComponentProps> =
             headerText={t(Keys.controls.settings.containerPolicy.vectorPolicy)}
           >
             <Stack {...titleAndInputStackProps} styles={{ root: { position: "relative", maxWidth: "400px" } }}>
-              {vectorEmbeddings && (
-                <VectorEmbeddingPoliciesComponent
-                  disabled={true}
-                  vectorEmbeddings={vectorEmbeddings}
-                  vectorIndexes={undefined}
-                  onVectorEmbeddingChange={(vectorEmbeddings: VectorEmbedding[]) =>
-                    checkAndSendVectorEmbeddingPoliciesToSettings(vectorEmbeddings)
-                  }
-                  discardChanges={discardVectorChanges}
-                  onChangesDiscarded={onVectorChangesDiscarded}
-                />
-              )}
+              <VectorEmbeddingPoliciesComponent
+                vectorEmbeddingsBaseline={vectorEmbeddingsBaseline}
+                vectorEmbeddings={vectorEmbeddings}
+                vectorIndexes={undefined}
+                onVectorEmbeddingChange={(
+                  vectorEmbeddings: VectorEmbedding[],
+                  _vectorIndexingPolicies,
+                  validationPassed: boolean,
+                ) => checkAndSendVectorEmbeddingPoliciesToSettings(vectorEmbeddings, validationPassed)}
+                discardChanges={discardVectorChanges}
+                onChangesDiscarded={onVectorChangesDiscarded}
+              />
             </Stack>
           </PivotItem>
         )}

src/Explorer/Controls/Settings/__snapshots__/SettingsComponent.test.tsx.snap

@@ -358,6 +358,7 @@ exports[`SettingsComponent renders 1`] = `
             onFullTextPolicyDirtyChange={[Function]}
             onVectorEmbeddingPolicyChange={[Function]}
             onVectorEmbeddingPolicyDirtyChange={[Function]}
+            onVectorEmbeddingPolicyValidationChange={[Function]}
             resetShouldDiscardContainerPolicyChange={[Function]}
             shouldDiscardContainerPolicies={false}
             vectorEmbeddingPolicy={{}}