Reverse cross partition query behavior in DE Query settings pane (#1521)

Co-authored-by: Predrag Klepic <v-prklepic@microsoft.com>

src/Explorer/ContextMenuButtonFactory.tsx

@@ -141,14 +141,12 @@ export const createCollectionContextMenuButton = (
   return items;
 };
 
-export const createSampleCollectionContextMenuButton = (
+export const createSampleCollectionContextMenuButton = (): TreeNodeMenuItem[] => {
-  selectedCollection: ViewModels.CollectionBase
-): TreeNodeMenuItem[] => {
   const items: TreeNodeMenuItem[] = [];
   if (userContext.apiType === "SQL") {
     items.push({
       iconSrc: AddSqlQueryIcon,
-      onClick: () => selectedCollection && useTabs.getState().openAndActivateReactTab(ReactTabKind.QueryCopilot),
+      onClick: () => useTabs.getState().openAndActivateReactTab(ReactTabKind.QueryCopilot),
       label: "New SQL Query",
     });
   }

src/Explorer/Panes/SettingsPane/SettingsPane.tsx

@@ -2,12 +2,12 @@ import { Checkbox, ChoiceGroup, IChoiceGroupOption, SpinButton } from "@fluentui
 import * as Constants from "Common/Constants";
 import { InfoTooltip } from "Common/Tooltip/InfoTooltip";
 import { configContext } from "ConfigContext";
-import { useSidePanel } from "hooks/useSidePanel";
-import React, { FunctionComponent, MouseEvent, useState } from "react";
 import { LocalStorageUtility, StorageKey } from "Shared/StorageUtility";
 import * as StringUtility from "Shared/StringUtility";
 import { userContext } from "UserContext";
 import { logConsoleInfo } from "Utils/NotificationConsoleUtils";
+import { useSidePanel } from "hooks/useSidePanel";
+import React, { FunctionComponent, MouseEvent, useState } from "react";
 import { RightPaneForm, RightPaneFormProps } from "../RightPaneForm/RightPaneForm";
 
 export const SettingsPane: FunctionComponent = () => {
@@ -29,7 +29,7 @@ export const SettingsPane: FunctionComponent = () => {
   const [crossPartitionQueryEnabled, setCrossPartitionQueryEnabled] = useState<boolean>(
     LocalStorageUtility.hasItem(StorageKey.IsCrossPartitionQueryEnabled)
       ? LocalStorageUtility.getEntryString(StorageKey.IsCrossPartitionQueryEnabled) === "true"
-      : true
+      : false
   );
   const [graphAutoVizDisabled, setGraphAutoVizDisabled] = useState<string>(
     LocalStorageUtility.hasItem(StorageKey.IsGraphAutoVizDisabled)

src/Explorer/Panes/SettingsPane/__snapshots__/SettingsPane.test.tsx.snap

@@ -142,7 +142,7 @@ exports[`Settings Pane should render Default properly 1`] = `
         </div>
         <StyledCheckboxBase
           ariaLabel="Enable cross partition query"
-          checked={true}
+          checked={false}
           className="padding"
           onChange={[Function]}
           styles={

src/Explorer/QueryCopilot/Modal/WelcomeModal.tsx

@@ -18,7 +18,6 @@ export const WelcomeModal = ({ visible }: { visible: boolean }): JSX.Element =>
 
   return (
     <>
-      (
       <Modal isOpen={isModalVisible} onDismiss={hideModal} isBlocking={false}>
         <Stack className="modalContentPadding">
           <Stack horizontal>
@@ -110,7 +109,6 @@ export const WelcomeModal = ({ visible }: { visible: boolean }): JSX.Element =>
           </Stack>
         </Stack>
       </Modal>
-      )
     </>
   );
 };

src/Explorer/QueryCopilot/QueryCopilotTab.tsx

@@ -294,6 +294,7 @@ export const QueryCopilotTab: React.FC<QueryCopilotTabProps> = ({
       generateSQLQuery();
     }
     showTeachingBubble();
+    useTabs.getState().setIsQueryErrorThrown(false);
   }, []);
 
   return (
@@ -447,19 +448,17 @@ export const QueryCopilotTab: React.FC<QueryCopilotTabProps> = ({
         <Link href="" target="_blank">
           Read preview terms
         </Link>
-        {showErrorMessageBar ? (
+        {showErrorMessageBar && (
           <Stack style={{ backgroundColor: "#FEF0F1", padding: "4px 8px" }} horizontal verticalAlign="center">
             <Image src={XErrorMessage} style={{ marginRight: "8px" }} />
             <Text style={{ fontSize: 12 }}>
               We ran into an error and were not able to execute query. Please try again after sometime
             </Text>
           </Stack>
-        ) : (
-          <></>
         )}
       </Text>
 
-      {showFeedbackBar ? (
+      {showFeedbackBar && (
         <Stack style={{ backgroundColor: "#FFF8F0", padding: "2px 8px" }} horizontal verticalAlign="center">
           <Text style={{ fontWeight: 600, fontSize: 12 }}>Provide feedback on the query generated</Text>
           {showCallout && !hideFeedbackModalForLikedQueries && (
@@ -527,8 +526,6 @@ export const QueryCopilotTab: React.FC<QueryCopilotTabProps> = ({
             Delete code
           </CommandBarButton>
         </Stack>
-      ) : (
-        <></>
       )}
 
       <Stack className="tabPaneContentContainer">
@@ -552,9 +549,9 @@ export const QueryCopilotTab: React.FC<QueryCopilotTabProps> = ({
           />
         </SplitterLayout>
       </Stack>
-      <WelcomeModal visible={localStorage.getItem("hideWelcomeModal") !== "true"}></WelcomeModal>
+      <WelcomeModal visible={localStorage.getItem("hideWelcomeModal") !== "true"} />
-      {isSamplePromptsOpen ? <SamplePrompts sampleProps={sampleProps} /> : <></>}
+      {isSamplePromptsOpen && <SamplePrompts sampleProps={sampleProps} />}
-      {query !== "" && query.trim().length !== 0 ? (
+      {query !== "" && query.trim().length !== 0 && (
         <DeletePopup
           showDeletePopup={showDeletePopup}
           setShowDeletePopup={setShowDeletePopup}
@@ -562,8 +559,6 @@ export const QueryCopilotTab: React.FC<QueryCopilotTabProps> = ({
           clearFeedback={resetButtonState}
           showFeedbackBar={setShowFeedbackBar}
         />
-      ) : (
-        <></>
       )}
       <CopyPopup showCopyPopup={showCopyPopup} setShowCopyPopup={setshowCopyPopup} />
     </Stack>

src/Explorer/Tree/SampleDataTree.tsx

@@ -29,9 +29,7 @@ export const SampleDataTree = ({
             iconSrc: CollectionIcon,
             isExpanded: false,
             className: "dataResourceTree",
-            contextMenu: ResourceTreeContextMenuButtonFactory.createSampleCollectionContextMenuButton(
+            contextMenu: ResourceTreeContextMenuButtonFactory.createSampleCollectionContextMenuButton(),
-              sampleDataResourceTokenCollection
-            ),
             onClick: () => {
               // Rewritten version of expandCollapseCollection
               useSelectedNode.getState().setSelectedNode(sampleDataResourceTokenCollection);