mirror of
https://github.com/Azure/cosmos-explorer.git
synced 2025-12-29 22:02:01 +00:00
Fix eslint issues for 5 files
This commit is contained in:
@@ -5,6 +5,7 @@ import template from "./editor-component.html";
|
||||
/**
|
||||
* Helper class for ko component registration
|
||||
*/
|
||||
//eslint-disable-next-line
|
||||
export class EditorComponent {
|
||||
constructor() {
|
||||
return {
|
||||
@@ -38,7 +39,7 @@ class EditorViewModel extends JsonEditorViewModel {
|
||||
* setTimeout is needed as creating the edtior manipulates the dom directly and expects
|
||||
* Knockout to have completed all of the initial bindings for the component
|
||||
*/
|
||||
this.params.content() != null &&
|
||||
this.params.content() !== undefined &&
|
||||
setTimeout(() => {
|
||||
this.createEditor(this.params.content(), this.configureEditor.bind(this));
|
||||
});
|
||||
|
||||
@@ -16,7 +16,7 @@ export interface NotebookComponentAdapterOptions {
|
||||
|
||||
export class NotebookComponentAdapter extends NotebookComponentBootstrapper implements ReactAdapter {
|
||||
private onUpdateKernelInfo: () => void;
|
||||
public parameters: any;
|
||||
public parameters: undefined;
|
||||
|
||||
constructor(options: NotebookComponentAdapterOptions) {
|
||||
super({
|
||||
|
||||
@@ -43,7 +43,9 @@ const makeMapStateToProps = (
|
||||
const { contentRef } = initialProps;
|
||||
const mapStateToProps = (state: AppState) => {
|
||||
const content = selectors.content(state, { contentRef });
|
||||
let kernelStatus, kernelSpecName, currentCellType;
|
||||
let kernelStatus,
|
||||
kernelSpecName,
|
||||
currentCellType = "";
|
||||
|
||||
if (!content || content.type !== "notebook") {
|
||||
return {
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
/* eslint jsx-a11y/no-static-element-interactions: 0 */
|
||||
/* eslint jsx-a11y/click-events-have-key-events: 0 */
|
||||
// /* eslint jsx-a11y/no-static-element-interactions: 0 */
|
||||
// /* eslint jsx-a11y/click-events-have-key-events: 0 */
|
||||
|
||||
import { actions, AppState, ContentRef, selectors } from "@nteract/core";
|
||||
import React from "react";
|
||||
@@ -23,7 +23,7 @@ interface DispatchProps {
|
||||
type Props = ComponentProps & DispatchProps & StateProps;
|
||||
|
||||
export class HijackScroll extends React.Component<Props> {
|
||||
el: HTMLDivElement | null = null;
|
||||
el: HTMLDivElement | null = undefined;
|
||||
|
||||
scrollIntoViewIfNeeded(prevFocused?: boolean): void {
|
||||
// Check if the element is being hovered over.
|
||||
@@ -38,6 +38,7 @@ export class HijackScroll extends React.Component<Props> {
|
||||
) {
|
||||
if (this.el && "scrollIntoViewIfNeeded" in this.el) {
|
||||
// This is only valid in Chrome, WebKit
|
||||
//eslint-disable-next-line
|
||||
(this.el as any).scrollIntoViewIfNeeded();
|
||||
} else if (this.el) {
|
||||
// Make a best guess effort for older platforms
|
||||
@@ -46,7 +47,7 @@ export class HijackScroll extends React.Component<Props> {
|
||||
}
|
||||
}
|
||||
|
||||
componentDidUpdate(prevProps: Props) {
|
||||
componentDidUpdate(prevProps: Props): void {
|
||||
this.scrollIntoViewIfNeeded(prevProps.focused);
|
||||
}
|
||||
|
||||
@@ -54,7 +55,7 @@ export class HijackScroll extends React.Component<Props> {
|
||||
this.scrollIntoViewIfNeeded();
|
||||
}
|
||||
|
||||
render() {
|
||||
render(): JSX.Element {
|
||||
return (
|
||||
<div
|
||||
onClick={this.props.selectCell}
|
||||
|
||||
Reference in New Issue
Block a user